[GitHub] cordova-plugin-media pull request #110: CB-11085 (Android) Fixed AudioHandle...

2016-08-23 Thread sanjeewa894
GitHub user sanjeewa894 reopened a pull request: https://github.com/apache/cordova-plugin-media/pull/110 CB-11085 (Android) Fixed AudioHandler logs should use system log, not println ### Platforms affected Android ### What does this PR do? This is a fix fo

[GitHub] cordova-plugin-media issue #110: CB-11085 (Android) Fixed AudioHandler logs ...

2016-08-23 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-media/pull/110 @sanjeewa894, you should not close your PRs in case you want them to be merged in. PRs are sometimes being closed by asfgit bot, which occurs when a commit contains "Closes #PR-NUMB

RE: i want to be a contributor

2016-08-23 Thread Vladimir Kotikov (Akvelon)
Welcome, Zam! Please also take a look at the contributing guidelines here: http://cordova.apache.org/contribute/contribute_guidelines.html - Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, August 23, 2016 10:57 PM To: dev@cordo

[Discuss] plugins release

2016-08-23 Thread Steven Gill
Thoughts? Any PRs to bring to my attention? Will aim to start it later this week.

Nightly build #110 for cordova has succeeded!

2016-08-23 Thread Apache Jenkins Server
Nightly build #110 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/110/consoleFull - Jenkins for Apache Cordova -

Re: CB-9963 iOS uuid should remain even after uninstall

2016-08-23 Thread Jesse
Please do not add this to the cordova-plugin-device, if you want to create a new plugin to handle this, then go for it. Apple restricted the real uuid's use for a reason, and cordova should respect it. @purplecabbage risingj.com On Tue, Aug 23, 2016 at 12:05 PM, julio cesar sanchez < jcesarmob..

[GitHub] cordova-docs pull request #630: Added android ios release blog post

2016-08-23 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-docs/pull/630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-docs issue #630: Added android ios release blog post

2016-08-23 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/630 This has been merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[VOTE] Cordova-create@1.0.0 release

2016-08-23 Thread Steven Gill
Please review and vote on this cordova-create Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11722 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11722/ The packag

[GitHub] cordova-coho pull request #133: added create to tools release process

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request #133: added create to tools release process

2016-08-23 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/133 added create to tools release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-55 Alternatively y

Re: i want to be a contributor

2016-08-23 Thread Steven Gill
Welcome Zam! Let us know if you have any questions! We would love to have you contribute. Feel free to join us at slack.cordova.io. Cheers, -Steve On Tue, Aug 23, 2016 at 9:02 AM, Zam Light wrote: > Hi : > i am Zam. > Currently, I am working on project with Cordova, and i have commit some > us

Re: Granting permission to Assign Improvement

2016-08-23 Thread Shazron
Done On Tue, Aug 23, 2016 at 12:21 PM, sanjeewa kumara wrote: > Hi, > > Currently I am fixing CB-11085. can someone assign me to it? > > https://issues.apache.org/jira/browse/CB-11085 > > - > To unsubscribe, e-mail: dev-unsubscr

[GitHub] cordova-plugin-dialogs issue #83: CB-11281 windows: defaultText is taken as ...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/83 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/83/commits/484ad35659d50b2d66539b6a7b77ffde6d76d7f

Re: How to run a unit test for a plugin

2016-08-23 Thread Deshan Kalupahana
Ok. Fixed and PR that with https://github.com/apache/cordova-plugin-dialogs/pull/83. Admins can merge it Thanks for the help On Tue, Aug 23, 2016 at 11:18 PM, Shazron wrote: > In this case since its a manual test just update the existing testfile. > > On Tue, Aug 23, 2016 at 7:54 AM, Deshan Kalu

[GitHub] cordova-plugin-dialogs pull request #83: CB-11281 windows: defaultText is ta...

2016-08-23 Thread DeshanKTD
GitHub user DeshanKTD opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/83 CB-11281 windows: defaultText is taken as input for empty input field ### Platforms affected Windows ### What does this PR do? CB-11281 issue fixed. If the

[GitHub] cordova-plugin-media pull request #110: CB-11085 (Android) Fixed AudioHandle...

2016-08-23 Thread sanjeewa894
Github user sanjeewa894 closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Granting permission to Assign Improvement

2016-08-23 Thread sanjeewa kumara
Hi, Currently I am fixing CB-11085. can someone assign me to it? https://issues.apache.org/jira/browse/CB-11085 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apach

[GitHub] cordova-plugin-media issue #110: CB-11085 (Android) Fixed AudioHandler logs ...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/110 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/110/commits/c1c01b1834e1a37158b6de247ac444a1d49fbdbf)

Re: CB-9963 iOS uuid should remain even after uninstall

2016-08-23 Thread julio cesar sanchez
As the issue is an improvement and not a bug, I think we should discuss if this should be added. I commented this on the issue long time ago So I think that storing the identifierForVendor on the keychain might be a good idea, but not sure if we should add it to the device plugin or if the develo

[ANNOUNCE] Cordova-android@5.2.2 & cordova-ios@4.2.1 Released

2016-08-23 Thread Steven Gill
Blog: http://cordova.apache.org/announcements/2016/08/22/android-ios-release.html Tweet: https://twitter.com/apachecordova/status/768158769897361408

[GitHub] cordova-plugin-media pull request #110: CB-11085 (Android) Fixed AudioHandle...

2016-08-23 Thread sanjeewa894
GitHub user sanjeewa894 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/110 CB-11085 (Android) Fixed AudioHandler logs should use system log, not println ### Platforms affected Android ### What does this PR do? This is a fix for

Re: How to run a unit test for a plugin

2016-08-23 Thread Shazron
In this case since its a manual test just update the existing testfile. On Tue, Aug 23, 2016 at 7:54 AM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > It worked. Thanks. > Can I change existing tests to support my bug fix or should i write a new > file? > > On Tue, Aug 23, 2016 at 12:2

Re: CB-9963 iOS uuid should remain even after uninstall

2016-08-23 Thread Shazron
Done. On Tue, Aug 23, 2016 at 10:15 AM, Zam Light wrote: > Hi: > > i want to solve this issue with below link, could someone assign me to it? > > https://issues.apache.org/jira/browse/CB-9963?focusedCommentId=15432832&; > page=com.atlassian.jira.plugin.system.issuetabpanels: > comment-tabpanel#c

Re: How to run a unit test for a plugin

2016-08-23 Thread Jesse
Bugfix pull requests that come with a test to prove they fix the defect are our absolute favorites! @purplecabbage risingj.com On Tue, Aug 23, 2016 at 7:54 AM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > It worked. Thanks. > Can I change existing tests to support my bug fix or shou

CB-9963 iOS uuid should remain even after uninstall

2016-08-23 Thread Zam Light
Hi: i want to solve this issue with below link, could someone assign me to it? https://issues.apache.org/jira/browse/CB-9963?focusedCommentId=15432832&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15432832 -- Best Regards, Zam

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2016-08-23 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 Rebased, but still blocked on the cordova-lib PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

i want to be a contributor

2016-08-23 Thread Zam Light
Hi : i am Zam. Currently, I am working on project with Cordova, and i have commit some useful feature, so i want to merge back for others. -- Best Regards, Zam

Re: How to run a unit test for a plugin

2016-08-23 Thread Deshan Kalupahana
It worked. Thanks. Can I change existing tests to support my bug fix or should i write a new file? On Tue, Aug 23, 2016 at 12:23 PM, Shazron wrote: > A slower way would be to send the pull request and let the CI test it i.e > https://github.com/apache/cordova-plugin-dialogs/pull/82 > > On Mon, Au

[GitHub] cordova-plugin-media issue #109: CB-11086 (Android) Fixed a crash when setVo...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/109 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/109/commits/6c923c9b21a5417dc343aec901935be06e087e63)

[GitHub] cordova-plugin-media pull request #109: CB-11086 (Android) Fixed a crash whe...

2016-08-23 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/109 CB-11086 (Android) Fixed a crash when setVolume() is called ### Platforms affected Android ### What does this PR do? This is a fix for https://issues.apache.org/jira/

[GitHub] cordova-plugin-media-capture issue #63: [CB-11441] iOS: camera direction

2016-08-23 Thread leshik
Github user leshik commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/63 @Sitebase There is something wrong with constants. Neither `Camera.CAMERA_FRONT` nor `Capture.CAMERA_FRONT` works. Providing `1` do the trick, however. --- If your project is se

[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/233/commits/b89645c7498d6002d1f6cdf2bdf3a93f5631016

[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds

2016-08-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/613 Updated and merged. Thanks, @dblotsky, @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request #613: CB-11477 Add a page about nightly builds

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/233/commits/c675d35a2e3848ccbb7e6a8fdeb1235e62e5b787

[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/233/commits/e7fabeb45a531773fbea273755b5c3b1b72177a4

[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/233/commits/11e300a42ddb72a7228a0fcecf1477e5ac66b197

[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...

2016-08-23 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/233/commits/ba6cacd3d0fc832eaeb0a3c9d1243d9b21248f00

[GitHub] cordova-windows pull request #172: CB-11176 Fix windows-splashscreen compati...

2016-08-23 Thread cadesalaberry
Github user cadesalaberry commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/172#discussion_r75856167 --- Diff: cordova-js-src/exec.js --- @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy'); */ module.exports = function (

[GitHub] cordova-plugin-camera pull request #233: CB-11295 Add WP8.1 quirk when choos...

2016-08-23 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/233 CB-11295 Add WP8.1 quirk when choosing image from photoalbum ### Platforms affected Windows (Windows Phone 8.1) ### What does this PR do? Updates pl

[GitHub] cordova-plugin-inappbrowser pull request #168: Window size and position in b...

2016-08-23 Thread ruvak
Github user ruvak closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-windows issue #157: TypeScript Error

2016-08-23 Thread cadesalaberry
Github user cadesalaberry commented on the issue: https://github.com/apache/cordova-windows/pull/157 It seems like VisualStudio got their shit together and fixed it. The following version does not need this PR: ``` Microsoft Visual Studio Community 2015 Version 14.0

[GitHub] cordova-plugin-file-transfer pull request #124: Fix exception thrown by call...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2016-08-23 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 This PR needs to be re-based. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cordova-plugin-file-transfer issue #140: CB-11067 - Adds content-length to m...

2016-08-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/140 @oddcb, any updates? Is this still actual? If not, please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file-transfer issue #139: Insert Content-Type to each part of...

2016-08-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/139 @claudiobadii, thanks for contribution. However the fix already has been merged in #149, so please close this PR. --- If your project is set up for it, you can reply t

i want to be a contributor

2016-08-23 Thread Zam Light
Hi : i am Zam. Currently, I am working on project with Cordova, and i have commit some useful feature, so i want to merge back for others. -- Best Regards, Zam

[GitHub] cordova-plugin-file pull request #192: CB-11368 android: Resolve content URL...

2016-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file issue #192: CB-11368 android: Resolve content URLs produ...

2016-08-23 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file/pull/192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

Re: How to run a unit test for a plugin

2016-08-23 Thread Shazron
Install cordova-paramedic from its repo url or npmjs. See https://github.com/apache/cordova-paramedic In the root of the plugin folder: cordova-paramedic --plugin . --platform windows On Mon, Aug 22, 2016 at 11:36 PM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > Hi, > > I'm currently