Nightly build #113 for cordova has succeeded!

2016-08-26 Thread Apache Jenkins Server
Nightly build #113 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/113/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-08-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 Filed https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-wkwebview-engine pull request #16: CB-11554 - too 'brutal' ap...

2016-08-26 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 CB-11554 - too 'brutal' app reload when title is empty You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-p

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-26 Thread goshakkk
Github user goshakkk commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/55 Signed and emailed the ICLA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[ANNOUNCE] Cordova-create@1.0.0 released

2016-08-26 Thread Steven Gill
https://www.npmjs.com/package/cordova-create I will blog about it in the next tools release. Cheers, -Steve

Re: [VOTE] Cordova-create@1.0.0 release

2016-08-26 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Vladimir Kotikov Shazron Abdullah Jesse MacFadyen The vote has passed. On Fri, Aug 26, 2016 at 12:47 AM, Jesse wrote: > I vote +1 > > * Verified archives using coho verify-archive > * Ran coho check-license > * Ens

[GitHub] cordova-lib issue #486: CB-11776 check edit-config target exists

2016-08-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/486 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) is 80.78% (diff: 100%) > Merging [#486](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) into [ma

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 Sounds good @swbradshaw. It looks like https://github.com/apache/cordova-plugin-camera/commit/fed798e6c7f56e23bff994ab2c11d316c8257a78 created some conflicts. I'll hold off on the r

[GitHub] cordova-plugin-media pull request #114: CB-11380 (ios) Overloaded audioFileF...

2016-08-26 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

2016-08-26 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 Thanks Shazron! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib pull request #487: CB-11777: Restore plugins before preparing

2016-08-26 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/487 CB-11777: Restore plugins before preparing When running `cordova prepare` to restore platforms and plugins, the platform has prepare called before the plugins are restored. This leads to the to

[GitHub] cordova-lib pull request #486: CB-11776 check edit-config target exists

2016-08-26 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/486 CB-11776 check edit-config target exists Missing a case in the conflict checking for edit-config. If the target doesn't exist in .json, and cannot resolve to an existing target, then no conflict

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-26 Thread swbradshaw
Github user swbradshaw commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @stevengill ill take a look this weekend. This is my first PR/rebase so I've got some homework to do --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @swbradshaw any chance you can deal with the merge conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

2016-08-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 LGTM 👍 Tested locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-media issue #114: CB-11380 (ios) Overloaded audioFileForResou...

2016-08-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/114/commits/9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09)

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-26 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/55 @nnixaa there are plans, but I'm waiting for @goshakkk to send his ICLA and make the changes I proposed --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-plugin-media pull request #114: CB-11380 (ios) Overloaded audioFileF...

2016-08-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/114 CB-11380 (ios) Overloaded audioFileForResource method instead of modi… ### Platforms affected ios ### What does this PR do? https://issues.apache.org/jira/browse/CB

[GitHub] cordova-plugin-splashscreen pull request #106: CB-7497: (iOS) Fix bug with a...

2016-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-media pull request #104: Acc+

2016-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

RE: cordova-plugin-media git commit: CB-11380 (ios) Updated modified method signature in the .h file

2016-08-26 Thread Alexander Sorokin (Akvelon)
Oh, I didn’t mean to break the API. I agree, let me do this and send the PR shortly. Thanks, Alexander Sorokin From: Shazron Sent: Friday, August 26, 2016 6:42 PM To: alsoro...@apache.org Cc: comm...@cordova.apache.org

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-08-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/244 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/244?src=pr) is 53.18% (diff: 11.11%) > Merging [#244](https://codecov.io/gh/apache/cordova-ios/pull/244?src=pr) into [

[GitHub] cordova-lib issue #485: CB-11771 Deep symlink directories to target project ...

2016-08-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/485 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/485?src=pr) is 80.81% (diff: 88.88%) > Merging [#485](https://codecov.io/gh/apache/cordova-lib/pull/485?src=pr) into [

[GitHub] cordova-android issue #326: CB-11771 Deep symlink directories to target proj...

2016-08-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/326 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/326?src=pr) is 33.67% (diff: 20.00%) > Merging [#326](https://codecov.io/gh/apache/cordova-android/pull/326?sr

[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...

2016-08-26 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/485 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symli

Re: cordova-plugin-media git commit: CB-11380 (ios) Updated modified method signature in the .h file

2016-08-26 Thread Shazron
I think we should add an overload and add back the old API method, since this is effectively removing API and we don't want the hassle of a major version bump. On Friday, August 26, 2016, wrote: > Repository: cordova-plugin-media > Updated Branches: > refs/heads/master 910d3c798 -> 42b279b91 >

[GitHub] cordova-ios pull request #244: CB-11771 Deep symlink directories to target p...

2016-08-26 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-ios/pull/244 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is symli

[GitHub] cordova-android pull request #326: CB-11771 Deep symlink directories to targ...

2016-08-26 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-android/pull/326 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is s

[GitHub] cordova-plugin-media issue #104: Acc+

2016-08-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/104 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/42b279b911c4b20689290f55ecb849905d3f1673)

[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/113 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/113/commits/ad047a1b26228717c4226289a0c4772eb02dc677)

[GitHub] cordova-plugin-media pull request #113: CB-11757 (ios) Error out if trying t...

2016-08-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/113 CB-11757 (ios) Error out if trying to stop playback while in a wrong … ### Platforms affected ios ### What does this PR do? https://issues.apache.org/jira/brow

[PROPOSAL] Using cordovaDependencies in core plugins

2016-08-26 Thread Vladimir Kotikov (Akvelon)
Hey all We've been researching ways to prevent cordova workflow breakages, caused by installing edge versions of the plugins, which possibly could be incompatible with cordova version, used by user. This is IMO a very nasty sort of problems, because it might cause unpredictable build- and runti

[GitHub] cordova-plugin-media issue #104: Acc+

2016-08-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/104 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/910d3c798f77c63165be508125ec313e4104b541)

[GitHub] cordova-plugin-media pull request #112: CB-11380 (ios) Fixed an unexpected e...

2016-08-26 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-media issue #112: CB-11380 (ios) Fixed an unexpected error ca...

2016-08-26 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/112 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/112/commits/910d3c798f77c63165be508125ec313e4104b541)

Re: [VOTE] Cordova-create@1.0.0 release

2016-08-26 Thread Jesse
I vote +1 * Verified archives using coho verify-archive * Ran coho check-license * Ensured tests are passing @purplecabbage risingj.com On Thu, Aug 25, 2016 at 11:32 PM, Shazron wrote: > I vote +1 > > * Verified archives using coho verify-archive > * Ran coho check-license > * Ensured tests a