Nightly build #164 for cordova has failed

2016-09-30 Thread Apache Jenkins Server
Nightly build #164 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/164/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/164/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Hmm. On multiple runs, sometimes the `www` folder is not there, so I'm not sure what's going on -- doesn't seem to be reliable. I'll dig in later. --- If your project is set up for it, you can

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Updated, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...

2016-09-30 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/257#discussion_r81437971 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -88,25 +89,61 @@ module.exports.run = function (buildOpts) {

[GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...

2016-09-30 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/257#discussion_r81437882 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -88,25 +89,61 @@ module.exports.run = function (buildOpts) {

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Solved it. I had to add `--packageType=development`. If the `packageType` flag was omitted, there was no `www` folder. This is strange since the exportOptions method should default to

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 If I add the `www` folder into `Copy Bundle Resources` it is fine: ![screen shot 2016-09-30 at 5 14 39

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue not for a development build using a dev cert, at least for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 The www files aren't anywhere in the .ipa? I've been making .ipa builds with an enterprise cert for a few weeks now and uploading them for our QA team, and nobody has reported any issues 😕

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 One flaw with this export archive business -- the .app in the .ipa that is packaged does *not* contain the `www` folder thus the cordova app will crash when run using `cordova run --device`.

Re: [VOTE] cordova-plugin-geolocation@2.4.0 Release

2016-09-30 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Jesse MacFadyen Shazron Abdullah The vote has passed. I will now publish to dist + npm On Thu, Sep 29, 2016 at 3:34 PM, Jesse wrote: > I vote +1: > * Ran coho audit-license-headers over

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Thanks @shazron! I've pushed that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Attached the patch for your xcodebuild branch. I tried to send a PR to your branch but Github's interface just didn't allow me to.

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 I'm going to work on the unzip part and send a patch to @dpogue -- this should be the last PR before we lock it down for cordova-ios 4.3.0 release --- If your project is set up for it, you can

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Oops sorry, I'll re-open the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-30 Thread mbektchiev
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 Thanks, @shazron I noticed that you've marked the Jira Issue as resolved. In order to completely fix it we should also merge https://github.com/apache/cordova-android/pull/326 and

[GitHub] cordova-ios pull request #244: CB-11771 Deep symlink directories to target p...

2016-09-30 Thread mbektchiev
Github user mbektchiev closed the pull request at: https://github.com/apache/cordova-ios/pull/244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts issue #138: CB-11541 iOS: Add extra labels for phone...

2016-09-30 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/138 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts issue #138: CB-11541 iOS: Add extra labels for phone...

2016-09-30 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/138 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Sorry spoke too soon, turns out you still need `--developmentTeam` since I didn't realize I was using Xcode 7 command line tools :/ Also, the .app symlink in

[GitHub] cordova-plugin-contacts pull request #138: Add extra labels for phone, ims

2016-09-30 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/138 Add extra labels for phone, ims ### Platforms affected iOS ### What does this PR do? Refactor converting methods. Add posibility to use default

[GitHub] cordova-lib pull request #494: Documentation for using cordova-lib with gulp

2016-09-30 Thread mspace
Github user mspace closed the pull request at: https://github.com/apache/cordova-lib/pull/494 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #494: Documentation for using cordova-lib with gulp

2016-09-30 Thread mspace
Github user mspace commented on the issue: https://github.com/apache/cordova-lib/pull/494 Ok, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,