Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/637
Thanks for the fix beast
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on the issue:
https://github.com/apache/cordova-docs/pull/640
The changes seem fine, but they should be made in crowdin. The changes made
in this PR would get overwritten by translation builds.
---
If your project is set up for it, you can reply to
Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/639
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/647
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-motion/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-orientation/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-console/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-legacy-whitelist/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Nightly build #168 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/168/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/168/consoleFull
-
Jenkins for Apache Cordova
https://github.com/apache/cordova-docs/pull/647
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/647
added release blog post for geolocation, create and app-hello-world
any feedback?
You can merge this pull request into a Git repository by running:
$ git pull
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/158
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Going to merge in the edit-config pr [1] and start a release tomorrow.
Any objections?
[1] https://github.com/apache/cordova-lib/pull/492
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/158
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/197
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/197
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file/pull/197/commits/97913236aac42b1e19c765495552842a99b26489)
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81866162
--- Diff: plugin.xml ---
@@ -109,8 +109,10 @@
xmlns:android="http://schemas.android.com/apk/res/android;
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/197
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81862737
--- Diff: plugin.xml ---
@@ -119,11 +121,7 @@ If this is an update to an existing application that
did not specify an "Android
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81863003
--- Diff: plugin.xml ---
@@ -109,8 +109,10 @@
xmlns:android="http://schemas.android.com/apk/res/android;
-
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81862840
--- Diff: plugin.xml ---
@@ -109,8 +109,10 @@
xmlns:android="http://schemas.android.com/apk/res/android;
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/197
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file/pull/197/commits/dd18b50900bdf05826c72314a8ffd831f8fc4599)
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/197
CB-11947 fixed typo that occurs when adding file-transfer plugin to android
### Platforms affected
### What does this PR do?
CB-11947 fixed typo that occurs
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/141#discussion_r81827457
--- Diff: src/platform-release.js ---
@@ -59,6 +59,36 @@ function cpAndLog(src, dest) {
}
}
+/*
+ * A function that
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/257
Thanks @dpogue, I'll do final tests and pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Yeah, I think we shouldn't break users. That said, I do think
PauseOnBackground should be a new feature. I don't know if it'll land in
6.0 though, since I want to get the vote out this week.
On Tue, Oct 4, 2016 at 10:40 AM, Shazron wrote:
> We could like you said make a
The vote has now closed. The results are:
Positive Binding Votes: 3
Steve Gill
Shazron Abdullah
Vladimir Kotikov
The vote has passed.
On Tue, Oct 4, 2016 at 12:43 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> I vote +1:
> * Ran coho audit-license-headers over the relevant
We could like you said make a breaking change, but allow a preference to be
set.
We either make the preference backwards compatible (ie KeepRunning = true)
so existing apps still work the same on Cordova-Android 6, or break
backwards compatibility with KeepRunning=false as default.
I would
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/257
@shazron Fixed an issue with the `rm` that was causing ENOENT on initial
builds. Tests should pass now.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/495
CB-8995 renamed start to plugman install/uninstall start to make Cordâ¦
CB-8995 renamed "start" to "plugman install/uninstall start" to make
CordovaLib tests more descriptive
You can merge
Github user sosahvictor commented on the issue:
https://github.com/apache/cordova-docs/pull/646
Thanks for putting this together, @shazron.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-docs/pull/646
+1 LGTM :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/17#discussion_r81724529
--- Diff: lib/PluginsManager.js ---
@@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins
= function () {
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81722427
--- Diff: tests/hooks/after_prepare.js ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env node
+
+/*
+*
+* Licensed to the
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81722419
--- Diff: tests/hooks/after_prepare.js ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env node
+
+/*
+*
+* Licensed to
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/17#discussion_r81720400
--- Diff: lib/PluginsManager.js ---
@@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins
= function () {
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/17#discussion_r81718373
--- Diff: lib/PluginsManager.js ---
@@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins
= function () {
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81716605
--- Diff: tests/hooks/after_prepare.js ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env node
+
+/*
+*
+* Licensed to the
Github user brutalcrozt commented on the issue:
https://github.com/apache/cordova-cli/pull/255
update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Voted!
Actually, I was thinking about removing this ‘link & run tests’ step before
publishing – I think we already run tests on Travis and AppVeyor so doing this
also on Jenkins is a bit excessive
Thoughts?
-
Best regards, Vladimir
From: Shazron [mailto:shaz...@gmail.com]
Sent: Tuesday,
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have
Apache-compatible licenses
* Ran npm test for cordova create
-
Best regards, Vladimir
-Original Message-
From: Shazron
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81698327
--- Diff: tests/hooks/after_prepare.js ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env node
+
+/*
+*
+* Licensed to
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81697958
--- Diff: tests/hooks/after_prepare.js ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env node
+
+/*
+*
+* Licensed to
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81697360
--- Diff: tests/hooks/after_prepare.js ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env node
+
+/*
+*
+* Licensed to
Yes, I think that will screw a lot of apps that keep running in the
background. Maybe it should be a config.xml preference with default value
not to pause it.
But my real opinion about this issue is that I don't think the videos
should be embedded into the app, people should use inAppBrowser to
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695543
--- Diff: lib/PluginsManager.js ---
@@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins
= function () {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695102
--- Diff: lib/PluginsManager.js ---
@@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins
= function () {
Github user claudioviola commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/198
Is there any news about this pull request?
My version is 2.3.0 and I see the bug. At moment for fix it the only way is
to download this and merge manually?
76 matches
Mail list logo