[GitHub] cordova-docs issue #640: Make more comprehensible the french documentation

2016-10-04 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/640 You can find it at https://crowdin.com/project/cordova --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-docs issue #636: Update the plugman test for android

2016-10-04 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/636 Hey @carlofragni! Plugman workflow usually means creating your application from the platforms scripts and not from the cordova-cli. For the cordova-cli, you should just use `cordova

[GitHub] cordova-docs issue #637: Busted link

2016-10-04 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/637 Thanks for the fix beast --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cordova-docs pull request #637: Busted link

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/637 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs issue #640: Make more comprehensible the french documentation

2016-10-04 Thread dblotsky
Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/640 The changes seem fine, but they should be made in crowdin. The changes made in this PR would get overwritten by translation builds. --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs issue #639: Xcode Other linker flags

2016-10-04 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/639 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-docs pull request #639: Xcode Other linker flags

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request #647: added release blog post for geolocation, cre...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-file pull request #196: CB-11917 - Remove pull request templa...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-camera pull request #237: CB-11917 - Remove pull request temp...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request #189: CB-11917 - Remove pull reques...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-file-transfer pull request #158: CB-11917 - Remove pull reque...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-contacts pull request #137: CB-11917 - Remove pull request te...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-media pull request #118: CB-11917 - Remove pull request templ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-splashscreen pull request #115: CB-11917 - Remove pull reques...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-dialogs pull request #87: CB-11917 - Remove pull request temp...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-geolocation pull request #82: CB-11917 - Remove pull request ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media-capture pull request #71: CB-11917 - Remove pull reques...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-device pull request #56: CB-11917 - Remove pull request templ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-statusbar pull request #66: CB-11917 - Remove pull request te...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-globalization pull request #51: CB-11917 - Remove pull reques...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-vibration pull request #50: CB-11917 - Remove pull request te...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-network-information pull request #50: CB-11917 - Remove pull ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-device-motion pull request #48: CB-11917 - Remove pull reques...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-device-orientation pull request #30: CB-11917 - Remove pull r...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-battery-status pull request #40: CB-11917 - Remove pull reque...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine pull request #21: CB-11917 - Remove pull req...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cordova-plugin-whitelist pull request #23: CB-11917 - Remove pull request te...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-console pull request #20: CB-11917 - Remove pull request temp...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-test-framework pull request #21: CB-11917 - Remove pull reque...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-legacy-whitelist pull request #2: CB-11917 - Remove pull requ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-legacy-whitelist/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Nightly build #168 for cordova has failed

2016-10-04 Thread Apache Jenkins Server
Nightly build #168 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/168/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/168/consoleFull - Jenkins for Apache Cordova

[DRAFT] release blog post for create, app-hello-world and geolocation plugin.

2016-10-04 Thread Steven Gill
https://github.com/apache/cordova-docs/pull/647

[GitHub] cordova-docs pull request #647: added release blog post for geolocation, cre...

2016-10-04 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/647 added release blog post for geolocation, create and app-hello-world any feedback? You can merge this pull request into a Git repository by running: $ git pull https://github.com/steven

[GitHub] cordova-plugin-file-transfer issue #158: CB-11917 - Remove pull request temp...

2016-10-04 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/158 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[Discuss] cordova-common@1.5.0 release

2016-10-04 Thread Steven Gill
Going to merge in the edit-config pr [1] and start a release tomorrow. Any objections? [1] https://github.com/apache/cordova-lib/pull/492

[GitHub] cordova-plugin-file-transfer issue #158: CB-11917 - Remove pull request temp...

2016-10-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/158 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file pull request #197: CB-11947 fixed typo that occurs when ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file issue #197: CB-11947 fixed typo that occurs when adding ...

2016-10-04 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] cordova-plugin-file issue #197: CB-11947 fixed typo that occurs when adding ...

2016-10-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/197/commits/97913236aac42b1e19c765495552842a99b26489)

[GitHub] cordova-plugin-file pull request #197: CB-11947 fixed typo that occurs when ...

2016-10-04 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81866162 --- Diff: plugin.xml --- @@ -109,8 +109,10 @@ xmlns:android="http://schemas.android.com/apk/res/android";

[GitHub] cordova-plugin-file issue #197: CB-11947 fixed typo that occurs when adding ...

2016-10-04 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file pull request #197: CB-11947 fixed typo that occurs when ...

2016-10-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81862737 --- Diff: plugin.xml --- @@ -119,11 +121,7 @@ If this is an update to an existing application that did not specify an "Android "

[GitHub] cordova-plugin-file pull request #197: CB-11947 fixed typo that occurs when ...

2016-10-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81863003 --- Diff: plugin.xml --- @@ -109,8 +109,10 @@ xmlns:android="http://schemas.android.com/apk/res/android"; -

[GitHub] cordova-plugin-file pull request #197: CB-11947 fixed typo that occurs when ...

2016-10-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81862840 --- Diff: plugin.xml --- @@ -109,8 +109,10 @@ xmlns:android="http://schemas.android.com/apk/res/android"; -

[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file issue #197: CB-11947 fixed typo that occurs when adding ...

2016-10-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/197/commits/dd18b50900bdf05826c72314a8ffd831f8fc4599)

[GitHub] cordova-plugin-file pull request #197: CB-11947 fixed typo that occurs when ...

2016-10-04 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-file/pull/197 CB-11947 fixed typo that occurs when adding file-transfer plugin to android ### Platforms affected ### What does this PR do? CB-11947 fixed typo that occurs

[GitHub] cordova-docs pull request #644: CB-11916 - Drop requirement for an iCLA for ...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request #646: CB-11946 - Blog post for Node 0.x and 4.x de...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...

2016-10-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/141#discussion_r81827457 --- Diff: src/platform-release.js --- @@ -59,6 +59,36 @@ function cpAndLog(src, dest) { } } +/* + * A function that handl

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-04 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Thanks @dpogue, I'll do final tests and pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cordova-lib pull request #495: CB-8995 renamed start to plugman install/unin...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [Android] onPause and onResume in the background on WebViews

2016-10-04 Thread Joe Bowser
Yeah, I think we shouldn't break users. That said, I do think PauseOnBackground should be a new feature. I don't know if it'll land in 6.0 though, since I want to get the vote out this week. On Tue, Oct 4, 2016 at 10:40 AM, Shazron wrote: > We could like you said make a breaking change, but al

Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-10-04 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Shazron Abdullah Vladimir Kotikov The vote has passed. On Tue, Oct 4, 2016 at 12:43 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant

Re: [Android] onPause and onResume in the background on WebViews

2016-10-04 Thread Shazron
We could like you said make a breaking change, but allow a preference to be set. We either make the preference backwards compatible (ie KeepRunning = true) so existing apps still work the same on Cordova-Android 6, or break backwards compatibility with KeepRunning=false as default. I would prefer

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-04 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 @shazron Fixed an issue with the `rm` that was causing ENOENT on initial builds. Tests should pass now. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-lib pull request #495: CB-8995 renamed start to plugman install/unin...

2016-10-04 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/495 CB-8995 renamed start to plugman install/uninstall start to make Cord… CB-8995 renamed "start" to "plugman install/uninstall start" to make CordovaLib tests more descriptive You can merge t

[GitHub] cordova-docs issue #646: CB-11946 - Blog post for Node 0.x and 4.x deprecati...

2016-10-04 Thread sosahvictor
Github user sosahvictor commented on the issue: https://github.com/apache/cordova-docs/pull/646 Thanks for putting this together, @shazron. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-docs issue #646: CB-11946 - Blog post for Node 0.x and 4.x deprecati...

2016-10-04 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-docs/pull/646 +1 LGTM :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/17#discussion_r81724529 --- Diff: lib/PluginsManager.js --- @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () { in

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81722427 --- Diff: tests/hooks/after_prepare.js --- @@ -0,0 +1,71 @@ +#!/usr/bin/env node + +/* +* +* Licensed to the Apach

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81722419 --- Diff: tests/hooks/after_prepare.js --- @@ -0,0 +1,71 @@ +#!/usr/bin/env node + +/* +* +* Licensed to th

[GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...

2016-10-04 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/17#discussion_r81720400 --- Diff: lib/PluginsManager.js --- @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () { installed

[GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...

2016-10-04 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/17#discussion_r81718373 --- Diff: lib/PluginsManager.js --- @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () { installed

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81716605 --- Diff: tests/hooks/after_prepare.js --- @@ -0,0 +1,71 @@ +#!/usr/bin/env node + +/* +* +* Licensed to the Apach

[GitHub] cordova-cli issue #255: CLI Refactor

2016-10-04 Thread brutalcrozt
Github user brutalcrozt commented on the issue: https://github.com/apache/cordova-cli/pull/255 update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

RE: Nightly build #167 for cordova has failed

2016-10-04 Thread Vladimir Kotikov (Akvelon)
Voted! Actually, I was thinking about removing this ‘link & run tests’ step before publishing – I think we already run tests on Travis and AppVeyor so doing this also on Jenkins is a bit excessive Thoughts? - Best regards, Vladimir From: Shazron [mailto:shaz...@gmail.com] Sent: Tuesday, Octob

RE: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-10-04 Thread Vladimir Kotikov (Akvelon)
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create - Best regards, Vladimir -Original Message- From: Shazron [mailto:shaz...@gmail.co

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81698327 --- Diff: tests/hooks/after_prepare.js --- @@ -0,0 +1,71 @@ +#!/usr/bin/env node + +/* +* +* Licensed to th

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81697958 --- Diff: tests/hooks/after_prepare.js --- @@ -0,0 +1,71 @@ +#!/usr/bin/env node + +/* +* +* Licensed to th

[GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81697360 --- Diff: tests/hooks/after_prepare.js --- @@ -0,0 +1,71 @@ +#!/usr/bin/env node + +/* +* +* Licensed to th

Re: [Android] onPause and onResume in the background on WebViews

2016-10-04 Thread julio cesar sanchez
Yes, I think that will screw a lot of apps that keep running in the background. Maybe it should be a config.xml preference with default value not to pause it. But my real opinion about this issue is that I don't think the videos should be embedded into the app, people should use inAppBrowser to pl

[GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695543 --- Diff: lib/PluginsManager.js --- @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () { in

[GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...

2016-10-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695102 --- Diff: lib/PluginsManager.js --- @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () { in