Nightly build #183 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/183/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/183/consoleFull
-
Jenkins for Apache Cordova
Ship it!
@purplecabbage
risingj.com
On Wed, Oct 19, 2016 at 3:33 PM, Steven Gill wrote:
> Do it!
>
> On Tue, Oct 18, 2016 at 7:19 AM, Sergey Shakhnazarov (Akvelon) <
> v-ses...@microsoft.com> wrote:
>
> > Does anyone have any reason to delay a cordova-windows platform
Welcome, Sterling!
Ryan J. Salva | Principal PM Manager
Visual Studio Mobile Developer Tools
rsa...@microsoft.com
425 706 5270 office
206 612 5079 mobile
-Original Message-
From: Sterling Gerritz [mailto:sterling...@gmail.com]
Sent: Wednesday, October 19, 2016 4:09 PM
To:
Hello Fellow Developers!
My name is Sterling, I just wanted to take a moment to introduce myself.
I recently started as an intern on the Phone-Gap team at Adobe . If you
have any questions or concerns, please do not hesitate to reach out to me,
my email address is sterling...@gmail.com I am
Do it!
On Tue, Oct 18, 2016 at 7:19 AM, Sergey Shakhnazarov (Akvelon) <
v-ses...@microsoft.com> wrote:
> Does anyone have any reason to delay a cordova-windows platform release?
> Any outstanding patches to land?
>
> If not, I will start the release tomorrow.
>
> Best regards,
> Sergey
Does anyone have any reason to delay a tools release?
Any outstanding patches to land?
If not, I will start the release tomorrow.
The versions to be released are:
- lib@6.4.0
- cli@6.4.0
- plugman@1.4.0
- cordova-js@4.2.0
Issue: https://issues.apache.org/jira/browse/CB-12039
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-docs/pull/651
Thanks for the PR, merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/651
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
merged, thank you everyone and sorry that it took so long
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
BUMP!
OK, it seems that we've hit a few delays with pending releases and
cordova-common needing to be released, so based on this, I'll start the
long process of releasing this on Thursday if there's no objections.
On Mon, Oct 3, 2016 at 11:30 AM, Joe Bowser wrote:
> OK, I
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/504
Make sure to run `npm test` before re-submitting your changes. CI fail due
to jshint error.
`src/plugman/fetch.js: line 72, col 12, 'option' is not defined.`
---
If your project is set up
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/203
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
I think it's fine. The repo is low-impact, and if you rename on GH it
aliases it as well.
Also, there might be changes needed in Coho and the Docs.
On Tue, Oct 18, 2016 at 6:10 PM, Tobias Bocanegra wrote:
> Hi,
>
> with the sierra update, Apple renamed OS X to macOS. I don't
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193
Cordova CI Build has completed successfully.
**Commit** -
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/203#discussion_r84127530
--- Diff: spec/unit/ConfigChanges.spec.js ---
@@ -57,24 +57,28 @@ describe('PlatformMunger', function () {
it('should call
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-windows/pull/203
@daserge, thank you for your comments. I've returned back to specs with a
few modifications and refactored some parts of code.
@daserge @vladimir-kotikov, can you review
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Jira issue https://issues.apache.org/jira/browse/CB-12036 set as Minor.
But, please, don't delay because the missing feature. The issue is beyond
that, the code is wrong because
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/203#discussion_r84070152
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -34,54 +39,121 @@ util.inherits(PlatformMunger, CommonMunger);
* need to be removed or
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/203#discussion_r84070095
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -34,54 +39,121 @@ util.inherits(PlatformMunger, CommonMunger);
* need to be removed or
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/203#discussion_r84077075
--- Diff: spec/unit/ConfigChanges.spec.js ---
@@ -57,76 +57,98 @@ describe('PlatformMunger', function () {
it('should call
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/203#discussion_r84069176
--- Diff: spec/unit/ConfigChanges.spec.js ---
@@ -57,76 +57,98 @@ describe('PlatformMunger', function () {
it('should call
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/203
@daserge, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user herrevilkitten commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
Thanks you @sfrank87 for the help with this :)
The duplicate methods are probably from some wacky merge conflict
resolution I had going on.
---
If your project is
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/203
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/203?src=pr) is
74.66% (diff: 93.47%)
> Merging
Github user DigitalSkyline commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
I added this to my project much appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/203
CB-11933: Add uap prefixes for capabilities from
package.windows10.appxmanifest when installing plugin
### What does this PR do?
Windows has a special logic for
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193
CB-10973 inAppBrowser for Windows Platform: wrong height of webview wâ¦
â¦ith location=yes
### Platforms affected
Windows
### What does this PR
Github user sfrank87 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
@jcesarmobile
[done](https://github.com/herrevilkitten/cordova-plugin-inappbrowser/pull/1).
regards
Frank
---
If your project is set up for it, you can
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
@sfrank87 can you send a PR to @herrevilkitten repo against
CB-8467_provide_hide_method_to_hide_browser_window branch removing the
duplicate method and adding the test?
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/196
![no-splashscreen-node-win10](https://cloud.githubusercontent.com/assets/4272078/19512546/28600e3c-95f5-11e6-9f52-9ba207a42639.png)
---
If your project is set up for it, you can reply to
Github user sfrank87 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
Btw, I have written a little test case for the hide method, that can be
found [here](https://github.com/sfrank87/IABTests).
@herrevilkitten just copy the tests.js into
Github user daserge commented on the issue:
https://github.com/apache/cordova-windows/pull/196
@giuseppelt thanks for the contribution - the logic fix is valid, I was not
disputing this.
This requires additional changes though because the [current windows
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/196
@giuseppelt, is there a JIRA issue about this? It would be nice if you
could create one with explanation of your usecase and attach it to this PR by
specifying JIRA item title at
Github user sfrank87 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101
Hi.
Thank you very much for your effort. :)
I found an misstake in
Github user nerdmed commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@shazron @manucorporat any progress here? Would be great to see this PR
getting merged!
---
If your project is set up for it, you can reply to this email and have your
reply
39 matches
Mail list logo