[GitHub] cordova-plugin-geolocation issue #57: Fix crash on deny permission request o...

2016-10-20 Thread gkrizek
Github user gkrizek commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/57 If this is needed, I have the `logcat` output from when it dies. I don't have a physical device to test this on, only an emulator. @xiaoerge or @iursevla, do you guys have a

Nightly build #184 for cordova has succeeded!

2016-10-20 Thread Apache Jenkins Server
Nightly build #184 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/184/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-geolocation issue #57: Fix crash on deny permission request o...

2016-10-20 Thread xiaoerge
Github user xiaoerge commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/57 I am experiencing the same issue as @gkrizek and @iursevla . When I click allow permission on android 6 in the emulator, it crashed the emulator. --- If your project is set

Re: [DISCUSS] Tools release!

2016-10-20 Thread Steven Gill
I'm going to preemptively update platformsConfig.json to use the new versions of android, ios and windows which are being released. I will send out the vote sooon and we can aim to release everything at once. On Thu, Oct 20, 2016 at 3:39 PM, julio cesar sanchez

Re: [DISCUSS] Cordova-Windows Release

2016-10-20 Thread Steven Gill
What version? 4.5.0? On Wed, Oct 19, 2016 at 4:46 PM, Jesse wrote: > Ship it! > > > @purplecabbage > risingj.com > > On Wed, Oct 19, 2016 at 3:33 PM, Steven Gill > wrote: > > > Do it! > > > > On Tue, Oct 18, 2016 at 7:19 AM, Sergey Shakhnazarov

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread sterlingann
Github user sterlingann closed the pull request at: https://github.com/apache/cordova-lib/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] cordova-ios 4.3.0 release

2016-10-20 Thread Steven Gill
The problem is that iOS requires an updated tools. Chicken and egg! Maybe we release everything at once? On Thu, Oct 20, 2016 at 3:37 PM, julio cesar sanchez wrote: > +1 > > As there is a tools release planed and android release too, shouldn't we > release ios and

Re: [DISCUSS] Tools release!

2016-10-20 Thread julio cesar sanchez
As ios and android releases are on vote stage, shouldn't we release them first and then do the tools release with that platforms pinned? 2016-10-20 0:33 GMT+02:00 Steven Gill : > Does anyone have any reason to delay a tools release? > Any outstanding patches to land? > >

Re: [DISCUSS] cordova-ios 4.3.0 release

2016-10-20 Thread julio cesar sanchez
+1 As there is a tools release planed and android release too, shouldn't we release ios and android first and then tools with this platforms? 2016-10-20 22:38 GMT+02:00 Shazron : > Chock full of new features: > - CocoaPods (static libs only) support as > - Xcode 8 / iOS 10

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-10-20 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/504 This PR can be closed now! It was merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Intro - Sterling Gerritz

2016-10-20 Thread Michael Brooks
Welcome to the team and project, Sterling! On Wed, Oct 19, 2016 at 4:15 PM, Ryan J. Salva wrote: > Welcome, Sterling! > > > > Ryan J. Salva | Principal PM Manager > Visual Studio Mobile Developer Tools > rsa...@microsoft.com > 425 706 5270 office > 206 612 5079 mobile >

[DISCUSS] cordova-ios 4.3.0 release

2016-10-20 Thread Shazron
Chock full of new features: - CocoaPods (static libs only) support as - Xcode 8 / iOS 10 support - buildFlag support on the command line - iPad storyboard support - others that I may have forgot All the outstanding PRs and (according to me) issues that can get fixed are in. Let me know if

Re: [Vote] 6.0.0 Android Release

2016-10-20 Thread Steven Gill
Just to amend this email Corresponding git tag: cordova-android: 6.0.0 (355aae7b4b) Issue: https://issues.apache.org/jira/browse/CB-12038 Dist: https://dist.apache.org/repos/dist/dev/cordova/CB-12038 On Thu, Oct 20, 2016 at 1:29 PM, Joe Bowser wrote: > Please review and

[Vote] 6.0.0 Android Release

2016-10-20 Thread Joe Bowser
Please review and vote on this 6.0.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB- The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB- The package

[GitHub] cordova-windows pull request #205: CB-12044 Fix splashscreen image path for ...

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread sterlingann
Github user sterlingann commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r84335445 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) { if

[GitHub] cordova-windows issue #205: CB-12044 Fix splashscreen image path for ms-appx...

2016-10-20 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/205 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/205?src=pr) is 74.64% (diff: 100%) > Merging

[GitHub] cordova-windows pull request #205: CB-12044 Fix splashscreen image path for ...

2016-10-20 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/205 CB-12044 Fix splashscreen image path for ms-appx on Windows ### Platforms affected Windows ### What does this PR do? 1. Fix splashscreen image path for ms-appx on

[GitHub] cordova-windows pull request #204: CB-12042 Copy base.js to www directory in...

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows issue #204: CB-12042 Copy base.js to www directory in 'creat...

2016-10-20 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/204 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/204?src=pr) is 74.64% (diff: 100%) > Merging

[GitHub] cordova-windows pull request #204: CB-12042 Copy base.js to www directory at...

2016-10-20 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/204 CB-12042 Copy base.js to www directory at create ### What does this PR do? Fixes missing `base.js` in `www` folder when project is created without Cordova CLI

[GitHub] cordova-windows pull request #157: TypeScript Error

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #203: CB-11933: Add uap prefixes for capabiliti...

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #203: CB-11933: Add uap prefixes for capabiliti...

2016-10-20 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/203#discussion_r84247927 --- Diff: spec/unit/ConfigChanges.spec.js --- @@ -57,24 +57,28 @@ describe('PlatformMunger', function () { it('should call

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r84220720 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) { if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r84220511 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) { if