Nightly build #225 for cordova has failed

2016-11-12 Thread Apache Jenkins Server
Nightly build #225 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/225/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/225/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-12 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 Oh I see now, sorry I misunderstood. I can definitely make that change --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-12 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 I didn't meant to reuse the existing hide, but make the old hide just call the new browserHide as browserHide has the exact same code ```- (void)hide:(CDVInvokedUrlC

[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI

2016-11-12 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/185 I have been using this pr as well and it works well, makes the toolbar have a much more native look and feel. This definitely seems like a no brainier to merge in --- If your

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-12 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 The new methods follow what is implemented for close, where there are 2 close methods, one designed for the user to call and one for use with a selector that the done button wil

[GitHub] cordova-android pull request #335: older android fix (v2.3.6)

2016-11-12 Thread coderofsalvation
Github user coderofsalvation closed the pull request at: https://github.com/apache/cordova-android/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android issue #335: older android fix (v2.3.6)

2016-11-12 Thread coderofsalvation
Github user coderofsalvation commented on the issue: https://github.com/apache/cordova-android/pull/335 ok we could just close this PR, at least the case is documented for and accessible by google. --- If your project is set up for it, you can reply to this email and have your reply