[GitHub] cordova-ios pull request #276: CB-12130 - Launch storyboard images are not u...

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...

2016-11-15 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/276 Pulled in; thanks for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

Nightly build #228 for cordova has succeeded!

2016-11-15 Thread Apache Jenkins Server
Nightly build #228 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/228/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-ios pull request #277: CB-11243: Fix target-device and deployment-ta...

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [CI STATUS REPORT] - 19 actual failures, 3 known failures

2016-11-15 Thread Shazron
The plugin failures all are green now, thanks CI sentinels On Mon, Nov 14, 2016 at 8:20 AM, Shazron wrote: > http://status.cordova.io > > > # ACTUAL FAILURES > > 1. Parts of all 19 plugins are failing (seems to be temp file issues: > FATAL: Unable to produce a script file > java.io.IOException:

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

2016-11-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Hey @romedius, A docs pr would be great! I would suggest adding it as a normal option and maybe adding a quirks section for windows saying that it doesn't support the optio

[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...

2016-11-15 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/276 Awesome; thanks! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...

2016-11-15 Thread NielsLeenheer
Github user NielsLeenheer commented on the issue: https://github.com/apache/cordova-ios/pull/276 Squashed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...

2016-11-15 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/276 @NielsLeenheer -- would you mind squashing these commits down to a single commit? I'd like to pull this in. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-plugin-file-transfer issue #168: patch method

2016-11-15 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/168 Cordova CI Build has one or more failures. Link: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/44/ 260 tests run, 24 skipped, 34 failed.

[GitHub] cordova-plugin-file-transfer pull request #168: patch method

2016-11-15 Thread theromis
GitHub user theromis opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/168 patch method We using Django Rest Framework, and there sending partial updates as a PATCH method a standard. So PATCH *SHOULD* be at list an option for this module. You can m

[GitHub] cordova-ios pull request #278: CB-11243 - Added failing tests

2016-11-15 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-ios issue #278: CB-11243 - Added failing tests

2016-11-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/278 Closing. Is now part of #277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 Ah yes, thanks for catching that! The unit test should be adequate. I'll get this pulled in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...

2016-11-15 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 It looks like the tests were failing because of the spy on writeFileSync. I've added a fix and pulled them into this PR. I also tried to add a test to verify the final .app is correct, but I c

[GitHub] cordova-plugin-splashscreen issue #118: CB-11751 'extendedSplashScreen' is u...

2016-11-15 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/118 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/118/commits/dee9a3bdc63059dd4a5bd4d17a4

[GitHub] cordova-windows issue #211: CB-11751 'extendedSplashScreen' is undefined

2016-11-15 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/211 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/211?src=pr) is 74.64% (diff: 100%) > Merging [#211](https://codecov.io/gh/apache/cordova-windows/pull/211?src=

[GitHub] cordova-plugin-splashscreen pull request #118: CB-11751 'extendedSplashScree...

2016-11-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/118 CB-11751 'extendedSplashScreen' is undefined ### Platforms affected ### What does this PR do? [Jira issue](https://issues.apache.org/jira/browse/CB-11

[GitHub] cordova-windows pull request #211: CB-11751 'extendedSplashScreen' is undefi...

2016-11-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/211 CB-11751 'extendedSplashScreen' is undefined ### What does this PR do? [Jira issue](https://issues.apache.org/jira/browse/CB-11751) Replaced element implicit calls by id to

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

2016-11-15 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 I would like to change the documentation. Now that Android and iOS are supporting this flag, should it still be listed as a quirk? --- If your project is set up for it, you can re