[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/144 Looks good to me! :shipit: I wonder why didn't I use getting elements by accessibility id right from the start... --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92756760 --- Diff: cordova-lib/spec-cordova/helpers.js --- @@ -148,7 +148,7 @@ module.exports.writeConfigContent = function (appPath, configContent) {

Re: [VOTE] Plugins Release (Dec 12th 2016)

I vote +1: - successfully created android and ios projects with the plugins - ran through the manual tests for both plugins on Android 5.1 and iOS 9.3 emusims. On Thu, Dec 15, 2016 at 2:13 AM, wrote: > I vote +1 > > * Verified signatures and hashes > * Verified tags > *

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/144 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/144 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-statusbar pull request #73: CB-12141 (ios) fix white app scre...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request #72: Update plugin.xml

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar issue #73: CB-12141 (ios) fix white app screen afte...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/73 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/144 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-statusbar pull request #73: CB-12141 (ios) fix white app scre...

GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/73 CB-12141 (ios) fix white app screen after camera overlay shown on iPad ### Platforms affected iOS ### What does this PR do? fix white app screen

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92713582 --- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js --- @@ -472,7 +472,7 @@ describe('HooksRunner', function() {

[GitHub] cordova-plugin-contacts issue #144: [Appium] Add support for iOS' XCUITest a...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/144 Cordova CI Build has one or more failures. **Commit** -

Re: [DISCUSS] Schedule to drop iOS 8 support in cordova-ios@5.x

This removal of iOS 8 support will be for cordova-ios@4.4.0 (in the new year) and not cordova-ios@5.0.0 -- to coincide with the node 0.x removal as well. I'm not sure this is a "breaking" change. On Sat, Nov 5, 2016 at 7:15 AM, Simon MacDonald wrote: > +1 > I've

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92707789 --- Diff: cordova-lib/package.json --- @@ -20,15 +20,16 @@ "dependencies": { "aliasify": "^1.7.2", "cordova-common": "1.5.x",

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92707699 --- Diff: cordova-common/package.json --- @@ -28,6 +28,7 @@ "cordova-registry-mapper": "^1.1.8", "elementtree": "^0.1.6",

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92707427 --- Diff: cordova-lib/spec-cordova/build.spec.js --- @@ -67,7 +67,7 @@ describe('build command', function() { describe('success', function() {

[GitHub] cordova-plugin-contacts pull request #144: [Appium] Add support for iOS' XCU...

GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/144 [Appium] Add support for iOS' XCUITest automation library Please review @alsorokin ! ### Platforms affected iOS. ### What does this PR do? When

Re: [DISCUSS] Plugins Release Dec 12th, 2016

Ping pong. Need one more vote to wrap this up tomorrow before the weekend :D On Wed, Dec 14, 2016 at 1:21 PM, Filip Maj wrote: > +1 > > On Wed, Dec 14, 2016 at 12:19 PM, julio cesar sanchez > wrote: > > +1 > > > > 2016-12-14 20:01 GMT+01:00 Shazron

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 @jcesarmobile, @infil00p, @kerrishotts could you please also take a look if you have a chance? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-inappbrowser issue #125: CB-9445 Improves executeScript callb...

Github user yggi49 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/125 @wanjochan @bash88 @mathiasmuller4sh I had the same problem, and after some research I finally found one possible culprit: If the site within the inAppBrowser is served via HTTPS

Re: (CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number

Thanks all! I’ve closed the issue. ~ Kerri > On Dec 15, 2016, at 01:02, Jesse wrote: > > I am replying on the issue in JIRA, because there is no way to know if the > issue creator is on the dev list, and these replies don't seem to make it > back. > > > >

[GitHub] cordova-windows pull request #218: CB-12238 [Windows] Colorize titlebar to m...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/218#discussion_r92604767 --- Diff: cordova-js-src/splashscreen.js --- @@ -203,10 +212,30 @@ function enableUserInteraction() {

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92601539 --- Diff: cordova-js-src/splashscreen.js --- @@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ? 'ms-appx-web' :

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92603101 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest) {

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92602532 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest) {

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92601889 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest) {

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 @nbabanov thanks for the contribution and sorry it took so long to review this. Could you please describe your scenario - I could not reproduce the issue with latest

RE: [VOTE] Plugins Release (Dec 12th 2016)

I vote +1 * Verified signatures and hashes * Verified tags * Verified that plugins can be added correctly to blank app * Verified that blank app can be successfully built and ran (windows, ios and android) * Verified that browserified app can be successfully built and ran (windows, ios and