I vote +1
* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran (windows, ios and
android)
* Verified that browserified app can be successfully built and ran (windows,
ios and andro
Github user daserge commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/109
@nbabanov thanks for the contribution and sorry it took so long to review
this.
Could you please describe your scenario - I could not reproduce the issue
with latest cor
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92601889
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
extendedSplashProgress.classLis
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92602532
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
extendedSplashProgress.classLis
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92603101
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
extendedSplashProgress.classLis
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92601539
--- Diff: cordova-js-src/splashscreen.js ---
@@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ?
'ms-appx-web' : 'ms-ap
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/218#discussion_r92604767
--- Diff: cordova-js-src/splashscreen.js ---
@@ -203,10 +212,30 @@ function enableUserInteraction() {
document.body.style['-ms-conte
Thanks all! I’ve closed the issue.
~ Kerri
> On Dec 15, 2016, at 01:02, Jesse wrote:
>
> I am replying on the issue in JIRA, because there is no way to know if the
> issue creator is on the dev list, and these replies don't seem to make it
> back.
>
>
>
> @purplecabbage
> risingj.com
>
> On
Github user yggi49 commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/125
@wanjochan @bash88 @mathiasmuller4sh I had the same problem, and after some
research I finally found one possible culprit: If the site within the
inAppBrowser is served via HTTPS
Github user daserge commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/109
@jcesarmobile, @infil00p, @kerrishotts could you please also take a look if
you have a chance?
---
If your project is set up for it, you can reply to this email and have your
re
Ping pong. Need one more vote to wrap this up tomorrow before the weekend :D
On Wed, Dec 14, 2016 at 1:21 PM, Filip Maj wrote:
> +1
>
> On Wed, Dec 14, 2016 at 12:19 PM, julio cesar sanchez
> wrote:
> > +1
> >
> > 2016-12-14 20:01 GMT+01:00 Shazron :
> >
> >> Two plugins that were omitted from
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/144
[Appium] Add support for iOS' XCUITest automation library
Please review @alsorokin !
### Platforms affected
iOS.
### What does this PR do?
When run
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707427
--- Diff: cordova-lib/spec-cordova/build.spec.js ---
@@ -67,7 +67,7 @@ describe('build command', function() {
describe('success', function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707699
--- Diff: cordova-common/package.json ---
@@ -28,6 +28,7 @@
"cordova-registry-mapper": "^1.1.8",
"elementtree": "^0.1.6",
"g
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707789
--- Diff: cordova-lib/package.json ---
@@ -20,15 +20,16 @@
"dependencies": {
"aliasify": "^1.7.2",
"cordova-common": "1.5.x",
This removal of iOS 8 support will be for cordova-ios@4.4.0 (in the new
year) and not cordova-ios@5.0.0 -- to coincide with the node 0.x removal as
well.
I'm not sure this is a "breaking" change.
On Sat, Nov 5, 2016 at 7:15 AM, Simon MacDonald
wrote:
> +1
> I've created an issue on the push plu
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/144
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/2de7bfea3fc49774b1472f7a2af9af0cbc3a
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92713582
--- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js ---
@@ -472,7 +472,7 @@ describe('HooksRunner', function() {
hookOptions.no
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/73
CB-12141 (ios) fix white app screen after camera overlay shown on iPad
### Platforms affected
iOS
### What does this PR do?
fix white app screen after
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/144
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/35876c1f65add9872e26c7e6927d37230a53
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/73
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/73/commits/579a5a692b718a4bcabb255d9e4a7b59b33
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/144
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/5f1069a1b53ceae109084381ceebefcbe09
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/144
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/144/commits/58d4612f90682453fa59329892440738c73
I vote +1:
- successfully created android and ios projects with the plugins
- ran through the manual tests for both plugins on Android 5.1 and
iOS 9.3 emusims.
On Thu, Dec 15, 2016 at 2:13 AM, wrote:
> I vote +1
>
> * Verified signatures and hashes
> * Verified tags
> * Verified that plugins c
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92756760
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -148,7 +148,7 @@ module.exports.writeConfigContent = function (appPath,
configContent) {
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/144
Looks good to me! :shipit:
I wonder why didn't I use getting elements by accessibility id right from
the start...
---
If your project is set up for it, you can reply to this
28 matches
Mail list logo