Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Please review and vote on this Tools Release by replying to this email (and
keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-12289
The release has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-12289/. It has also been
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/116
This is a really trivial fix could it please get merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
+1 do what you need to, I'll try to make time to review and vote.
> On Dec 21, 2016, at 2:39 PM, Tim Barham wrote:
>
> I'd like to do a cordova-serve 1.0.1 release that just cherry picks a single
> commit
> (https://github.com/apache/cordova-lib/commit/84fa8e39b22252381ed4baa6868ff6f22b7a48e2
I'd like to do a cordova-serve 1.0.1 release that just cherry picks a single
commit
(https://github.com/apache/cordova-lib/commit/84fa8e39b22252381ed4baa6868ff6f22b7a48e2).
Anyone have any concerns with that?
(the reasoning behind just taking that single commit is that we'd like to take
that f
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nerdmed commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/187
@shazron @manucorporat, i know its christmas time but guys lets forward.
This i hanging around long enough and people are working with forks to run in
production, this really aff
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93506823
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93502548
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93493946
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490653
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function ()
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492375
--- Diff: cordova-lib/spec-plugman/platforms/wp8.spec.js ---
@@ -113,22 +113,21 @@ describe('wp8 project handler', function() {
fs
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492132
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function ()
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490510
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function ()
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490083
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function() {
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93491307
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function ()
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93491264
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function ()
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492030
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function ()
Github user regnete commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262953
My fault. Sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user naveedahmed1 commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
Can this be merged? So that it can be used on Android 6 or higher.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262925
Well, that issue was created before this was merged, so this couldn't cause
that issue.
But will use th
Github user regnete commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262881
@jcesarmobile: Thnak you for the quick reply. I added a comment to
https://issues.apache.org/jira/browse/CB-1219
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262818
@regnete can you create a new issue on http://issues.cordova.io?
---
If your project is set up for it, you
Github user regnete commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/commit/a120ba1a1ffb27d46f2ac7962648e6f8a7a5b24c#commitcomment-20262561
This change is not compatible with cordova-plugin-statusbar:
Invoking StatusBar.hide() after 'deviceready' e
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/219#discussion_r93464493
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -304,6 +309,47 @@ describe('windows project handler', function () {
xpat
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/219#discussion_r93460566
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -115,6 +115,33 @@ function PluginInfo(dirname) {
var configFiles = parentGetConfigFil
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/219
@daserge could you take a look please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/9
Probably a good idea :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
+1
We’re specifically interested in these three PRs:
- https://github.com/apache/cordova-lib/pull/505
- https://github.com/apache/cordova-lib/pull/509
- https://github.com/apache/cordova-lib/pull/513
Notice that the first one contains a change that might break plugins that use
to
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/219
Documentation update: https://github.com/apache/cordova-docs/pull/671
Change to support `implementation` attribute in `cordova-common`:
https://github.com/apache/cordova-lib/pull
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/219
## [Current
coverage](https://codecov.io/gh/apache/cordova-windows/pull/219?src=pr) is
77.00% (diff: 100%)
> Merging
[#219](https://codecov.io/gh/apache/cordova-windows/pull/219?src=
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/219
Add support for WinMD and DLL combination
### Platforms affected
self
### What does this PR do?
This PR adds support for .winmd and .dll combination.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/513
Travis build failures look irrelevant to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-docs/pull/671
CB-12189 windows: Document `implementation` attribute
### Platforms affected
### What does this PR do?
### What testing has been done on this chan
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/9
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/9/commits/cd2ee4666d66190424d
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/9
CB-12286 Tests reworked
### Platforms affected
All
### What does this PR do?
https://issues.apache.org/jira/browse/CB-12286
Tests now actuall
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/513
CB-12189 windows: Add `implementation` attribute to frameworks
The attribute is windows-specific and allows to specify implementation for
WinMD components, written in C++
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/8
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/8/commits/7fdc334a2f743d061937
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/8
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/8/commits/4ab51641c26af31a08eb
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/8
CB-12285 Polyfill promises on platforms that doesn't support them natâ¦
â¦ively
### Platforms affected
All platforms with webview that doesn't supp
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/7
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/7/commits/ba26294f664e637dd5f7
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/7
test Jenkins PR job
do not merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-screen-orien
44 matches
Mail list logo
