Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Simon MacDonald
I would be happy to see Splash Screen go back to the platforms as well. Simon Mac Donald http://simonmacdonald.com On Tue, Jan 24, 2017 at 10:56 PM, Joe Bowser wrote: > OK, time to address the elephant in the room: > > Why is the Splashscreen still a plugin? It was only

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Joe Bowser
OK, time to address the elephant in the room: Why is the Splashscreen still a plugin? It was only made a plugin because someone wanted to be a purist about plugins, and there's actually no good reason for it to not just be built into Cordova. I used to think Splashscreens were dumb and were

Re: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread Jesse
I would like to see us move towards making this platform level functionality, The requirements of this API happen mostly outside of the scope of a plugin's lifetime. If we could get to an api that was just, images with the right names are presented when the OS decides to do it, the way all

[GitHub] cordova-ios pull request #286: CB-12287: Remove hardcoded simulator build de...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/353 Also, I don't have confidence in the onRestart event on Android not being fired on the first start. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2017-01-24 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/353 This is a major API change and as such would require a version bump. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #286: CB-12287: Remove hardcoded simulator build destinati...

2017-01-24 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/286 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-cli issue #266: CB-12008 : made autosave the default for platform an...

2017-01-24 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-cli/pull/266 The proposal has been updated. https://github.com/audreyso/cordova-discuss/commit/1daa86c0dfa4760f5130f4e587ba787a72fe15f9 Autosave will only be used in the cli right now (not

[GitHub] cordova-cli pull request #266: CB-12008 : made autosave the default for plat...

2017-01-24 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/266 CB-12008 : made autosave the default for platform and plugin add/rm and included jasmine tests CB-12008 : made autosave the default for platform and plugin add/rm and included jasmine tests

[GitHub] cordova-lib issue #516: CB-12385: (win32/linux/darwin) auto open devtools in...

2017-01-24 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/516 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/516?src=pr) is 80.60% (diff: 100%) > Merging [#516](https://codecov.io/gh/apache/cordova-lib/pull/516?src=pr) into

[GitHub] cordova-lib pull request #516: CB-12385: (win32/linux/darwin) auto open devt...

2017-01-24 Thread botcheddevil
GitHub user botcheddevil opened a pull request: https://github.com/apache/cordova-lib/pull/516 CB-12385: (win32/linux/darwin) auto open devtools in chrome for cordova-serve ### Platforms affected linux, win32, darwin ### What does this PR do?

RE: Platform Version support/coverage

2017-01-24 Thread Alexander Sorokin (Akvelon)
Per-PR Jobs run time should increase by ~5 minutes, periodic job run time is expected to increase by ~1.5 hours. -Original Message- From: Filip Maj [mailto:maj@gmail.com] Sent: Sunday, January 22, 2017 3:58 AM To: dev@cordova.apache.org Subject: Re: Platform Version support/coverage

[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...

2017-01-24 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/515 CB-12383 Fix cordova_plugins metadata definition Define parent object first [Jira issue](https://issues.apache.org/jira/browse/CB-12383) ### Platforms affected Tested

[GitHub] cordova-plugin-statusbar pull request #:

2017-01-24 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/fa57e92c5582d0edc7fc4b1f4be7f5e3380d93cf#commitcomment-2054 `statusBarOverlaysWebView` has never affected InAppBrowser plugin or any other plugin, it only applies to

[GitHub] cordova-plugin-statusbar pull request #:

2017-01-24 Thread kelvindart
Github user kelvindart commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/fa57e92c5582d0edc7fc4b1f4be7f5e3380d93cf#commitcomment-20588848 Hi @jcesarmobile - I have a feeling this change conflicts with the InAppBrowser plugin (or other plugins

[GitHub] cordova-plugin-media-capture issue #38: Various Fixes to crashes in Windows ...

2017-01-24 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/38 Cordova CI Build has completed successfully. **Commit** -