Nightly build #266 for cordova has failed

Nightly build #266 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/266/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/266/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103127274 --- Diff: src/android/StatusBar.java --- @@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String colorPref) {

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103126865 --- Diff: src/android/StatusBar.java --- @@ -142,6 +142,23 @@ public void run() { return true; } +

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

Github user macdonst commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103126947 --- Diff: src/android/StatusBar.java --- @@ -142,6 +142,23 @@ public void run() { return true; } +

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 All the tests has passed after updating the latest codes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

Github user coryjthompson commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Great suggestion @jcesarmobile. I've moved PluginResult into the completion block as suggested. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 I think the PR is ok and I don't think that we need the weakSelf in this case. In fact, I think we are overusing it in most cases, we should only use it when we might have a

Re: [Android] Let's drop support for Jellybean

I don't think it is unreasonable to drop support for an OS that had its first release in July of 2012 (4.1 is almost 5 years old), especially considering the Cordova support policy for iOS. Realistically, I think it's hard to justify support for before 4.4. Less than 10% of our customers are on

[GitHub] cordova-plugin-statusbar issue #77: CB-10879: (android) Enable overlaysWebVi...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/77 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-statusbar pull request #77: CB-10879: (android) Enable overla...

GitHub user Lazza opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/77 CB-10879: (android) Enable overlaysWebView on Android API 21+ ### Platforms affected Android (API 21+). ### What does this PR do? This patch enables devices

Re: [Android] Let's drop support for Jellybean

I would happily drop support for anything less than API level 19 in the next cordova-android major release. Simon Mac Donald http://simonmacdonald.com On Sun, Feb 26, 2017 at 10:56 AM, Filip Maj wrote: > As much as I personally would like to do so, I wonder what the >

Re: [Android] Let's drop support for Jellybean

As much as I personally would like to do so, I wonder what the reaction among consumers of cordova would be. On Sun, Feb 26, 2017 at 1:39 AM, Jesse wrote: > +1 > Our CI tests only test as far back as 4.4, so maybe I thought we were > already there. > > > > > >

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 I haven't tested this yet, just found the PR while looking through various forks. I plan to test to mAke sure this is consistent with iOS and then will update here with