[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-06-08 Thread uloco
Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 You should also keep the last line if it's empty in both, `package.json` and `config.xml`. The [POSIX standard](http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_2

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-06-08 Thread uloco
Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 @stevengill Go for it. I don't have an account there... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[DISCUSS] transitioning from jshint to eslint

2017-06-08 Thread Audrey So
Hi all! We are thinking about transitioning from jshint to eslint and are wondering what are your thoughts about this? Here is a proposal that goes into detail if you are interested in knowing more! —> https://github.com/cordova/cordova-discuss/pull/71. Please share any comments, questions, con

Nightly build #369 for cordova has failed

2017-06-08 Thread Apache Jenkins Server
Nightly build #369 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/369/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/369/consoleFull - Jenkins for Apache Cordova

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-06-08 Thread Filip Maj
Great job, awesome to see progress on this. 6 plugins to sunset, 5 to integrate! Huge progress. On Thu, Jun 8, 2017 at 7:09 PM, Shazron wrote: > Deadline has passed for: > https://issues.apache.org/jira/browse/CB-12708 > > I believe I captured consensus in the issues as best I could. If there was

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-06-08 Thread Shazron
Deadline has passed for: https://issues.apache.org/jira/browse/CB-12708 I believe I captured consensus in the issues as best I could. If there was no consensus, the status quo prevails (KEEP). On Tue, May 30, 2017 at 12:58 PM, Shazron wrote: > Good point, I can imagine that after June 5 they wi

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

2017-06-08 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 From what I have read, it seems this is an Android problem -- so I'm not sure why the code changes in iOS are needed? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-inappbrowser pull request #99: inAppBrowser custom applicatio...

2017-06-08 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r121013734 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *) toolbarPosition -

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

2017-06-08 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Attn: @shazron @infil00p --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

2017-06-08 Thread benbotto
Github user benbotto commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 Any plan on accepting this pull request? This issue is more than two years old now, and there's still an inconsistency between iOS and Android that needs to be worked around.

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-06-08 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 @uloco want to add your comment to this issue: https://issues.apache.org/jira/browse/CB-12810 --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Cordova 7 Issue with android 7

2017-06-08 Thread Steven Gill
Hey Joseph, This mailing list is used for discussing the development of cordova itself. For asking help about using cordova, you should try cordova slack ( slack.cordova.io) or stackoverflow. Quick answer though, cordova-android versions are different than android operating system versions. Using

Cordova 7 Issue with android 7

2017-06-08 Thread joseph chavarria
Hi, I am Joseph from Costa Rica I am a developer on apache cordova. Last week one of my clients called me because the app no working more after they updated the cellphones to Android 7, I was looking on Internet but there is not information about it. I updated apache cordova to its lastest versi

[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

2017-06-08 Thread stalniy
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/79 @shazron could you please provide a feedback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/afff6b2c99ed6d4d9c7168

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-06-08 Thread uloco
Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 When adding platforms or plugins, you also perform a config.xml rewrite. Will this merge affect config.xml indentation rewrites, too? I do use 2 space indentation everywhere. It would be nice if y

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/a2049be5f9d24ac27bf9aa