Nightly build #426 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/426/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/426/consoleFull
-
Jenkins for Apache Cordova
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r126843121
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r126842836
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path =
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r126844076
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path =
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/130
Localized documentation is not editable.
Please see https://github.com/cordova/cordova-discuss/wiki/Translations
for more details.
Thank you for your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/144
good call!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/168
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PATCH
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
Thoughts here @infil00p ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
@feidianbo Can you provide an example url that would have failed and now
will pass, short of writing the whole test.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/182
Yes this is an important change.
I'm wondering how we can set up testing for these kinds of issues. Perhaps
that's a wider question about how to test the browser
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-windows/pull/236
CB -12895 : updated files to use eslint instead jshint
### Platforms affected
### What does this PR do?
Updated files to use eslint instead jshint
###
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Sure! No problem.
First you'd need to clone the repository down to your machine, giving you a
local copy to work with. You already have your own fork of the repository
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Yeah, I totally get that.
Can you actually post the `git` commands you would use? Then I can use this
as my googling starting point. Wanted to learn that for quite some
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Hah! I haven't used GitHub UI to do this kinda stuff before, so I can only
tell you how to do it via the `git` command line tool.
By "rebase," I meant ensuring that the
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Given how old this branch is, those are the same tests that master
was running until three commits ago.
---
If your project is set up for it, you can reply to this email and have
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Sure!
Well, if you tell me roughly how to do that. Some pointers would be nice,
never have done something like that. Can I actually do that on Github?
---
If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Maybe? I don't know. Just beware that you have very few tests running in
this PR (basically just the JS unit tests, no JS e2e nor Java native unit
tests) so the green checkmark next to your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj So, I should do another merge commit just to get more tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Right and that is now 3 commits behind master's `HEAD` :P
Just saying latest master stuff will get you better testing / feedback via
CI in this PR!
---
If your project is set up
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
The merge commit that I did was e456175a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/66
@wardenlzr what is the purpose of this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Just based on the last travis/appveyor run in the commits in this PR, the
unit tests, end to end tests and the native unit tests are not running.
I don't see master HEAD in the
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Github says otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/394
This also sped up CI runtimes:
- AppVeyor: ~9 mins to ~4 mins
- Travis: ~12 mins to ~8 mins
---
If your project is set up for it, you can reply to this email and have your
reply
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/394
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr=h1)
Report
> Merging
[#394](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr=desc)
into
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/394
It seems like removing the create e2e tests, which regularly time out, just
pushed the timeouts to the upgrade e2e tests. I believe it has something to do
with the first test that compiles
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/394
CB-13006: replace create end-to-end tests with unit tests
There were create end-to-end tests that validated use of unicode, spaces
and ascii characters in project names and destination
Github user petermetz commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/107
My pleasure, great to see it made it in! Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user joshdholtz commented on the issue:
https://github.com/apache/cordova-ios/pull/324
@shazron Rebased from master so that the tests and linter actually run and
pass now. Also separated out the escaping of single quotes into its own
function for better testing and added a
GitHub user AndyClausen opened a pull request:
https://github.com/apache/cordova-android/pull/393
Fix for Jira issue CB-12981
https://issues.apache.org/jira/browse/CB-12981
Using match with regex instead of split and replace
### Platforms affected
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/324
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=h1)
Report
> Merging
[#324](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=desc) into
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/362
@filmaj, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/362
Regarding changes in `spec/e2e/helpers/projectActions.js`, script path
within this
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/362
This bug affects user only if project path includes spaces.
Repro steps:
1) Create project in folder with space in name (i.e `C:\my projects\sample`)
2) Run `cordova
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/107
Tested and merged, thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
43 matches
Mail list logo
