Re: [DISCUSS] Moving JIRA issues to Github

2017-08-11 Thread Shazron
Clearing up some questions here. @dpogue --- True, we will have to rely on users filing issues in the right place. JIRA however, does not make it easy to do that since they start with a blank slate. When a user files an issue on a repo, they 95% know it applies to that repo. The 5% of the time i

Nightly build #451 for cordova has failed

2017-08-11 Thread Apache Jenkins Server
Nightly build #451 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/451/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/451/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread Shazron
😂 I do! yes 4.4.1 On Aug 11, 2017 at 5:40 PM, julio cesar sanchez wrote: You probably mean 4.4.1 El 11 ago. 2017 3:37 p. m., "Steven Gill" escribió: Yay! On Aug 11, 2017 12:19 PM, "Shazron" wrote: Long overdue. The board is here: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapi

[GitHub] wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10

2017-08-11 Thread git
wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10 URL: https://github.com/apache/cordova-ios/pull/302#issuecomment-321947370 Could you tell me what the alternative method is? This is an automated me

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread julio cesar sanchez
You probably mean 4.4.1 El 11 ago. 2017 3:37 p. m., "Steven Gill" escribió: > Yay! > > On Aug 11, 2017 12:19 PM, "Shazron" wrote: > > > Long overdue. > > > > The board is here: > > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173 > > > > Any issues in the left column that abs

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132795105 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) { fs.writeFileSync(pkgJsonP

[GitHub] kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup

2017-08-11 Thread git
kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup URL: https://github.com/apache/cordova-windows/pull/239 ### Platforms affected windows ### What does this PR do? Ticket: https://issues.apache.org/jira/browse/CB-13175

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132781446 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) { fs.writeFileSync(pkgJso

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132780726 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) { fs.writeFileSync(pkgJso

[GitHub] cordova-lib pull request #574: CB-12838 : prevented sorting and alphabetizin...

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/574#discussion_r132780476 --- Diff: src/cordova/restore-util.js --- @@ -341,19 +340,29 @@ function installPluginsFromConfigXML (args) { fs.writeFileSync(pkgJso

[GitHub] cordova-lib pull request #583: CB-12361 : added tests for plugin/index.js

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] shazron commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git
shazron commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#discussion_r132772679 ## File path: bin/templates/scripts/cordova/lib/Podfile.js ## @@ -98,8 +98,8

[GitHub] shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

2017-08-11 Thread git
shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno? URL: https://github.com/apache/cordova-ios/pull/321#issuecomment-321905248 Changing release to cordova-ios@4.4.1 --

[GitHub] shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

2017-08-11 Thread git
shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno? URL: https://github.com/apache/cordova-ios/pull/321 This is an automated message from the Apache Git Service. To

[GitHub] shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-11 Thread git
shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330 This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread Steven Gill
Yay! On Aug 11, 2017 12:19 PM, "Shazron" wrote: > Long overdue. > > The board is here: > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173 > > Any issues in the left column that absolutely need to go in? If not I will > punt them to the next release. >

[DISCUSS] cordova-ios 4.1.1 Release

2017-08-11 Thread Shazron
Long overdue. The board is here: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173 Any issues in the left column that absolutely need to go in? If not I will punt them to the next release.

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/581#discussion_r132758763 --- Diff: src/cordova/plugin/remove.js --- @@ -68,6 +68,7 @@ function remove (projectRoot, targets, hooksRunner, opts) {

[GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/581#discussion_r132758854 --- Diff: spec/cordova/plugin/remove.spec.js --- @@ -32,18 +66,123 @@ describe('cordova/plugin/remove', function () { expect(e.me

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-11 Thread Steven Gill
https://issues.apache.org/jira/browse/INFRA-14848 On Fri, Aug 11, 2017 at 10:05 AM, Steven Gill wrote: > GRR > > I'm going to request the same for PRs > > > On Thu, Aug 10, 2017 at 3:01 PM, Filip Maj wrote: > >> Well, it's a PR-specific one (open/close PR actions send an email). We >> asked for

[GitHub] iget-master commented on issue #393: Fix for Jira issue CB-12981

2017-08-11 Thread git
iget-master commented on issue #393: Fix for Jira issue CB-12981 URL: https://github.com/apache/cordova-android/pull/393#issuecomment-321877182 Someone on this? It's impossible to run cordova over android emulator with Android 8 AVD due this issue -

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r132738598 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,75 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-lib pull request #577: CB-12361 : added tests for platform/list.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/577#discussion_r132742737 --- Diff: spec/cordova/platform/list.spec.js --- @@ -0,0 +1,75 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

Re: [GitHub] shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-11 Thread Steven Gill
GRR I'm going to request the same for PRs On Thu, Aug 10, 2017 at 3:01 PM, Filip Maj wrote: > Well, it's a PR-specific one (open/close PR actions send an email). We > asked for commits to not be sent to dev, not for PR activity to not be > sent to dev. > > On Thu, Aug 10, 2017 at 1:48 PM, Steve

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/582#discussion_r132736159 --- Diff: spec/cordova/plugin/search.spec.js --- @@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () { console.error(e);

[GitHub] cordova-lib pull request #582: CB-12361 : added tests for plugin/search.js

2017-08-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/582#discussion_r132736117 --- Diff: spec/cordova/plugin/search.spec.js --- @@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () { console.error(e);

[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE

2017-08-11 Thread git
macdonst commented on issue #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399#issuecomment-321831462 Got the ? from @infil00p so I've merged this PR. Off to prevent cordova-plugin-compat from being installed on the next version of cordova-android.

[GitHub] macdonst closed pull request #399: CB-12730: Compat - INTEGRATE

2017-08-11 Thread git
macdonst closed pull request #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git
codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321806420 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/326?src=pr&el=h1) Report > Merging [#326](http

[GitHub] igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git
igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321805967 I fixed problem with failed test on appveyor ---

[GitHub] janpio commented on issue #244: CB-10140 Use application id instead of package name when running

2017-08-11 Thread git
janpio commented on issue #244: CB-10140 Use application id instead of package name when running URL: https://github.com/apache/cordova-android/pull/244#issuecomment-321799938 Was this added via another PR in the meantime? Seems like a useful change. --

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

2017-08-11 Thread janpio
Github user janpio commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591 --- Diff: README.md --- @@ -27,6 +27,18 @@ description: Access accelerometer data. # cordova-plugin-device-motion +#