Nightly build #463 for cordova has failed

2017-08-23 Thread Apache Jenkins Server
Nightly build #463 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/463/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/463/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] Browser 5.0.0 release

2017-08-23 Thread Steven Gill
Okay. Sent PRs to fix browser [1] and cordova serve [2]. [1] https://github.com/apache/cordova-browser/pull/41 [2] https://github.com/apache/cordova-serve/pull/4 I will plan to merge these in tomorrow and start a release for both. On Thu, Aug 17, 2017 at 11:40 AM, Steven Gill

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-23 Thread danova123
Github user danova123 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 @denisx304 Thanks for the clarification. Looking forward to see it getting added to the base branch soon. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-23 Thread denisx304
Github user denisx304 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 I understand you now. This PR does not include that feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-23 Thread danova123
Github user danova123 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 I mean its a great addition to the existing plugin. I will use it to set cookies( Name and Value) but i need to read cookies first from a different browser to pass it to the

[GitHub] cordova-plugin-file pull request #216: CB-13208: (windows) Fix `readAsBinary...

2017-08-23 Thread salbahra
GitHub user salbahra opened a pull request: https://github.com/apache/cordova-plugin-file/pull/216 CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range ### Platforms affected Windows ### What does this PR do? Change `readAsBinaryString` on

[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...

2017-08-23 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Alright @shazron made those changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android

2017-08-23 Thread denisx304
Github user denisx304 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 @danova123 Please go through my commit. The `cordova.InAppBrowser.open` receives one more parameter, which is an object. The keys of this object are the name of the cookies

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android

2017-08-23 Thread danova123
Github user danova123 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 @denisx304 I meant does it return cookies from server when user logs in( For example) will CookieManager.getCookie be called at any point of time or could it be called

[GitHub] cordova-plugin-inappbrowser issue #122: Added Android cookie sharing functio...

2017-08-23 Thread danova123
Github user danova123 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/122 Unable to call getCookies manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android

2017-08-23 Thread denisx304
Github user denisx304 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 @danova123 what do you mean? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android

2017-08-23 Thread danova123
Github user danova123 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 Does it also reads the cookie value? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-js pull request #147: CB-8990: bump nodejs requirement to 4.0.0+

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-js pull request #147: CB-8990: bump nodejs requirement to 4.0.0+

2017-08-23 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-js/pull/147 CB-8990: bump nodejs requirement to 4.0.0+ So that we can close https://issues.apache.org/jira/browse/CB-8990 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI

2017-08-23 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/185 Any reason why this can't be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file issue #207: CB-12930: (windows) Fix getDirectory trailin...

2017-08-23 Thread cadesalaberry
Github user cadesalaberry commented on the issue: https://github.com/apache/cordova-plugin-file/pull/207 Key there, I would love this PR to be merged as well ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your