Re: [DISCUSS] Plugin release

2017-09-19 Thread Steven Gill
Plugin vote is going to fail it seems due to the issue simon found. Simons message: "Failed * Added cordova-plugin-camera to a project with cordova-android 6.3.0 which depends on cordova-plugin-compat and the build fails. The reason the build fails is that all of the cordova plugins that depend

Re: [VOTE] Plugins Release

2017-09-19 Thread Steven Gill
nice catch. On Tue, Sep 19, 2017 at 8:10 PM, Simon MacDonald wrote: > I vote - 1 > > Passed > * Checked for deprecation notices for plugin-device-motion & orientation > * Tested that cordova-plugin-console is not added for ios when cordova-ios > >= 4.5.0 > * Tested

Re: [VOTE] Plugins Release

2017-09-19 Thread Simon MacDonald
I vote - 1 Passed * Checked for deprecation notices for plugin-device-motion & orientation * Tested that cordova-plugin-console is not added for ios when cordova-ios >= 4.5.0 * Tested that cordova-plugin-compat is not added for android when cordova-android >= 6.3.0 Failed * Added

Nightly build #490 for cordova has failed

2017-09-19 Thread Apache Jenkins Server
Nightly build #490 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/490/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/490/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] Cordova iOS 4.5.1 release

2017-09-19 Thread Suraj Pindoria
I have just tested all the above issues with the official release versions of iOS 11 and Xcode 9 and can confirm that they are all fixed. We just need to merge in https://issues.apache.org/jira/browse/CB-13191, and then we should be good to release cordova-ios@4.5.1. Suraj.On Friday,

[GitHub] cordova-plugin-camera issue #200: CB-9852: cordova-plugin-camera file picker...

2017-09-19 Thread Lianite
Github user Lianite commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/200 Is there an ETA for this getting merged in? This still appears to be a problem as of v.2.4.1. --- - To

[GitHub] cordova-lib pull request #595: CB-12361 : updated and added unit tests for a...

2017-09-19 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/595 CB-12361 : updated and added unit tests for add.spec.js ### Platforms affected ### What does this PR do? Updated and added "to-do" unit tests for add.spec.js