Nightly build #518 for cordova has succeeded!

2017-10-18 Thread Apache Jenkins Server
Nightly build #518 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/518/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-18 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/597 I think turning it back to `package` in plugman is the way to go. We can add an eslint exception for it I hope --- - To

Re: [discuss] plugins release

2017-10-18 Thread Steven Gill
Yay! I'll review soon and make sure they make it in for the release On Wed, Oct 18, 2017 at 4:17 PM, Kelvin Dart wrote: > cordova-plugin-compat has been removed and PRs for relevant plugins has > been raised here: > >

Re: [discuss] plugins release

2017-10-18 Thread Kelvin Dart
cordova-plugin-compat has been removed and PRs for relevant plugins has been raised here: https://github.com/apache/cordova-plugin-camera/pull/293 https://github.com/apache/cordova-plugin-contacts/pull/156

[ANNOUNCE] Cordova iOS Release

2017-10-18 Thread Suraj Pindoria
Tweet: https://twitter.com/apachecordova/status/920748921080594432 Blog: https://cordova.apache.org/announcements/2017/10/16/ios-release.html

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-18 Thread OminousWater
Github user OminousWater commented on the issue: https://github.com/apache/cordova-lib/pull/597 OK I understand the problem better now. init-package-json (a separate npm module) initialises the global variable 'package' in init-package-json.js. So ideally init-package-json would use

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-18 Thread OminousWater
Github user OminousWater commented on the issue: https://github.com/apache/cordova-lib/pull/597 @zaq962 I think I have the "correct" fix now, am about to open another pull request. --- - To unsubscribe, e-mail:

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-18 Thread OminousWater
Github user OminousWater commented on the issue: https://github.com/apache/cordova-lib/pull/597 @zaq962 if you apply the changes in my pull request (it's just one file) to your local checkout, it should work fine. The only reason it doesn't pass the continuous integration test is

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

2017-10-18 Thread zaq962
Github user zaq962 commented on the issue: https://github.com/apache/cordova-lib/pull/597 how can i resove it, I have the same problem --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional

Re: [discuss] plugins release

2017-10-18 Thread julio cesar sanchez
I have some PRs that I've not merged because of Android tests failing (any of my PRs is for Android), not sure if it's ok to merge them. https://github.com/apache/cordova-plugin-camera/pull/291 https://github.com/apache/cordova-plugin-geolocation/pull/94

Re: [discuss] plugins release

2017-10-18 Thread Kelvin Dart
I will make these pulls later this afternoon. I'll respond here with the PRs when raised. Kelvin Best regards, Kelvin On 18 October 2017 at 00:25, Steven Gill wrote: > Going to try to start it later this week. Still waiting on a few prs to > come in around removing