Nightly build #520 for cordova has succeeded!

Nightly build #520 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/520/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #600: CB-13478 : Fix CRLF line endings and lint int...

GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/600 CB-13478 : Fix CRLF line endings and lint integration tests. ### Platforms affected N/A ### What does this PR do? - Change CRLFs to LFs - Configures eslint to

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/597 merged! Thanks again @OminousWater! --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/597 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/597 No worries @OminousWater! That is what reviews are for :) CI gets trigged with new commits or updated commits. Looks like your PR triggered it. I'll wait and see how they go ---

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

Github user OminousWater commented on the issue: https://github.com/apache/cordova-lib/pull/597 Thanks for picking up on those problems -- how embarrassing! The lines removed from .eslintignore was a complete mistake on my part, thank you for spotting that. I've re-instated those

[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/599 CB-13463 : prevent package.json update with --nosave (for plugins) ### Platforms affected ### What does this PR do? Prevent package.json update with --nosave

Re: PR to add native-scroll-to-top option to cordova-plugin-statusbar

Sounds like a useful change. -J 2017-10-20 19:22 GMT+02:00 julio cesar sanchez : > Any other opinions about this? > > > > 2017-10-01 15:56 GMT+02:00 julio cesar sanchez : > >> I'm +1 on this >> >> 2017-09-30 0:56 GMT+02:00 Lu Wang

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/597#discussion_r146039059 --- Diff: src/plugman/init-defaults.js --- @@ -55,25 +55,26 @@ function readDeps (test) { }; } -var name = pkg.name ||

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/597#discussion_r146038992 --- Diff: .eslintignore --- @@ -1,4 +1 @@ -spec/cordova/fixtures/** -spec/plugman/projects/** -spec/plugman/plugins/**

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/597#discussion_r146039159 --- Diff: src/plugman/init-defaults.js --- @@ -149,10 +149,11 @@ if (!pkg.author) { } : prompt('author'); } -/*

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

Github user OminousWater commented on the issue: https://github.com/apache/cordova-lib/pull/597 I have committed my fix now, and think the pull-request is good to go. eslint is still reporting errors, but I've repro'd them locally and can confirm they're unrelated to my pull request.

Re: PR to add native-scroll-to-top option to cordova-plugin-statusbar

Any other opinions about this? 2017-10-01 15:56 GMT+02:00 julio cesar sanchez : > I'm +1 on this > > 2017-09-30 0:56 GMT+02:00 Lu Wang : > >> This is in regards to the following PR: https://github.com/apache/cord >> ova-plugin-statusbar/pull/83

[GitHub] cordova-lib issue #597: CB-13451 (all platforms) "pkg not defined" exception...

Github user OminousWater commented on the issue: https://github.com/apache/cordova-lib/pull/597 @stevengill I have a working fix locally now (on advice from the eslint devs I've added a top-level .eslintignore file with a pattern that filters out any init-defaults.js files). The

[GitHub] cordova-lib pull request #597: CB-13451 (all platforms) "pkg not defined" ex...

GitHub user OminousWater reopened a pull request: https://github.com/apache/cordova-lib/pull/597 CB-13451 (all platforms) "pkg not defined" exception when running plugman with createpackagejson command-line A global js-lint pass on the cordova-lib codebase on the 30/8/2017 caused