Nightly build #705 for cordova has succeeded!

2018-04-29 Thread Apache Jenkins Server
Nightly build #705 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/705/consoleFull - Jenkins for Apache Cordova

Re: Add support for annotation @CordovaMethod

2018-04-29 Thread Wojciech Trocki
I have created PR in Android repository to show idea. https://github.com/apache/cordova-android/pull/439 Aproach is not using reflection/annotations mentioned in original proposition. IMHO with this change plugin interface will be much simpler and more object oriented. On Sun, Apr 29, 2018 at

Re: Add support for annotation @CordovaMethod

2018-04-29 Thread Rabindra Nayak
How about iOS annotation @CordovaMethod.Because the way Android and iOS and other OS plugin implementation should be same.We need think that aspect. On Sun, Apr 29, 2018, 21:08 Joe Bowser wrote: > Cordova should be reducing the use of Reflection, not increasing it. I >

Re: Add support for annotation @CordovaMethod

2018-04-29 Thread Joe Bowser
Cordova should be reducing the use of Reflection, not increasing it. I don't think this is a good idea. On Sun, Apr 29, 2018, 8:28 AM Jesse, wrote: > I would like to see proof of value. > I believe the lookup of an action is insignificant compared to the message >

Re: Add support for annotation @CordovaMethod

2018-04-29 Thread Jesse
I would like to see proof of value. I believe the lookup of an action is insignificant compared to the message conversion between js and native. Please write some tests to justify your position. > On Apr 29, 2018, at 7:59 AM, julio cesar sanchez > wrote: > > I

Re: Add support for annotation @CordovaMethod

2018-04-29 Thread julio cesar sanchez
I think it's a good idea. FYI, there is a plugin that already allows this, you just have to add it as a dependency, but it's not backward compatible https://github.com/edewit/aerogear-reflect-cordova 2018-04-29 16:44 GMT+02:00 Wojciech Trocki : > Hi Maksim > > `if

Re: Add support for annotation @CordovaMethod

2018-04-29 Thread Wojciech Trocki
Hi Maksim `if (METHOD_1.equals(action))` is very similar way to how redux works. I have playing with your proposition to see how this could be implemented. What I found is that processing annotations on runtime can contribute to slower application startup due to fact that annotation needs to be

Add support for annotation @CordovaMethod

2018-04-29 Thread chemerisuk
Hi guys. cordova-ios has a nice method binding for plugins. Unfortunately cordova-android requires at present boilerplate implementation of method execute: public class MyPlugin extends CordovaPlugin { ... @Override public boolean execute(String action, JSONArray args,