PR with additional linting rules

2018-05-08 Thread Darryl Pogue
Hi folks, There's a PR[1] to cordova-common that turns on some additional linting rules and removes unused function parameters. I'm happy to merge it but feel like I shouldn't unilaterally approve changes to our linting rules, so anyone else have any strong feelings on this? [1] https://github.c

Re: PR with additional linting rules

2018-05-08 Thread Steven Gill
I don't have any issues adding those new rules around unused args. It would be best if we incorporated the new rules across all of our repos, but I'm not going to be picky at this stage On Tue, May 8, 2018 at 7:26 AM Darryl Pogue wrote: > Hi folks, > > There's a PR[1] to cordova-common that turn

Nightly build #714 for cordova has failed

2018-05-08 Thread Apache Jenkins Server
Nightly build #714 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/714/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/714/consoleFull - Jenkins for Apache Cordova

Please remove me from the mailing list

2018-05-08 Thread Ntobeko Mkhize

Re: Please remove me from the mailing list

2018-05-08 Thread Shazron
Removal is self-serve. See http://cordova.apache.org/contact/ for unsub addresses. On Wed, May 9, 2018 at 12:08 PM Ntobeko Mkhize wrote: > >