Re: [DISCUSS] InAppBrowser 4.0.0 major release

2020-06-04 Thread julio cesar sanchez
As far as I know, the versions are the minimum required to work, not the minimum supported by the plugin. But yeah, ideally we could set all of them to recent versions to make sure people don't use them in very old versions. For the record, not all plugins have engines or some have but not for

Re: [DISCUSS] InAppBrowser 4.0.0 major release

2020-06-04 Thread Chris Brody
The whole motivation behind adding the minimum Cordova engine version, in the first place, seems to be here: https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L33 It says "Needs cordova/urlutil". I think we do not specify the minimum Cordova engine version on most of

Re: [DISCUSS] InAppBrowser 4.0.0 major release

2020-06-04 Thread Niklas Merz
Correct me if I am wrong, but I don't think we want to update the dependency versions to the current ones. It's just another version we have to track and update. I must say I don't really know what they are for and would love to learn about that. The PR updates them to be consistent and working

Re: [DISCUSS] InAppBrowser 4.0.0 major release

2020-06-04 Thread Chris Brody
I would favor updating the minimum Cordova requirement in both package.json and plugin.xml, as I just commented in PR #685. I wish I would have seen it before PR #685 was merged. On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz wrote: > I merged two outstanding patches just now. > > If no reviews

Re: [DISCUSS] InAppBrowser 4.0.0 major release

2020-06-04 Thread Niklas Merz
I merged two outstanding patches just now. If no reviews or concern come up, I will start the release in a few hours. June 2, 2020 8:31 PM, "Niklas Merz" wrote: > Hi all, > > since cordova-ios 6.0 was released recently the inappbrowser plugin does not > work properly because > of the

Re: [VOTE] Splashscreen Plugin Release 5.0.4

2020-06-04 Thread Norman Breau
I vote +1: * Ran npm test (on linux) * Ran verify-tags * Ran verify-archive On 2020-06-03 3:21 p.m., Niklas Merz wrote: (sending again because previous email was attached to discuss thread) Please review and vote on the release of this plugins release by replying to this email (and keep

Re: [DISCUSS] Splashscreen Plugin Release 5.0.4

2020-06-04 Thread Norman Breau
I guess Erisu sorted this out in https://github.com/apache/cordova-plugin-splashscreen/pull/266 There are a couple of reasons for the fail we think, mostly because pandemic tests only tests against the master. So in this case, it was using cordova-ios 6, which expects Xcode 11, and drops

[ANNOUNCEMENT] Cordova iOS 6.0.0 Release

2020-06-04 Thread Bryan Ellis
We have just released a major update to our ios platform! - cordova-ios@6.0.0 You can view the release blog post at https://cordova.apache.org/announcements/2020/06/01/cordova-ios-release-6.0.0.html - To unsubscribe, e-mail:

[ANNOUNCEMENT] Cordova Tooling Release

2020-06-04 Thread Bryan Ellis
We have just released a major update and patch release to our cordova tooling! - cordova-common@4.0.1 (2020-05-19) - cordova-node-xcode@3.0.1 (2020-05-19) - cordova-create@3.0.0 You can view the release blog post at https://cordova.apache.org/news/2020/06/01/tools-release.html

Re: [DISCUSS] Splashscreen Plugin Release 5.0.4

2020-06-04 Thread Niklas Merz
I must say I don't really understand that failure, too. I think it's something strange in the CI/Travis. (Hopefully this will be on Github Actions, too sometime). CI uses Xcode 10.3 which is not supported by our latests cordova-ios anymore. I think we should not rely on the CI tests for this