I vote +1 * signature and hash ok * tag ok * CI green * license and headers look good * no audit issues * tests pass locally
On November 8, 2022, Norman Breau <nor...@nbsolutions.ca> wrote: > I vote +1: > * Ran npm audit > * Ran NPM Test locally (linux environment) > * I've had a co-worker that have been using a development version > internally for some time now > * Verified Tags > * Verified archive > > On 2022-11-08 10:20 a.m., Bryan Ellis wrote: > > Please review and vote on this cordova-common release v4.1.0 > > by replying to this email (and keep discussion on the DISCUSS > thread) > > > > The archive has been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/common-4.1.0 > <https://dist.apache.org/repos/dist/dev/cordova/common-4.1.0> > > > > The package was published from its corresponding git tag: > > > > cordova-common: 4.1.0 (e8e8735648) > > > > Upon a successful vote I will upload the archive to dist/, publish > it to npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/cordova- > coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > ===== > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and sub- > dependencies have Apache-compatible licenses > > * Ensured the continuous build was green when repo was tagged > > * Ran `npm test` > > * Ran `npm audit` > > > > found 0 vulnerabilities > > > > * Ran various `cordova` test w/ sample app: > > * `cordova` > > * `cordova -v` > > * `cordova create` > > * `cordova info` > > * `cordova help` > > * `cordova config ls` > > * `cordova requirements` > > * `cordova telemetry` > > * `cordova plugin` > > * `cordova plugin add` > > * `cordova plugin rm` > > * `cordova platform` > > * `cordova platform add` > > * `cordova platform rm` > > * `cordova build` > > * `cordova prepare` > > * `cordova compile` > > * `cordova run` > > * `cordova serve` > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org
