Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-89449833
@agrieve, I believe I implemented all the changes we discussed. Can you
accept the pull request?
---
If your project is set up for it, you can
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27423375
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27416639
--- Diff: src/android/SplashScreen.java ---
@@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27424716
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27416895
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27442565
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27445114
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444623
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user AlexTalis commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446641
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-87017968
I'm working on a pull request for cordova-plugin-splashscreen master. The
only way I found to set up for the plugin development was to copy
SplashScreen.java
GitHub user AlexTalis opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43
CB-8753 Maintain splash screen aspect ratio
- Added SplashMaintainAspectRatioâ preference to maintain SplashScreen
aspect ratio instead of scaling it to dialog
Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-87089041
Closing this pull request in favor of this one:
https://github.com/apache/cordova-plugin-splashscreen/pull/43
---
If your project is set up for it, you can
Github user AlexTalis closed the pull request at:
https://github.com/apache/cordova-android/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user AlexTalis commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-87086720
It doesn't work for me on Windows, probably because my repo structure is
totally different from what you use. I'm not going to bug you with more
questions
14 matches
Mail list logo
