[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-23 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174199195 Ok looks like it wan't published to NPM yet, just to git https://www.npmjs.com/package/cordova-android https://github.com/apache/cordova-android

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-23 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174198598 @Titoine 5.1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

2016-01-07 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/66#issuecomment-169727420 +1 for this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-12-21 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-166460750 The fix in the cordova platform level is not released yet, unless you want to install the platform from GIT. For the fixed plugin, https

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-12-21 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-166463593 The localstorge sounds like a good solution to me. You can save there even more from the app state and restore the app to be as before the restart

[GitHub] cordova-android pull request: CB-10014: Set gradle applicationId t...

2015-12-21 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/247#issuecomment-166458896 Consider using this code, https://github.com/one-signal/OneSignal-Cordova-SDK/commit/dd9fb05cfb570a8e01e40f1ebf1ce4ed42079882 its based on xml full parse

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

2015-12-13 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-164316409 @Titoine This is not a complete fix, and its not released yet There's also corresponding changes to the camera plugin this change When it will be released

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-12-11 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164083116 You can find more info here: https://issues.apache.org/jira/browse/CB-8917 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-12-11 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-164076417 @thehuijb this issue was solved in the platform level in https://github.com/apache/cordova-android/commit/f5271431fbcda70188f485d9e91541bb596551fe

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

2015-11-19 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-158226691 I will extend the scope of that issue. This change can/should also help the apps developers to recover from situations that the app sent

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

2015-11-19 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-158220594 @riknoll, after going over the docs (which looks great btw) its seems it supports only single plugin result What if you wait for two or more plugins responses

[GitHub] cordova-android pull request: API for saving/restoring plugin and ...

2015-10-28 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/236#issuecomment-151969621 Looks like good a solution, I think you need to also guarantee that handlers registered before you fired the resume event will get it, as it with device ready

Re: Help for Crosswalk Chromium webview consumption.

2015-04-29 Thread Bnaya Peretz
/a/23949505/711152 On Wed, Apr 29, 2015 at 4:03 PM, Vishnu Prakash vishnu.prak...@42gears.com wrote: Hi Bnaya, Alexander I hope everything is awesome at your end and really appreciate your quick help. I explored today about Cordova plugin and was able to build a sample HelloWorld program and launch

[GitHub] cordova-plugin-whitelist pull request: Fixed error in Content-Secu...

2015-04-20 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/3#issuecomment-94456743 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-cli pull request: CB-7949: Added cordova-local utility

2014-11-11 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-cli/pull/196#issuecomment-62598354 i'de really like to see that! in combination with https://issues.apache.org/jira/browse/CB-7208 it will really improve the workflow. that should