[GitHub] cordova-plugin-contacts pull request #129: CB-11455: (ios) Add mandatory iOS...

2016-06-20 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/129 CB-11455: (ios) Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Adds mandatory iOS 10 privacy description

[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...

2016-02-29 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190339317 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...

2016-02-29 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190249697 Thanks for checking it so quickly. What gets reported as warnings depends on how strict your Xcode project is set up. In this case fi

[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...

2016-02-29 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/66 CB-10727 Dialogs plugin has warnings on iOS Should fix https://issues.apache.org/jira/browse/CB-10727 You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...

2016-01-27 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-plugin-device/pull/47 Refactored deviceInfo on iOS for better readability Hi, just a quick cleanup of dictionary creation on iOS. No functional changes, but I like to write those

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/174#issuecomment-151628414 @shazron Of course, overlooked that! See [404](https://github.com/apache/cordova-docs/pull/404). --- If your project is set up for it, you can reply to

[GitHub] cordova-docs pull request: CB-9685 Documentation for the fix for t...

2015-10-27 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-docs/pull/404 CB-9685 Documentation for the fix for the iOS9 longpress issue Documentation for this: https://github.com/apache/cordova-ios/pull/174 You can merge this pull request into a Git

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-23 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150770063 Thanks for your feedback guys, I've opened a new PR #174. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-23 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-ios/pull/174 CB-9685 Enhanced the fix for the iOS9 longpress magnifying glass issue This feature is now disabled by default and can be enabled for longpress in `config.xml`: `` When 3D

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150191011 BTW I am seeing it on 9.1. iPhone 6S, longpress and 3D Touch. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150170110 I think I'll be adding a configuration for this to config.xml as not all folks may like this feature (new PR). The plugin that inspired this P

[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...

2015-10-13 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-147950761 Hey @macdonst do you know if all PhoneGap Build cordova-android builds are Gradle-enabled? Thx --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...

2015-10-08 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-146580602 It would be really great to have this feature as this is one of my main headaches when developing (and maintaining) Cordova Android plugins. This would

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-09-22 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-ios/pull/164 CB-9685 A fix for the magnifying glass popping up on iOS9 longpress I though `CDVLongPressFix` would not be the best name. Especially if we ever need to fix any other gestures Apple

[GitHub] cordova-wp8 pull request: CB-8580 Fix for plugins responding with ...

2015-03-03 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-wp8/pull/77#issuecomment-76902445 Ha, cool, makes a lot of sense. Work you magic! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-wp8 pull request: CB-8580 Fix for plugins responding with ...

2015-03-03 Thread EddyVerbruggen
Github user EddyVerbruggen closed the pull request at: https://github.com/apache/cordova-wp8/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-wp8 pull request: Fix for plugins responding with NO_RESUL...

2015-03-01 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-wp8/pull/77 Fix for plugins responding with NO_RESULT You can merge this pull request into a Git repository by running: $ git pull https://github.com/EddyVerbruggen/cordova-wp8 CB-8580

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-28 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76516415 @purplecabbage Here you go, thanks for the pointers and hope you like it. Re transparency: from what I've read it depends on the

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r2210 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences +- __AndroidStatusBarBackgroundColor__ (color

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76476575 Hi @purplecabbage thanks for the quick review! I've now added runtime support for `backgroundColorByHexString` as you sugg

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
Github user EddyVerbruggen commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25538963 --- Diff: doc/index.md --- @@ -41,6 +41,10 @@ Preferences +- __AndroidStatusBarBackgroundColor__ (color

[GitHub] cordova-plugin-statusbar pull request: Allow setting the statusbar...

2015-02-27 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/22 Allow setting the statusbar backgroundcolor on Android Since Android Lollipop the statusbar of your app is no longer black. On a Samsung Galaxy S5 my mostly white app now