[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-06 Thread EionRobb
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154648176 I wouldn't personally make it look for the "MSAppHost/3.0" string, maybe doing a regex match on that to see if it's version 3.0 or hig

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-05 Thread EionRobb
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154017263 To clarify, the method defines itself as existing, but any attempts to use it will crash the container. There isn't a Jira issue for it, that

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-05 Thread EionRobb
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154016649 Feature detection is broken. It causes the ieframe.dll to crash outside of js and is uncatchable. --- If your project is set up for it, you can reply to

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-09-06 Thread EionRobb
GitHub user EionRobb opened a pull request: https://github.com/apache/cordova-windows/pull/120 Add support for back button on win10 Win10 has support for backbutton through the SystemNavigationManager API https://msdn.microsoft.com/en-us/library/windows/apps

[GitHub] cordova-android pull request: Fix for `android` not being in PATH ...

2014-06-21 Thread EionRobb
GitHub user EionRobb opened a pull request: https://github.com/apache/cordova-android/pull/103 Fix for `android` not being in PATH check on Windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/EionRobb/cordova-android patch-1

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

2014-06-16 Thread EionRobb
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-46233044 ICLA all signed now. Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-file pull request: Add win8 support for readAsBinar...

2014-06-12 Thread EionRobb
GitHub user EionRobb opened a pull request: https://github.com/apache/cordova-plugin-file/pull/51 Add win8 support for readAsBinaryString and readAsArrayBuffer You can merge this pull request into a Git repository by running: $ git pull https://github.com/EionRobb/cordova

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

2014-06-06 Thread EionRobb
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-45399103 No I haven't. I've had other submitted code accepted though if that helps ;-) Do you have a link to the agreement to sign? I couldn&

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

2014-04-30 Thread EionRobb
GitHub user EionRobb opened a pull request: https://github.com/apache/cordova-plugin-device/pull/14 Use Windows system calls to get better info Use the hardware GUID as a basis for the device uuid (to persist between reinstalls) Look at the HAL device driver version to work out