[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-09-09 Thread Gillardo
Github user Gillardo closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-09-09 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138869845 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-07-10 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-120301455 Believe i have done what you asked? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-07-09 Thread Gillardo
Github user Gillardo commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288832 --- Diff: src/windows/CameraProxy.js --- @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-07-09 Thread Gillardo
Github user Gillardo commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288013 --- Diff: src/windows/CameraProxy.js --- @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback, errorCallback, args

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-07-09 Thread Gillardo
GitHub user Gillardo opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/106 Focus control and nicer UI for Windows Phone Create a Take button as well as having the Cancel button. Made the buttons "bootstrap" like, but using styles a

[GitHub] cordova-plugin-statusbar pull request: Stop "object has no method"...

2015-05-22 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104697601 This message acknowledges receipt of your ICLA, which has been filed in the Apache Software Foundation records. If you have been invited as a

[GitHub] cordova-plugin-statusbar pull request: Stop "object has no method"...

2015-05-22 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104608748 @nikhilkh i have emailed the agreement to secret...@apache.org this morning for you. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-statusbar pull request: Stop "object has no method"...

2015-05-21 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25#issuecomment-104391478 Sorry for stupid question, but what up i supposed to do with this? Print it and scan it? Just type in the fields? Where am i supposed to this once i

[GitHub] cordova-plugin-camera pull request: fix wp8.1 UI, added wp8.1 focu...

2015-05-13 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/77#issuecomment-101711464 Found an issue though that if you zoom in, then the buttons disappear and you cannot take the photo --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-camera pull request: fix wp8.1 UI, added wp8.1 focu...

2015-05-11 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/77#issuecomment-100824132 This works on WP8.1, thank you! Please merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-statusbar pull request: Stop "object has no method"...

2015-05-08 Thread Gillardo
GitHub user Gillardo opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25 Stop "object has no method" errors on windows If you called show or hide, you would get an "object has no method" error as getViewStatusBar would return