Github user mmrko closed the pull request at:
https://github.com/apache/cordova-lib/pull/188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mmrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/207#issuecomment-93660630
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mmrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-89337363
Okay, makes sense. Thanks! I'll look into this over the weekend. Or, if you
find the time feel free to put up a PR for this :)
---
If your project is set up f
Github user mmrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-89336092
Thanks for reporting this @VincentFTS. Doesn't seem to work for me either
using the iOS Simulator. Have you tested this on a device?
---
If your project is s
Github user mmrko commented on the pull request:
https://github.com/apache/cordova-docs/pull/276#issuecomment-88833458
> Actually, that is a bug. If 'default' is specified in config.xml, it
should produce plist values to support both landscape and portrait.
I
GitHub user mmrko opened a pull request:
https://github.com/apache/cordova-lib/pull/188
Fall back to platform's default orientation only if using the 'default'
global orientation
In regards to the changes introduced in #128 a small change would probab
GitHub user mmrko opened a pull request:
https://github.com/apache/cordova-docs/pull/266
Update orientation documentation
Update the orientation `` documentation as per the changes
introduced in https://github.com/apache/cordova-lib/pull/128.
You can merge this pull request into
Github user MMrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-69320152
Thanks a lot @agrieve for taking the time to review all of this! Really
helpful :)
---
If your project is set up for it, you can reply to this email and have your
Github user MMrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-69196226
Rebased on master (0f5dbafface487c5738f294e47520d8b2381134d). I squashed
the changes into 3 commits:
6ef506ebd890bf3eca79f8bb034ee9e2ede1c948 Base parser
Github user MMrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-68758963
Validation is now done only on the global orientation preference. Once this
is good for merge let me know and I'll rebase for a cleaner history.
---
If your pr
Github user MMrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-68526026
Thanks for the feedback!
1. True, pardon my ignorance :) I removed the style-only changes
2. I moved the new functionality in to a separate [helper
Github user MMrko commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/128#discussion_r22409503
--- Diff: cordova-lib/src/configparser/ConfigParser.js ---
@@ -219,6 +258,47 @@ ConfigParser.prototype = {
},
/**
+ * Finds
GitHub user MMrko opened a pull request:
https://github.com/apache/cordova-lib/pull/128
CB-8043 CB-6462 CB-6105 Refactor orientation preference support
Fixes [CB-8043](https://issues.apache.org/jira/browse/CB-8043),
[CB-6462](https://issues.apache.org/jira/browse/CB-6462) and
[CB
Github user MMrko commented on the pull request:
https://github.com/apache/cordova-cli/pull/191#issuecomment-64767953
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user MMrko opened a pull request:
https://github.com/apache/cordova-wp8/pull/64
CB-7858 Fix onload="true"
Replace `TakeWhile` with `Where` so that _AutoloadPlugins_ returns all
plugins for which `onload="true"`.
Fixes https://issues.apache.org
15 matches
Mail list logo
