GitHub user NotDaveLane opened a pull request:

    https://github.com/apache/cordova-plugin-device/pull/25

    Request to change the device.platform to always report the browser platform 
as "browser".

    The current Browser platform implementation relies on the value returned by 
the web browser's `navigator.platform`, which has many possible values, making 
platform-specific checks difficult. For example, a Browser platform build 
viewed on an Android device might report the `device.platform` as "Android", 
causing the Cordova app to execute code intended for the Android platform, 
instead of the desired code intended for the Browser platform.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NotDaveLane/cordova-plugin-device master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit bf923a027903fd25ce3c84b751976cef6503935c
Author: Dave Lane <dcl...@gmail.com>
Date:   2014-11-18T03:50:53Z

    Changing device.platform to always report the platform as "browser".
    
    The current implementation relies on the value returned by the web
    browser's `navigator.platform`, which has many possible values, making
    platform-specific checks difficult. For example, a browser platform
    build viewed on an Android client might report the `device.platform`
    as "Android", causing the Cordova app to execute code intended for
    the Android platform.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to