Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
Thanks for picking up on those problems -- how embarrassing! The lines
removed from .eslintignore was a complete mistake on my part, thank you for
spotting that. I've re-instated
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
I have committed my fix now, and think the pull-request is good to go.
eslint is still reporting errors, but I've repro'd them locally and can confirm
they're unrelated to
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
@stevengill I have a working fix locally now (on advice from the eslint
devs I've added a top-level .eslintignore file with a pattern that filters out
any init-defaults.js files)
GitHub user OminousWater reopened a pull request:
https://github.com/apache/cordova-lib/pull/597
CB-13451 (all platforms) "pkg not defined" exception when running plugman
with createpackagejson command-line
A global js-lint pass on the cordova-lib codebase on the 30/8/2
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
@stevengill I've been trying that as alternative solution, however it seems
eslint doesn't support exceptions for parser errors. See their response to the
issue I lodged here af
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
OK I understand the problem better now. init-package-json (a separate npm
module) initialises the global variable 'package' in init-package-json.js. So
ideally init-package-json
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
@zaq962 I think I have the "correct" fix now, am about to open another pull
request.
---
-
To unsubscribe, e
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
@zaq962 if you apply the changes in my pull request (it's just one file) to
your local checkout, it should work fine. The only reason it doesn't pass the
continuous integrati
Github user OminousWater closed the pull request at:
https://github.com/apache/cordova-lib/pull/597
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h
Github user OminousWater commented on the issue:
https://github.com/apache/cordova-lib/pull/597
I see the CI has failed, because 'package' is a reserved keyword (this
better explains the changes made as part of the js-lint pass a few months
back). Perhaps the better fix, t
GitHub user OminousWater opened a pull request:
https://github.com/apache/cordova-lib/pull/597
CB-13451 (all platforms) "pkg not defined" exception when running plugman
with createpackagejson command-line
A global js-lint pass on the cordova-lib codebase on the 30/8/2
11 matches
Mail list logo
