Re: Android plugin crash on resume when activity destroyed

2015-06-04 Thread Serge Huijben
y vulnerable to this issue -- e.g. barcode scanner being > another > > one (I have a few real world crashes on this, too -- but not as many as > for > > Camera). So a more general purpose solution might be appropriate if > > possible. > > > > Dan > &g

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Serge Huijben
Joe, it failing on Travis was not caused by the code in the pullrequest. I just changed one word in the readme.md and committed that to have Travis build it again and now it's all good. - Serge Op do 4 jun. 2015 om 07:54 schreef Serge Huijben : > I must say that restoring state in the

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Serge Huijben
ue affects all android plugins that call > > other intents, won't we have to do this for all of them? Is there a way > we > > can leverage your PR and maybe come up with a general solution ? Maybe > fit > > the boilerplate code (state saving/restoring) somewhere all a

Re: Android plugin crash on resume when activity destroyed

2015-06-03 Thread Serge Huijben
what I did to solve this is add a check for callbackcontext, If that is null save the incoming parameters. if (this.callbackContext == null) { this.savedRequestCode = requestCode; this.savedResultCode = resultCode; this.savedIntent = intent; } els

Re: [DISCUSS] Plugins Release

2015-06-02 Thread Serge Huijben
https://github.com/apache/cordova-plugin-camera/pull/97, if you please Serge Op di 2 jun. 2015 om 20:15 schreef Joe Bowser : > Is there a test attached to that PR? This seems like something that would > break again. > > On Tue, Jun 2, 2015 at 11:11 AM Steven Gill > wrote: > > > Thanks Darryl! >

[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....

2015-05-13 Thread Serge Huijben
Any chance this PR https://github.com/apache/cordova-plugin-camera/pull/83 could get merged in? regards Serge a.k.a: thehuijb signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [Vote] 4.0.0 Android Release

2015-04-14 Thread Serge Huijben
+1 > On 14 Apr 2015, at 20:17, Simon MacDonald wrote: > > +1 > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Tue, Apr 14, 2015 at 2:14 PM, Brian LeRoux wrote: >> +1 >> >> On Tue, Apr 14, 2015, 1:07 PM Joe Bowser wrote: >> >>> +1 >>> >>> - verified archive >>> - ran mobile-spec >>

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-04-09 Thread Serge Huijben
Then, it seems strange to me that it logs an error and repeated warnings if the meta tag is missing. Perhaps we should remove that from the plugin. Op do 9 apr. 2015 om 20:21 schreef Ian Clelland > Moving from [VOTE] thread: > > On Thu, Apr 9, 2015 at 1:44 PM, Serge Huijben wrote: >

Re: [Vote] 4.0.0 Android Release

2015-04-09 Thread Serge Huijben
But why is the meta csp tag required? Op do 9 apr. 2015 om 19:36 schreef Ian Clelland > On Thu, Apr 9, 2015 at 1:26 PM, Treggiari, Leo > wrote: > > > Do the whitelist changes mean that current access origin entries in a > > config.xml file will be ignored the next time that a developer builds >

Re: introduction

2015-03-29 Thread Serge Huijben
Thanks Op vr 27 mrt. 2015 om 15:20 schreef Andrew Grieve > Welcome Serge! Just merged your PR ( > https://github.com/apache/cordova-android/pull/169) Great stuff! > > On Fri, Mar 27, 2015 at 9:08 AM, Victor Sosa > wrote: > > > Welcome aboard, Serge! > > On Mar 27

introduction

2015-03-27 Thread Serge Huijben
happy in fact that I would really like to help make it even better. so expect to see a few PR’s from me (or my alias thehuijb) soon. regards, Serge Huijben (aka thehuijb) signature.asc Description: Message signed with OpenPGP using GPGMail