[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-190311984 When I created this, it was meant to be used as a proof of concept for something at my place of employment. We recently dropped this path so I

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-13 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-183625072 Ok, so its looking like I can spend some time on this tommorrow (or today really. I'm up way too late). I went ahead and cleaned u

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2016-02-09 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-182066306 I've been meaning to come back to this. I've been incredibly busying reforming the front-end process at my job. I'm trying to fi

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-12-02 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161487045 I never tried this with XWalk but I'm not opposed to checking it out. I'm at Rich Web right now so give me a few days to look

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-12-02 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161420725 When you say you do not get cookies set, are you talking about using this code or default functionality? I did not test against XWalk, but I

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152341785 I think we have different concerns here even though we agree on the same thing. If the app developer is concerned about exposing their

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152337481 Correct, my thought process was that you would want to absolutely clear these cookies upon closing the app. Which leads into a

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152334883 >The fact that iOS shares cookies is a defect imho. I would be completely ok with agreeing with this. I just want constancy, assum

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

2015-10-29 Thread Sinistralis
GitHub user Sinistralis opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122 Added Android cookie sharing functionality between webviews There currently exists a gap in functionality with Android as opposed to iOS where iOS will actively share