[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-14 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/149#issuecomment-196412080 Oh, thanks for the hint! This is great! :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

2016-03-10 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-194745886 > * calling navigator.splashscreen.hide(); does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10) Ok, this was my fault

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-09 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/149#issuecomment-194349294 You should allow scale 200 images for UWP10 apps. The scale 100 images look a bit blurry on a Lumia 950 and scale 240 is no longer supported: ```js

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

2016-03-09 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-194337561 Two comments on this: * calling `navigator.splashscreen.hide();` does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10

[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...

2016-01-27 Thread SunboX
Github user SunboX commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50958608 --- Diff: README.md --- @@ -123,13 +123,26 @@ window.setTimeout(function () { }, splashDuration - fadeDuration

[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...

2016-01-27 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-175494339 That's great! Just was looking for a way how to set the background color for UWP splash screen (Windows 10 Mobile). Thanks for your work! :+1: :heart

[GitHub] cordova-docs pull request: Fix invalid dash sign (`Too many parame...

2016-01-19 Thread SunboX
GitHub user SunboX opened a pull request: https://github.com/apache/cordova-docs/pull/459 Fix invalid dash sign (`Too many parameters` exception) You can merge this pull request into a Git repository by running: $ git pull https://github.com/SunboX/cordova-docs patch-1

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-09-01 Thread SunboX
Github user SunboX closed the pull request at: https://github.com/apache/cordova-wp8/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-08-29 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-wp8/pull/84#issuecomment-135967738 Are you serious? For this snipped of code? No, dry, to much work. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen pull request: CB-7964 Add cordova-plug...

2015-06-19 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/34#issuecomment-113439475 I'm getting `10:53:31.345 uncaught exception: module cordova/confighelper not found1 unknown` using Cordova 5.1.1 --- If your project is set up

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-06-19 Thread SunboX
GitHub user SunboX opened a pull request: https://github.com/apache/cordova-wp8/pull/84 Added the XHR upload attribute Added the XHR upload attribute as defined by https://xhr.spec.whatwg.org/#the-upload-attribute and documented at MDN here https://developer.mozilla.org/de/docs

[GitHub] cordova-firefoxos pull request: some cleanup and linting

2014-06-19 Thread SunboX
Github user SunboX closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so