GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/512
CB-12284 Include project root as additional root for static router
### Platforms affected
All
### What does this PR do?
With this change, cordova-serve includes the project
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/498#discussion_r82568768
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-lib/pull/498
@brodybits - that hasn't changed. At the point where we're looking for a
cached version, we have already determined the latest version that matches the
requested range (for both pla
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/498#discussion_r82566198
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -72,4 +75,53 @@ function restoreSettings() {
}
}
+/**
+ * Fetches the
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/498
CB-11985 Check if cached platform/plugin exists before 'npm cache'
### What does this PR do?
Before calling `npm cache add` when installing a platform or plugin, look
for a
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-docs/pull/623
Couple of comments. Other than that looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/623#discussion_r72483583
--- Diff: www/_posts/2016-07-27-cordova-windows-4.4.2.md ---
@@ -0,0 +1,33 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/623#discussion_r72483527
--- Diff: www/_posts/2016-07-27-cordova-windows-4.4.2.md ---
@@ -0,0 +1,33 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-windows/pull/188
Merged in 2d7d219fc1864fa22f87cebadac173fd41091351.
Sorry @jicongw, I forgot to tag this PR in the modified commit, so you will
have to close the PR manually.
---
If your
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-windows/pull/188
Thanks @jicongw - I just had one comment, plus fixing the commit message as
I mentioned offline.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/188#discussion_r71791061
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -93,6 +93,20 @@ module.exports.findAllAvailableVersions = function
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54834210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54819210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54817429
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54809830
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54728499
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191259905
This is looking great **@rikroll**! I have a few comments, but mostly
pretty minor stuff.
---
If your project is set up for it, you can reply to this email and
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727968
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727324
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727076
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54726540
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54726389
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54723579
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722281
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722165
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722073
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722038
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-docs/pull/531
Rewrite of storage guide.
* Provides more details about each of the options.
* Provides examples.
* Describes pros and cons of each approach.
You can merge this pull request into a
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-browser/pull/10#issuecomment-191031984
@amikula - this PR was closed by a commit made to `cordova-firefoxos`,
which was probably done by mistake.
But regarding this problem specifically
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188730806
Thanks @vladimir-kotikov - looks good. Just a couple of suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/398#discussion_r54079687
--- Diff: cordova-lib/src/plugman/platforms/browser.js ---
@@ -31,25 +29,7 @@ module.exports = {
return path.join(project_dir,
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/398#discussion_r54079611
--- Diff: cordova-lib/src/plugman/platforms/common.js ---
@@ -22,7 +22,39 @@ var shell = require('shelljs'),
fs= r
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188545978
A simpler fix might be: since all we're looking for is the project's `id`,
why not fall back on the main Cordova project's `config.xml` if
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-187701057
Other than one small remaining question, looks great! Thanks @riknoll!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53779104
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,22 @@ function listPlatforms(project_dir) {
});
}
+function
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db#commitcomment-16237620
Hey @vladimir-kotikov - this fix causes a crash when adding the browser
platform (maybe any platform that doesn't hav
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53536875
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-185729885
Yep, that looks right to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185719821
Oops, sorry :smile: ... LGTM. There's nowhere we call these directly
internally and expect an actual value in return?
---
If your project is set up for it
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305903
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305804
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305710
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305319
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304887
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304649
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53302711
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301932
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301382
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300652
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300300
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300134
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53299072
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298695
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298645
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53297519
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -492,17 +492,13 @@ function list(hooksRunner, projectRoot, opts) {
var platforms_on_fs
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-185005103
Thanks @bso-intel. I've merged this in
https://github.com/apache/cordova-lib/commit/87d8e171, but I rebased on forgot
to add "This closes #387"
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-184676141
Thanks @vladimir-kotikov. Looks good on a quick look through. Will take a
closer look in the morning.
---
If your project is set up for it, you can reply to
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52993992
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52984062
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/388#issuecomment-184563301
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/387#discussion_r52976299
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,10 +132,14 @@ function fetchPlugin(plugin_src, plugins_dir,
options
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/375#issuecomment-179513568
:+1: Thanks Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179511413
Looks great! Just one comment: I think just a couple of spaces would look
better than a tab.
Also, looks like there is a test that is sensitive to the
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179503770
Yeah, and in fact, for consistency maybe "installed platforms" should also
be separated by line breaks rather than commas:
```
Installed
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179498720
I like the idea, but find the list is starting to get a bit confusing (to
see the actual platform names. We need to make sure the platform names a very
easy to
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-178412993
Thanks for this @aliokan. I've tweaked the commit a bit to store the magic
number in a constant, and I'll merge it.
---
If your project is
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178404256
Ah sorry @fattalgazi - I just fixed this and missed that you already had a
PR open. Fixed now in #161.
---
If your project is set up for it, you can
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/161
CB-10502 Fix camera plugin exception in Chrome when click capture.
The `MediaStream.stop()` method has been deprecated as of Chrome 47. We
were using it, and it was generating an
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240
I've taken a look too, and I agree this seems the best approach. Changes
look good to me, except I agree with your comment @sgrebnov that we should u
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/132#issuecomment-162867249
Generally looks fine to me apart from some misplaced "Android" references I
mention inline. Also, it concerns me that `ConsoleLogger` is duplica
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708869
Moved `isChrome` to be browser specific (we only ever call it either from
browser specific code, or after verifying we're running on browser pla
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708771
@omefire - no, I don't think so. I think feature detection is more
appropriate for the intent of this code. Also, my goal wasn't to change the
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46821107
--- Diff: www/isChrome.js ---
@@ -0,0 +1,26 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162383919
Hey @stevengill, could you take a look at this? I just want to verify this
doesn't do anything to screw with `uglify` (which is the change that
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/152
CB-10023 Fix "proxy not found error" on Chrome.
We shouldn't be patching `requestFileSystem` and `resolveLocalFileSystem`
on Chrome. Recent change broke the existing
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/349#issuecomment-161826181
Thanks - LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/349#discussion_r46494465
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
}).join
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/294#discussion_r46228904
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
}).join
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-android/pull/230#issuecomment-157950628
Just an FYI - The node 4.x.x dependency in `node-parser` has just been
fixed and the fix released, so we can move to `0.3.1` safely if ever there is a
reason
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/344#issuecomment-157203021
Note the JIRA number in the title is incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/145#discussion_r43565677
--- Diff: src/android/DirectoryManager.java ---
@@ -56,45 +56,46 @@ public static boolean testFileExists(String name
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152612090
Are people likely to be doing a plugin search from a gulp script?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-android/pull/237#issuecomment-152359281
@stevengill - can you take a look at this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-android/pull/237
CB-9909 Shouldn't escape spaces in paths on Windows.
Instead on windows just wrap in quotes. Note that this value is only never
executed directly - just displayed to the user. But
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-152242161
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/332#discussion_r43331295
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -244,19 +307,26 @@ describe('(save flag)', function () {
conso
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-152024899
@stevengill - ultimately, the point of these tests is to test the `--save`
feature, so going forward I don't think we want them to be at risk of being
brok
Github user TimBarham closed the pull request at:
https://github.com/apache/cordova-lib/pull/333
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/332#discussion_r43292467
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -244,19 +307,26 @@ describe('(save flag)', function () {
conso
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/333#issuecomment-151920060
Yep, saw that PR just after I sent this one :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-151918673
So Alex - what was the underlying problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/333
Dummy PR to trigger a test run - don't merge :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib tb
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150308646
Works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-android/pull/230#issuecomment-149915429
:+1: (to getting this change in, and to then creating tests to guard
against this going forwards).
---
If your project is set up for it, you can reply to
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-android/pull/230#issuecomment-149905998
Looks fine to me, as long as we're sure the older version doesn't lose any
functionality we need.
---
If your project is set up for it, you ca
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/327#issuecomment-149737583
Thanks for taking a look, @vladimir-kotikov.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42565419
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox'
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42565322
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox'
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42562761
--- Diff: cordova-serve/src/browser.js ---
@@ -17,9 +17,15 @@
under the License.
*/
-var exec = require('./exec')
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/327
On Windows, verify browsers installed before launching.
Do this to avoid dialog that pops up on Windows if browser is not
installed, and provide more meaningful error messages.
You can
1 - 100 of 312 matches
Mail list logo
