Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193146
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193116
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
--- End diff --
Don&#
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/99#issuecomment-41637291
LGTM! Thanks! I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/151#issuecomment-41190420
Unless there are functions that will be used by other files as well, keep
it in one file.
---
If your project is set up for it, you can reply to this email and
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/151#issuecomment-41184231
Merged. I did a clean-up commit along with it that you can see here:
https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=blobdiff;f=src/info.js;h
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41180908
Thanks for the patch. I've created an issue for this:
https://issues.apache.org/jira/browse/CB-6501
---
If your project is set up for it, you can rep
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/116#issuecomment-41177828
Support for this just landed! woohoo!
https://issues.apache.org/jira/browse/CB-5093
Will be out in the next release.
---
If your project is set up for
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/11#issuecomment-40600943
Thanks for the pull request. I've had a look at it and think it looks good.
Before we can merge it though, you need to sign Apache's Contribut
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugman/pull/72#issuecomment-39983493
I did merge this in, but forgot to close it (@Josh, can you close it?).
Mark - sounds like that's a better approach. Could you make the change?
-
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-39528432
Seems like a simple expectation, but AFAIK, all UIWebViews have a shared
cache & cookie jar. We could probably clear them out for a white
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11278577
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260509
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260484
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260409
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260263
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260290
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260238
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260194
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260150
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/155#issuecomment-39284881
Seems I accidentally pushed the commit in its previous state (whoops!).
Just played around and found that it was actually the
windowsVerbatimArguments flag
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/149#issuecomment-39137390
I've merged this in now, thanks!
Not exactly sure how you went about rebasing, but normally a rebase
shouldn't result in an extra commit. &
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/155#discussion_r11130975
--- Diff: src/superspawn.js ---
@@ -60,11 +60,11 @@ exports.spawn = function(cmd, args, opts) {
var spawnOpts = {};
var d = Q.defer
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/146#discussion_r11128647
--- Diff: platforms.js ---
@@ -39,12 +41,14 @@ module.exports = {
version: '3.4.0'
},
'wp7' : {
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugman/pull/31#issuecomment-38963141
Going to close this given the work that's gone on since. Open a new one to
continue on.
---
If your project is set up for it, you can reply to this emai
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/146#discussion_r11080870
--- Diff: platforms.js ---
@@ -39,12 +41,14 @@ module.exports = {
version: '3.4.0'
},
'wp7' : {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11080438
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11080370
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080227
--- Diff: src/info.js ---
@@ -30,105 +29,80 @@ var cordova_util = require('./util'),
Outputs to a file
*/
module.exports
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080089
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080035
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r1107
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080008
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/149#issuecomment-38949437
I think the changes here look good. Not sure why it was never merged. Just
tried applying them though, and there were too many merge conflicts. Would you
be able
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/139#issuecomment-37418719
Thanks for tracking this down. I think a better fix is to just delete the
fail() clause. I tested that doing so shows the stacktrace, and so have gone
with that
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/138#issuecomment-37417943
Thanks for the fix! I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/18#issuecomment-37331345
I don't see this error/warning using Xcode 5.0.2. What version do you see
this in?
---
If your project is set up for it, you can reply to
301 - 336 of 336 matches
Mail list logo
