[GitHub] cordova-plugin-inappbrowser pull request: Enable thirdparty cookie...

2016-05-12 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/165#issuecomment-218823372 Looks like this is enabling them by default, right? Being an app owner I'd prefer to be in control of that. --- If your project is s

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2015-12-30 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-lib/pull/360#issuecomment-168031644 Noticed that uninstall suffers from the same issue. I'll address that at some point in the future (if I find the time and need). --- If your project i

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2015-12-30 Thread bradleyjames
GitHub user bradleyjames opened a pull request: https://github.com/apache/cordova-lib/pull/360 [CB-10274] Make www directory the default for plugman. New patch that addresses comments made here: https://github.com/apache/cordova-lib/pull/359. You can merge this pull request into a

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-lib/pull/359#issuecomment-168009298 Seems like that will change the default install location for plugman (when not called from the cordova CLI) from platform_www to www. Is that what you&#x

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread bradleyjames
Github user bradleyjames commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/359#discussion_r48605088 --- Diff: cordova-lib/src/plugman/install.js --- @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, project_dir

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-29 Thread bradleyjames
GitHub user bradleyjames opened a pull request: https://github.com/apache/cordova-lib/pull/359 CB-10274 Honor --www parameter in plugman. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bradleyjames/cordova-lib master

[GitHub] cordova-lib pull request:

2015-12-29 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c#commitcomment-15193029 In cordova-lib/src/plugman/install.js: In cordova-lib/src/plugman/install.js on line 573: This breaks plugman&#

[GitHub] cordova-docs pull request: Updates to the install and uninstall do...

2015-12-22 Thread bradleyjames
GitHub user bradleyjames opened a pull request: https://github.com/apache/cordova-docs/pull/444 Updates to the install and uninstall documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/bradleyjames/cordova-docs patch-1