Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/29#issuecomment-58221160
@swypych I can't find your CLA
https://people.apache.org/committer-index.html
---
If your project is set up for it, you can reply to
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/29#discussion_r18533890
--- Diff: doc/index.md ---
@@ -85,6 +85,9 @@ function, which is typically less customizable.
Both native-blocking
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/177#issuecomment-57220347
r+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-lib/pull/94
CB-5390 Uninstall - recursively remove dependencies of dependencies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-lib/pull/88
CB-7572 Serve - respond with 304 when resource not modified
This will prevent a lot of unnecessary network traffic, especially in
situations such as a list control which has the same icon
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/25#issuecomment-56073876
merged. @lyonplus please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/23#issuecomment-55592781
This has been merged. @lyonplus please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-54486943
Merged
@jkeshavarzi can you please close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/176#issuecomment-53574787
Is anything actually broken?
AFAIK these environment variables are only used for bundling of binaries
which would never be distributed via NPM
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/28#issuecomment-52085499
The documentation states that these events are not supported on BB10:
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/doc
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/18#discussion_r15601559
--- Diff: src/blackberry10/native/src/globalization_ndk.hpp ---
@@ -0,0 +1,63 @@
+/*
+* Copyright 2013 Research In Motion
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/18#discussion_r15601513
--- Diff: src/blackberry10/native/src/globalization_ndk.cpp ---
@@ -0,0 +1,1167 @@
+/*
+ * Copyright 2013 Research In
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/18#discussion_r15601501
--- Diff: src/blackberry10/native/src/globalization_js.hpp ---
@@ -0,0 +1,41 @@
+/*
+* Copyright 2013 Research In Motion
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/18#discussion_r15601481
--- Diff: src/blackberry10/native/src/globalization_js.cpp ---
@@ -0,0 +1,165 @@
+/*
+ * Copyright 2013 Research In Motion
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/18#discussion_r15601423
--- Diff: src/blackberry10/native/readme.txt ---
@@ -0,0 +1,406 @@
+Template for BlackBerry 10 Cordova Plugins
--- End diff
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/18
BB10 implementation
Opening this for visibility. It needs to be squashed and .so files
re-generated from the latest commit.
You can merge this pull request into a Git
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/171#issuecomment-50357274
@jkeshavarzi thanks for the pull request, but please close it for now
As we discussed with @jsoref, users of other platforms have run into
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/63
[BlackBerry10] Add file system paths & fix tests
cc @jengee @jsoref
1f21e3b3 should be tested on Android 2.3 before merging
You can merge this pull request into a
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/12
Minor doc corrections
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/blackberry-webworks/cordova-plugin-battery
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/161#issuecomment-45795283
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/160#issuecomment-4544
r+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/159#issuecomment-44660326
I hadn't noticed the change in the parent issue. I'll update it.
---
If your project is set up for it, you can reply to this email and have
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/159
CB-5654 Log 'native' Cordova version during framework bootstrap
cc @jsoref @jkeshavarzi
You can merge this pull request into a Git repository by running:
$ git
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/158#issuecomment-44270826
r+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/157#issuecomment-43800587
r+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-medic/pull/5#issuecomment-43768171
Merged here:
https://git-wip-us.apache.org/repos/asf?p=cordova-medic.git;a=commit;h=dccca3f474835aa3e1cfd1fbfb51b80cf5403e55
@dylin please close
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/157#issuecomment-43763122
Could you please add a JIRA reference to the commit?
Are there any tests for parseUri?
---
If your project is set up for it, you can reply to
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/30#issuecomment-42999768
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-docs/pull/201#issuecomment-42549099
This was already merged:
https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=commit;h=51a296ae367b01a480defba5bf818b2cff7cb790
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/30
CB-6682 Move WP8 proxy to correct platform element
@purplecabbage can you review this please?
This was being loaded by BB10 causing many contacts tests to fail.
You
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42864822
I agree with @BBosman and @shazron. This should be merged.
@martincgg Thanks for pointing out your pull request. Josh tells me it
wasn't m
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42867574
@martincgg got it
I applied your fix here:
https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=commit;h
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-cli/pull/158#issuecomment-42867675
I applied this change to cordova-lib since this is where the parser now
lives
https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=commit;h
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42846592
This works to get past check_reqs. Does the same thing need to be applied
to wp8 and windows8?
The actual create command fails. It's
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/44
CB-3440 [BlackBerry10] Proxy based implementation
This is a re-write of the file plugin for BB10. Rather than clobbering the
window objects this utilizes the exec proxy to
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/155
CB-6522 Disallow space in target name
- Update target add command
- Update auto-detected target
You can merge this pull request into a Git repository by running:
$ git
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-medic/pull/5#issuecomment-41285883
This is looking good, but it should wait for test completion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-cli/pull/161#issuecomment-40364475
@sgrebnov Thanks for testing. I've merged this in. Feel free to issue a
pull request for your points which seem valid to me. Josh is on holiday until
next
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/154#discussion_r11352355
--- Diff: blackberry10/bin/templates/project/cordova/lib/target-utils.js ---
@@ -254,16 +254,15 @@ _self
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/154#issuecomment-39742708
@jsoref r?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/154
[BlackBerry10] Improvements to device deployment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-blackberry
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-docs/pull/201#issuecomment-39448737
BB10 should be brought back in including the link to the best practices
page. The platform config.xml supports icon element. CLI needs to be updated to
filter
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/152
CB-6346 - Add node_modules to source control
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-blackberry
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-cli/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38387520
Thanks a lot for pointing this out. When manually adding a simulator using
the "blackberry10/bin/target add" command, it is added with "
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38322436
Ok, thanks for clarifying.
If that is the case, you'll need to add support for emulator as well as
also supporting simulator. The bug is r
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38304361
https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/lib/target.js#L60
---
If your project is set up for it, you can reply to this
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38304245
I don't understand the reason for this and it will break all existing users
which have simulators stored in their blackberry10.json
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/7#issuecomment-37645634
This has already been merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/150#issuecomment-37544828
r+, tested on 3.4.0-0.1.3 with multiple platforms added
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/16#issuecomment-37531680
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=bd6af45
---
If your project is set up for it, you can reply to
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/17#issuecomment-37432529
Merged here:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;a=commit;h=5393a28191e8f53fb073f05c40a6133f68685274
---
If your
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/15#issuecomment-37432129
Merged here:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media-capture.git;a=commit;h=bf360f0eca5c0c04af620d02c6d4ebbd78b14f49
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/16
CB-6016 [BlackBerry10] Add audio capture capability
@rcruz r?
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com
59 matches
Mail list logo
