[GitHub] cordova-ios pull request: CB-9883

2015-11-11 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/179#issuecomment-155768503 That looks great to me! honestly i dont know how i felt about the idea of dynamically injecting a script... call me old school ;) Thanks guys a ton for

[GitHub] cordova-ios pull request: CB-9883

2015-11-10 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/179#issuecomment-155608082 I don't know if this was the path intended, but the new changes break the falling back to UIWebView since simply including the WKWebview clobbers `cordova

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-25 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/174#issuecomment-150918800 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...

2015-10-20 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-android/pull/223#issuecomment-149679498 :+1: thanks a ton @infil00p ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-splashscreen pull request: iOS : Fix for screen not...

2015-10-05 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/56#issuecomment-145501931 any decision on this? would be a real plus to have back in the plugin! --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-05 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-145500663 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-wp8 pull request: Attempted to cleanup readme for a noob

2014-07-18 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-wp8/pull/13#issuecomment-49440313 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature