[GitHub] cordova-plugin-inappbrowser issue #231: CB-13028 (CI) Browser builds on Trav...

2017-07-28 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/231 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-splashscreen issue #74: CB-8396 Add AutoHideSplashScreen logi...

2017-07-17 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/74 @alanhg can you add the reproduce steps and the details of the issue you are experiencing? How were you adding the plugin? Which cordova versions did you use? --- If your

[GitHub] cordova-plugin-file-transfer issue #141: CB-10974 Cordova file transfer Cont...

2017-04-05 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/141 @cooperjbrandon what is your plugin version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request #690: Cordova Screen Orientation Plugin Blog

2017-03-31 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/690#discussion_r109208194 --- Diff: www/_posts/2017-03-30-screen-orientation-plugin.md --- @@ -0,0 +1,70 @@ +--- +layout: post +author: +name: Vishal Mishra

[GitHub] cordova-lib pull request #480: CB-11687 platform-specific plugin prepare hoo...

2017-03-10 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-lib/pull/480 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #477: CB-11688 Fix platform.spec timeout errors

2017-03-10 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-lib/pull/477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser pull request #214: CB-11248 InAppBrowser no focu...

2017-02-28 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/214 CB-11248 InAppBrowser no focus on input text fields ### Platforms affected Android ### What does this PR do? Resets the focus to avoid

[GitHub] cordova-windows pull request #228: CB-12499 UWP: Dependent external librarie...

2017-02-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/228 CB-12499 UWP: Dependent external libraries specified as resource-file… … not being referenced in Release mode ### Platforms affected Windows ### What

RE: [DISCUSS] Cordova-Windows Release

2017-02-10 Thread daserge
To verify you have the updated tag in your local clone, doing a "git rev-parse 5.0.0" in cordova-windows should reply with " 75d7bcf01e830191a9b259ca376f124fba16f9d1". If it is wrong, do "git fetch --tags". -Original Message- From: dase...@apache.org [mailto:dase...@apache.org] Sent:

RE: [Vote] 5.0.0 Windows Release

2017-02-10 Thread daserge
The vote has now closed. The results are: Positive Binding Votes: 4 Sergey Shakhnazarov Alexander Sorokin Vladimir Kotikov Karen Tran The vote has passed. -Original Message- From: Karen Tran [mailto:ktop...@gmail.com] Sent: Thursday, February 9, 2017 18:06 To: dev@cordova.apache.org

[Vote] 5.0.0 Windows Release

2017-02-08 Thread daserge
Please review and vote on this 5.0.0 Windows Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12404 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12404/

[GitHub] cordova-windows pull request #227: CB-12298 [Windows] bundle.appxupload not ...

2017-02-06 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/227 CB-12298 [Windows] bundle.appxupload not generated for Windows 10 target Generate appxupload for non-bundle builds as well ### Checklist - [x] [Reported an issue](http

[GitHub] cordova-windows pull request #226: CB-12416 (Windows) Built bundles are misp...

2017-02-03 Thread daserge
GitHub user daserge reopened a pull request: https://github.com/apache/cordova-windows/pull/226 CB-12416 (Windows) Built bundles are misplaced when building for mult… …iple archs ### Platforms affected Windows ### What does this PR do

[GitHub] cordova-windows pull request #226: CB-12416 (Windows) Built bundles are misp...

2017-02-02 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-windows/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-windows pull request #226: CB-12416 (Windows) Built bundles are misp...

2017-02-02 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/226 CB-12416 (Windows) Built bundles are misplaced when building for mult… …iple archs ### Platforms affected Windows ### What does this PR do? Override

[GitHub] cordova-windows issue #225: CB-12415 Windows build fails if start page is mi...

2017-02-02 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/225 Do not merge yet, on discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-windows pull request #225: CB-12415 Windows build fails if start pag...

2017-02-02 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/225 CB-12415 Windows build fails if start page is missing ### Platforms affected Windows ### What does this PR do? Continue the build if the start page is missing

RE: [DISCUSS] Cordova-Windows Release

2017-02-01 Thread daserge
Hi guys, I just want to update the status on Windows release - we've found some regressions so I'll start the vote process as soon as we fix and push them. Please let me know if you have any questions or considerations. Best regards, Sergey Shakhnazarov, Akvelon developer. -Original

[GitHub] cordova-docs pull request #681: CB-12404 Add windows@5.0.0 release blog post

2017-01-28 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/681 CB-12404 Add windows@5.0.0 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-docs CB-12404 Alternatively

[GitHub] cordova-windows pull request #224: Added missing license to PluginInfo.js

2017-01-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/224 Added missing license to PluginInfo.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-windows missing-license

[GitHub] cordova-docs pull request #672: CB-12099 [Android] Documented SplashScreenBa...

2017-01-27 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-docs/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android issue #354: CB-12099 (android) SplashScreen Screen Flicker

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-android/pull/354 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move splashscreen

[GitHub] cordova-plugin-splashscreen issue #120: CB-11602 Splashscreen plugin receive...

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/120 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move

[GitHub] cordova-docs issue #672: CB-12099 [Android] Documented SplashScreenBackgroun...

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-docs/pull/672 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move splashscreen

[GitHub] cordova-plugin-splashscreen issue #121: CB-12099 (android) SplashScreen Scre...

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/121 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move

[GitHub] cordova-plugin-splashscreen pull request #121: CB-12099 (android) SplashScre...

2017-01-27 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-android pull request #354: CB-12099 (android) SplashScreen Screen Fl...

2017-01-27 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-android/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen pull request #120: CB-11602 Splashscreen plugin ...

2017-01-27 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-android pull request #353: CB-11602: (android) Adds onRestart event ...

2017-01-27 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-android/pull/353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support

2017-01-27 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-android/pull/353 Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move splashscreen

[GitHub] cordova-windows issue #223: Remove duplicate logic after upgrading cordova-c...

2017-01-26 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/223 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...

2017-01-25 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/515#discussion_r97741534 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider

[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...

2017-01-24 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/515 CB-12383 Fix cordova_plugins metadata definition Define parent object first [Jira issue](https://issues.apache.org/jira/browse/CB-12383) ### Platforms affected Tested

RE: CB-11602: (android) Adds onRestart event support

2017-01-20 Thread daserge
Hello, There's a related issue marked as WontFix [1][2] but as far as I understand it does not apply to the SplashScreen plugin as it is initialized on startup (via ). So the question is - should we add onRestart as it is not fundamentally different from onStart, which is supported? Or is

[GitHub] cordova-plugin-media-capture pull request #74: CB-12353 Corrected merges usa...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/74 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-file-transfer pull request #172: CB-12353 Corrected merges us...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/172 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent

[GitHub] cordova-plugin-media pull request #125: CB-12353 Corrected merges usage in p...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-media/pull/125 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-file pull request #200: CB-12353 Corrected merges usage in pl...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/200 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-dialogs pull request #90: CB-12353 Corrected merges usage in ...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/90 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-device-orientation pull request #32: CB-12353 Corrected merge...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/32 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent

[GitHub] cordova-plugin-device-motion pull request #49: CB-12353 Corrected merges usa...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/49 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-device pull request #59: CB-12353 Corrected merges usage in p...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-device/pull/59 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-contacts pull request #147: CB-12353 Corrected merges usage i...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/147 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use `runs` instead of `merges` to prevent proxy

[GitHub] cordova-plugin-camera pull request #249: CB-12353 Corrected merges usage in ...

2017-01-19 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/249 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use runs instead of merges to prevent proxy

[GitHub] cordova-plugin-splashscreen pull request #122: CB-12353 Corrected merges usa...

2017-01-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/122 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows ### What does this PR do? Use runs instead of merges to prevent proxy

[GitHub] cordova-plugin-inappbrowser pull request #208: CB-12353 Corrected merges usa...

2017-01-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/208 CB-12353 Corrected merges usage in plugin.xml ### Platforms affected Windows, Browser, FirefoxOS ### What does this PR do? Use `runs` instead

[GitHub] cordova-plugin-inappbrowser pull request #207: CB-12364 [Windows] Inappbrows...

2017-01-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/207 CB-12364 [Windows] Inappbrowser inject file manual tests are not working ### Platforms affected Windows ### What does this PR do? - Updates ms-appx

[GitHub] cordova-windows issue #213: CB-12163 Make resource-file copy files again

2017-01-16 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/213 @ktop what is the status of this PR? Is it ready for merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

RE: [DISCUSS] tools release

2017-01-16 Thread daserge
Hi guys, What is the status of Tools Release? We can handle it as we need to release Windows platform with cordova-common updates but we need to know the exact list of things to be included in it. Please let me know if you have any questions or considerations. Best regards, Sergey

[GitHub] cordova-windows pull request #220: CB-12298 [Windows] bundle.appxupload not ...

2017-01-11 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/220 CB-12298 [Windows] bundle.appxupload not generated for Windows 10 target ### Platforms affected Windows ### What does this PR do? Adds a MSBuild flag to get

[GitHub] cordova-docs pull request #674: CB-8486 Corrected the docs on signing

2017-01-11 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/674 CB-8486 Corrected the docs on signing ### Platforms affected Windows ### What does this PR do? - Certificate Thumbprint was being extracted from wrong path

[GitHub] cordova-docs pull request #672: CB-12099 [Android] Documented SplashScreenBa...

2016-12-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/672 CB-12099 [Android] Documented SplashScreenBackgroundColor ### Platforms affected Android ### What does this PR do? Documented SplashScreenBackgroundColor

[GitHub] cordova-plugin-splashscreen pull request #121: CB-12099 (android) SplashScre...

2016-12-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/121 CB-12099 (android) SplashScreen Screen Flicker ### Platforms affected Android ### What does this PR do? Documented new SplashScreenBackgroundColor

[GitHub] cordova-android pull request #354: CB-12099 (android) SplashScreen Screen Fl...

2016-12-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/354 CB-12099 (android) SplashScreen Screen Flicker ### Platforms affected Android ### What does this PR do? Introduced new SplashScreenBackgroundColor preference

[GitHub] cordova-plugin-splashscreen pull request #120: CB-11602 Splashscreen plugin ...

2016-12-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/120 CB-11602 Splashscreen plugin receives onPause and hides ### Platforms affected Android ### What does this PR do? Save splashscreen state and restore

[GitHub] cordova-android pull request #353: CB-11602: (android) Adds onRestart event ...

2016-12-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/353 CB-11602: (android) Adds onRestart event support ### Platforms affected Android ### What does this PR do? Adds onRestart event support ### What testing

[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...

2016-12-21 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/219#discussion_r93464493 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -304,6 +309,47 @@ describe('windows project handler', function

[GitHub] cordova-windows pull request #219: CB-12189: Add support for WinMD and DLL c...

2016-12-21 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/219#discussion_r93460566 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -115,6 +115,33 @@ function PluginInfo(dirname) { var configFiles

[GitHub] cordova-windows issue #218: CB-12238 [Windows] Colorize titlebar to match sp...

2016-12-20 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/218 @vladimir-kotikov, can I merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows pull request #218: CB-12238 [Windows] Colorize titlebar to m...

2016-12-19 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/218#discussion_r93060350 --- Diff: cordova-js-src/splashscreen.js --- @@ -203,10 +212,30 @@ function enableUserInteraction() { document.body.style['-ms-content

[GitHub] cordova-windows issue #216: CB-11177 SplashScreen gets shifted on Windows de...

2016-12-19 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/216 Merged, thanks for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #216: CB-11177 SplashScreen gets shifted on Windows de...

2016-12-19 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/216 @vladimir-kotikov, is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

2016-12-16 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/217 Sure 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2016-12-15 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 @jcesarmobile, @infil00p, @kerrishotts could you please also take a look if you have a chance? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2016-12-15 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 @nbabanov thanks for the contribution and sorry it took so long to review this. Could you please describe your scenario - I could not reproduce the issue with latest

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

2016-12-14 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92402062 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

2016-12-14 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92389331 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType, buildarch

[GitHub] cordova-windows pull request #218: CB-12238 [Windows] Colorize titlebar to m...

2016-12-13 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/218 CB-12238 [Windows] Colorize titlebar to match splash bg color ### Platforms affected Windows ### What does this PR do? Colorize titlebar to match splash

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

2016-12-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/216 CB-11177 SplashScreen gets shifted on Windows devices with soft navbar ### Platforms affected Windows ### What does this PR do? Fixes splash jump bug (affected

[GitHub] cordova-windows pull request #215: CB-12193 cordova.js crashes windows app i...

2016-12-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/215 CB-12193 cordova.js crashes windows app if there is no CoreWindow ### Platforms affected Windows ### What does this PR do? Don't subscribe to WinRT lifecycle

[GitHub] cordova-windows issue #213: CB-12163 Make resource-file copy files again

2016-12-07 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/213 @ktop, could you please comment on @timbarham message? http://markmail.org/message/2fproqgmbrc2gxpz Is this a breaking change? --- If your project is set up for it, you can reply

[GitHub] cordova-android pull request #351: CB-12159 Android: Keystore password promp...

2016-12-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/351 CB-12159 Android: Keystore password prompt won't show up ### Platforms affected Android ### What does this PR do? Makes password prompt to work for newer Gradle

[GitHub] cordova-plugin-file-transfer issue #170: CB-12154 file-transfer progressEven...

2016-11-30 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/170 @jcesarmobile, @shazron, @stevengill could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-file-transfer issue #169: CB-10974 Cordova file transfer Cont...

2016-11-30 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/169 @jcesarmobile, @shazron, @stevengill could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

2016-11-29 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov addressed, thanks! It is good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r90007897 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

2016-11-29 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov could you please take a look again? I've also added a fix for [CB-12192 - No SplashScreen on Windows when content.src is subpage](https://issues.apache.org/jira/browse

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

2016-11-28 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov thank you for the review! I've addressed the notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-28 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89792140 --- Diff: cordova-js-src/splashscreen.js --- @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-28 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89789288 --- Diff: template/cordova/lib/prepare.js --- @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) { events.emit

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-28 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89770853 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config) { }; } +/** Checks

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

2016-11-28 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89769817 --- Diff: template/CordovaApp.Phone.jsproj --- @@ -79,7 +79,9 @@ Designer - + --- End diff

[GitHub] cordova-plugin-file-transfer pull request #170: CB-12154 file-transfer progr...

2016-11-25 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/170 CB-12154 file-transfer progressEvent.total = -1 on iOS ### Platforms affected iOS ### What does this PR do? Reverts logic for not setting `Content

[GitHub] cordova-plugin-splashscreen pull request #119: CB-9287 Not enough Icons and ...

2016-11-25 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/119 CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Window… …s Phone 8.1 ### Platforms affected Windows ### What does this PR do

[GitHub] cordova-plugin-file-transfer pull request #169: CB-10974 Cordova file transf...

2016-11-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/169 CB-10974 Cordova file transfer Content-Length header problem ### Platforms affected Android ### What does this PR do? Don't force chunkedMode=true

[GitHub] cordova-plugin-splashscreen pull request #118: CB-11751 'extendedSplashScree...

2016-11-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/118 CB-11751 'extendedSplashScreen' is undefined ### Platforms affected ### What does this PR do? [Jira issue](https://issues.apache.org/jira/browse/CB

[GitHub] cordova-windows pull request #211: CB-11751 'extendedSplashScreen' is undefi...

2016-11-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/211 CB-11751 'extendedSplashScreen' is undefined ### What does this PR do? [Jira issue](https://issues.apache.org/jira/browse/CB-11751) Replaced element implicit calls by id

[GitHub] cordova-windows issue #207: Move windows-specific logic from cordova-common

2016-11-13 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/207 Also, @matrosov-nikita could you please create a Jira issue for tracking (http://issues.cordova.io), rename the PR title and add the commit prefix? --- If your project is set up

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-11 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87596875 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo = require('cordova

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-11 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87598394 --- Diff: spec/unit/ConfigChanges.spec.js --- @@ -161,3 +165,40 @@ describe('Capabilities within package.windows.appxmanifest', function

[GitHub] cordova-windows issue #209: CB-12124: Make available device capabilities in ...

2016-11-08 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/209 Merged, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-battery-status issue #42: CB-8929 Use PowerManager to get bat...

2016-11-08 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/42 @vladimir-kotikov LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows issue #209: CB-12124: Make available device capabilities in ...

2016-11-08 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/209 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-battery-status issue #42: CB-8929 Use PowerManager to get bat...

2016-11-08 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/42 Tested and it works good on all targets (Win 10 desktop, Win 10 Mobile, Windows Phone 8.1). LGTM apart the comments. --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-battery-status pull request #42: CB-8929 Use PowerManager to ...

2016-11-08 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/42#discussion_r86942697 --- Diff: src/windows/BatteryProxy.js --- @@ -19,7 +19,38 @@ * */ -/* global WinJS, BatteryStatus

[GitHub] cordova-docs issue #659: CB-11860 Documented codeSignIdentity usage

2016-11-03 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-docs/pull/659 @dpogue, @shazron could you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request #659: CB-11860 Documented codeSignIdentity usage

2016-11-03 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/659 CB-11860 Documented codeSignIdentity usage ### Platforms affected iOS ### What does this PR do? Documented codeSignIdentity usage, updated build.json example

[GitHub] cordova-plugin-splashscreen issue #105: fix bug CB-11422 ios SplashScreen pl...

2016-11-03 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/105 @jonathanli2, thanks for the contribution! Is there any way/code to reproduce the issue? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-windows pull request #208: CB-12071 Fix for CB-11825 breaks usage of...

2016-11-01 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/208 CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova … …Windows ### Platforms affected Windows ### What does this PR do? Adds a test

[GitHub] cordova-docs pull request #658: CB-11825 Document VS quirk causing DEP2100 e...

2016-11-01 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/658 CB-11825 Document VS quirk causing DEP2100 error on Windows Phone/Win… …dows Mobile ### Platforms affected Windows ### What does this PR do? Document VS

  1   2   3   4   5   6   7   8   >