[GitHub] cordova-docs issue #729: Fixed up 'deployment' docs in README.md.

2017-09-12 Thread dblotsky
Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/729 @stevesgill @audreyso @shazron please review when you have a moment. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] cordova-docs pull request #729: Fixed up 'deployment' docs in README.md.

2017-09-12 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/729 Fixed up 'deployment' docs in README.md. - Restored `gulp build` command in lieu of `npm run serve` command. - Tested and fixed suggested deployment commands. - Removed redundant

[GitHub] cordova-docs issue #443: Update index.md

2017-03-23 Thread dblotsky
Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/443 @purplecabbage that indeed was what I said in Russian. :) Thanks for cleaning up the PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs issue #640: Make more comprehensible the french documentation

2016-10-05 Thread dblotsky
Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/640 Here's the direct Crowdin link: https://crowdin.com/translate/cordova/12/en-fr. You'll need to create a Crowdin account to edit it though. --- If your project is set up for it, you can

[GitHub] cordova-docs issue #640: Make more comprehensible the french documentation

2016-10-04 Thread dblotsky
Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/640 The changes seem fine, but they should be made in crowdin. The changes made in this PR would get overwritten by translation builds. --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request #612: CB-11412 Added docs for template use and cre...

2016-08-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/612#discussion_r73905774 --- Diff: www/_data/redirects.yml --- @@ -348,6 +348,7 @@ docs-global: "guide_appdev_privacy_index.md.html": "guide/appdev/pri

[GitHub] cordova-docs pull request #613: CB-11477 Add a page about nightly builds

2016-08-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/613#discussion_r73905131 --- Diff: www/contribute/index.html --- @@ -22,6 +22,7 @@ Join the Dev mailing list and send a brief introduction of yourself

[GitHub] cordova-docs pull request: CB-11157 Fixing anchor generation

2016-05-21 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/604 CB-11157 Fixing anchor generation Adding colons and semicolons to excluded characters in fragment creation. Verified with GitHub's anchor-making algorithm. You can merge this pull request

[GitHub] cordova-docs pull request: CB-11157 Fixing anchor generation

2016-05-21 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/604#issuecomment-220802999 @riknoll @nikhilkh please review when you have a moment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: CB-11127 Improving internal linking

2016-04-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/584#discussion_r60784540 --- Diff: www/.htaccess --- @@ -61,14 +63,14 @@ RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/latest$ {{site.baseurl}}/docs/$1/latest/ [R

[GitHub] cordova-docs pull request: CB-11127 Improving internal linking

2016-04-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/584#discussion_r60784438 --- Diff: www/.htaccess --- @@ -61,14 +63,14 @@ RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/latest$ {{site.baseurl}}/docs/$1/latest/ [R

[GitHub] cordova-docs pull request: CB-11127 Improving internal linking

2016-04-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/584#discussion_r60783856 --- Diff: tools/bin/gen_pages_dict.js --- @@ -0,0 +1,120 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] cordova-docs pull request: CB-11127 Improving internal linking

2016-04-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/584#discussion_r60783503 --- Diff: www/.htaccess --- @@ -61,14 +63,14 @@ RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/latest$ {{site.baseurl}}/docs/$1/latest/ [R

[GitHub] cordova-docs pull request: CB-11127 Improving internal linking

2016-04-22 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/584#issuecomment-213545334 @riknoll @rakatyal please also give this a look when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: CB-11127 Improving internal linking

2016-04-21 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/584 CB-11127 Improving internal linking Relevant changes: - added a new data file, `all-pages.yml`, which stores a list of valid links on the site - version dropdowns and out-of-date

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-21 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60677936 --- Diff: www/static/js/algolia.js --- @@ -0,0 +1,21 @@ +--- +--- + +{% if page.version %} +{% assign version = page.version

[GitHub] cordova-docs pull request: CB-11126 ToC Generation Refactor

2016-04-20 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

2016-04-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/575#issuecomment-212685445 @riknoll please give this another look. It's now using the changes from [CB-11126][1]. [1]: https://issues.apache.org/jira/browse/CB-11126 --- If your

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-20 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/583#discussion_r60496008 --- Diff: tools/bin/toc.js --- @@ -17,123 +17,57 @@ "use strict"; -var fs = require("fs"); -var

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-20 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60495766 --- Diff: lib/utils/utilities.js --- @@ -0,0 +1,123 @@ +#!/usr/bin/env node + +var shelljs = require('shelljs'); +var verbose

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-19 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/583 ToC Generation Refactor **Note**: this PR is easier to review one commit at a time, and the commit messages roughly describe each change. Changes: - now `*-src.yml` files

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/583#issuecomment-212213980 @riknoll @rakatyal @nikhilkh please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60334146 --- Diff: www/static/css-src/main.scss --- @@ -194,6 +194,23 @@ code { color: #00; } +/* algolia search formatting

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/581#issuecomment-212179026 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60329456 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329201 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,20 @@ --- - +{% if page.language %} +{% assign language

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329126 --- Diff: www/_includes/header.html --- @@ -29,18 +29,24 @@ Get Started

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328845 --- Diff: www/_includes/algolia.html --- @@ -0,0 +1,14 @@ +{% if page.version %} +{% assign version = page.version %} +{% else

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328800 --- Diff: conf/_config.yml --- @@ -81,3 +81,5 @@ kramdown: # exclude these directories from the build exclude: - static/css-src

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60314159 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60313932 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60313371 --- Diff: www/static/css-src/main.scss --- @@ -194,6 +194,23 @@ code { color: #00; } +/* algolia search formatting

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60313002 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60312938 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60312014 --- Diff: www/_includes/head.html --- @@ -18,6 +18,9 @@ {% endif %} + +https://cdn.jsdelivr.net

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60307151 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59638892 --- Diff: lib/paramedic.js --- @@ -105,10 +116,23 @@ ParamedicRunner.prototype.checkPlatformRequirements = function() { logger.normal

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59634307 --- Diff: lib/ParamedicPermissions.js --- @@ -0,0 +1,60 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path= require

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59633776 --- Diff: lib/ParamedicPermissions.js --- @@ -0,0 +1,60 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path= require

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59633588 --- Diff: lib/ParamedicPermissions.js --- @@ -0,0 +1,60 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path= require

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59633116 --- Diff: lib/ParamedicKill.js --- @@ -0,0 +1,95 @@ +#!/usr/bin/env node + +"use strict"; + +var shelljs = requir

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59632979 --- Diff: lib/ParamedicConfig.js --- @@ -37,7 +37,12 @@ ParamedicConfig.parseFromArguments = function (argv) { endPort

[GitHub] cordova-medic pull request: Adding configuration files to be used ...

2016-04-13 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/91#issuecomment-209663615 Can these files be `.json` instead of `.js`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r59607181 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https = require

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r59607150 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https = require

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r59606984 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https = require

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r59606834 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https = require

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

2016-04-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r59606560 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https = require

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/86#issuecomment-209098826 @omefire please add both `"iOS Simulator"` and `"Simulator"` to that array. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

2016-04-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/575#issuecomment-208684175 Screenshot: ![capture](https://cloud.githubusercontent.com/assets/405489/14448824/30cbb93c-0021-11e6-8153-e9da514d0532.PNG) --- If your project is set up

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

2016-04-11 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/575 CB-10996 Updating docs index page to match new content. @riknoll @nikhilkh @rakatyal @devgeeks please take a look when you have a moment. You can merge this pull request into a Git

[GitHub] cordova-plugin-camera pull request: Appium tests stability improve...

2016-04-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/202#discussion_r59295343 --- Diff: appium-tests/android/android.spec.js --- @@ -27,52 +28,47 @@ 'use strict'; -var wdHelper = require('../helpers

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-04-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-208597412 @mikaelkindborg I've merged the PR! Please feel free to close it. Somehow my merging script didn't append the "this closes..." part. --- If your proj

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59101538 --- Diff: lib/paramedic.js --- @@ -0,0 +1,231 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59101124 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59094438 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59094353 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,162 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59092104 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r59091985 --- Diff: lib/paramedic.js --- @@ -0,0 +1,232 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request: CB-11021 Changing docs styling

2016-04-06 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206601373 @riknoll yeah. The latest merge to the ASF Git master hasn't reflected in the GitHub master yet because it was a large commit. Sorry, the best way to see

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58787128 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58786905 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58786335 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785566 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785401 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,93 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785263 --- Diff: lib/utils/execWrapper.js --- @@ -0,0 +1,39 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785033 --- Diff: lib/paramedic.js --- @@ -0,0 +1,232 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771737 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771547 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-06 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771505 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,141 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-04-06 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs pull request: CB-11021 Changing docs styling

2016-04-05 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206091474 @riknoll Please give this another look. I added an attributions page. @rakatyal I fixed the footer to be slightly different for the docs and for the rest

[GitHub] cordova-paramedic pull request: Paramedic improvements

2016-04-05 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58642061 --- Diff: paramedic-plugin/paramedic.js --- @@ -0,0 +1,74 @@ +var io = cordova.require('cordova-plugin-paramedic.socket.io'); --- End diff

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/567#discussion_r58628814 --- Diff: www/_includes/footer.html --- @@ -1,6 +1,6 @@ - --- End diff -- Great catch! It makes the footer look a bit

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-05 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206025768 @riknoll thanks for pointing that out! I've created a JIRA: https://issues.apache.org/jira/browse/CB-11021. I'll also add the font attribution to the footer

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-04-04 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/569#discussion_r58451039 --- Diff: www/.htaccess --- @@ -18,29 +18,31 @@ RewriteEngine on # pages to new pages. # 302 (temp): -# docs

[GitHub] cordova-docs pull request: Changing docs styling.

2016-04-04 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-205501906 @nikhilkh @sarangan12 @riknoll @rakatyal: whenever any of you have any time, please give this a look. --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/569#discussion_r58139811 --- Diff: www/.htaccess --- @@ -18,29 +18,31 @@ RewriteEngine on # pages to new pages. # 302 (temp): -# docs

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57990944 --- Diff: buildbot-conf/cordova-config.json.sample --- @@ -12,8 +12,8 @@ "appium": { "androidDeviceName"

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-29 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/569#discussion_r57813112 --- Diff: www/.htaccess --- @@ -18,29 +18,31 @@ RewriteEngine on # pages to new pages. # 302 (temp): -# docs

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-29 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/569#issuecomment-203118863 @rakatyal @riknoll ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

2016-03-28 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-202714763 How often does the test pass now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: Improving inline quotes styling

2016-03-25 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/568#issuecomment-201588433 Cool. LGTM then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-25 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/569#issuecomment-201587290 @riknoll @rakatyal please review when you get a chance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Adding both Chinese versions.

2016-03-25 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/569 Adding both Chinese versions. - Copied `zh` into `zh-tw` and added `zh-cn` - Added redirect for `/zh/` to `/zh-tw/` - Fixed the language name in `gen_versions.js` - Fixed regexes

[GitHub] cordova-docs pull request: Improving inline quotes styling

2016-03-25 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/568#issuecomment-201585917 Should this be global, or within `_docs.scss`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

2016-03-25 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r57437633 --- Diff: sample-config/.paramedic.config.js --- @@ -0,0 +1,33 @@ +module.exports = { +//"externalServerUrl": "ht

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

2016-03-25 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r57437554 --- Diff: lib/utils.js --- @@ -0,0 +1,22 @@ +var shelljs = require('shelljs'); +var verbose = undefined; --- End diff -- Please

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

2016-03-25 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r57437413 --- Diff: lib/specReporters.js --- @@ -0,0 +1,68 @@ + +// not currently used +// var ConsoleReporter = require('./reporters

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

2016-03-25 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r57437363 --- Diff: lib/reporters/ConsoleReporter.js --- @@ -0,0 +1,153 @@ +var noopTimer = { +start: function(){}, +elapsed: function

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

2016-03-25 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r57437252 --- Diff: lib/ParamedicConfig.js --- @@ -0,0 +1,83 @@ +var Target = require('./Target'); + +var DEFAULT_START_PORT = 8008; +var

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

2016-03-25 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/1#discussion_r57432822 --- Diff: main.js --- @@ -1,43 +1,51 @@ #!/usr/bin/env node var parseArgs = require('minimist'), -paramedic = require

[GitHub] cordova-docs pull request: Changing docs styling.

2016-03-24 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/567 Changing docs styling. - Styling ToC - Changing color scheme for headings - Changing the font Result: ![capture](https://cloud.githubusercontent.com/assets/405489

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-23 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r57245776 --- Diff: appium-tests/common/common.spec.js --- @@ -0,0 +1,321 @@ +/*jshint node: true, jasmine: true, browser: true */ +/*global

[GitHub] cordova-plugin-file-transfer pull request: CB-10782: Occasional fa...

2016-03-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/132#issuecomment-200492702 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file-transfer pull request: CB-10782: Occasional fa...

2016-03-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57049010 --- Diff: tests/tests.js --- @@ -451,11 +451,25 @@ exports.defineAutoTests = function

[GitHub] cordova-plugin-file-transfer pull request: CB-10782: Occasional fa...

2016-03-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57047060 --- Diff: tests/tests.js --- @@ -1114,6 +1125,9 @@ exports.defineAutoTests = function

[GitHub] cordova-plugin-file-transfer pull request: CB-10782: Occasional fa...

2016-03-22 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57046468 --- Diff: tests/tests.js --- @@ -451,11 +451,25 @@ exports.defineAutoTests = function

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-20 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579423 --- Diff: src/android/FileUtils.java --- @@ -73,8 +73,13 @@ Licensed to the Apache Software Foundation (ASF) under one * Permission

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-03-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-198858128 @mikaelkindborg thank you for submitting your app to the showcase! Sorry that it took us so long to address your PR. The Cordova developer community had

  1   2   3   4   5   6   7   8   9   >