[GitHub] cordova-plugin-file pull request: CB-10317 Encoded # in uri parse

2016-05-02 Thread dhams
Github user dhams commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-216162738 @adamscybot Right , iOS version is able to parse this special char. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-file pull request: CB-10317 Encoded # in uri parse

2016-03-21 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-file/pull/172 CB-10317 Encoded # in uri parse If we use # in folder name or file name Uri is not able parse that path as of now. As Uri class not parse # symbol (Uri class reserved that # as

[GitHub] cordova-docs pull request: Cb 10637

2016-03-14 Thread dhams
Github user dhams commented on the pull request: https://github.com/apache/cordova-docs/pull/504#issuecomment-196665529 closing this PR as that changes has already been covered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Cb 10637

2016-03-14 Thread dhams
Github user dhams closed the pull request at: https://github.com/apache/cordova-docs/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

2016-02-19 Thread dhams
Github user dhams commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53453538 --- Diff: src/android/SplashScreen.java --- @@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog

[GitHub] cordova-plugin-splashscreen pull request: CB-10643cordova plugin s...

2016-02-19 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/85 CB-10643cordova plugin splashscreen : Added new preference to choose whether dialog is cancelable or not. Added option to choose whether developer wants cancelable dialog or not

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

2016-02-18 Thread dhams
Github user dhams commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/83#issuecomment-185711822 trying to correct travis-ci issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

2016-02-18 Thread dhams
Github user dhams closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

2016-02-18 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/83 Give option for Splashscreen spinner cancelable event Added option to choose user whether they want cancelable dialog or not while loading splashscreen. I added preference

[GitHub] cordova-docs pull request: Cb 10637

2016-02-17 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-docs/pull/504 Cb 10637 Fixed link location which was previously not correct. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-docs CB

[GitHub] cordova-plugin-splashscreen pull request: Cb 6498

2016-02-10 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/81 Cb 6498 Fixed document issue for android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread dhams
Github user dhams closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread dhams
Github user dhams commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52311417 --- Diff: README.md --- @@ -123,6 +123,8 @@ window.setTimeout(function () { }, splashDuration - fadeDuration

[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue

2016-02-09 Thread dhams
GitHub user dhams opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/80 Fixed doccument issue Changed miss leaded document. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accenture/cordova-plugin

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

2016-01-27 Thread dhams
Github user dhams commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-175609597 Sorry guys but that not comes with the fixes ... Same #/CB-9189 is still there even after update 5.4.1 --- If your project is set up for it, you can reply to this