[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2017-01-02 Thread ephemer
Github user ephemer commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Let's merge #187! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-plugin-inappbrowser pull request #162: CB-11136: Fix OAuth by preven...

2017-01-02 Thread ephemer
Github user ephemer closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-09-21 Thread ephemer
Github user ephemer commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 @manucorporat the term is reference counted and deinited / cleaned up. "Garbage Collection" sounds like heresy to my ears, but the principles are somewhat similar,

[GitHub] cordova-plugin-wkwebview-engine issue #13: CB-11074 - Ensure settings from c...

2016-08-15 Thread ephemer
Github user ephemer commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13 Without having tested this, it seems reasonable to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...

2016-04-29 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215702371 @shazron in that case we'd have to remove the configuration code from updateWithInfo because we've already established that it

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...

2016-04-28 Thread ephemer
GitHub user ephemer opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 CB-11074: Ensure settings from config.xml are taken into consideration #7 also addresses this issue but in my tests didn't work. This pull request prese

[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-04-28 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215453411 As I commented in the base repo, this PR doesn't do what it says it does yet. @shazron is it normal to change the settings afte

[GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...

2016-04-26 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-214827853 Thank you, my pleasure. I have thought about this a bit longer.. The main issue is that recent Cordova changes, namely introducing

[GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...

2016-04-21 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-213118009 I agree that it feels kind of wrong. The problem is that many users (myself included) have no control over the call site for window.open

[GitHub] cordova-plugin-inappbrowser pull request: CB-11136: Fix OAuth by p...

2016-04-21 Thread ephemer
GitHub user ephemer opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView thread Presenting a UIViewController in front of the main Cordova UIViewController containing a

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-04-01 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-88513471 @dpogue I was able to install the new version using `cordova platform update ios@4.0.x --usegit` – that didn't seem to update my CordovaLib though (which

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-04-01 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-88510493 @dpogue thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-04-01 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-88504169 @shazron how can I test the 4.0.x branch ? cordova platform update ios@4.0.0 doesn't work - is there another way using the CLI? or what's the best way