[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-12 Thread git
lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-12 Thread git
+ -'target \'%s\' do\n' + +'platform :ios, \'%s\'\n' + +'use_frameworks!\n' + Review comment: It doesn't allow to add swift libraries in Podfile. ---- This is an automated

[GitHub] igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-12 Thread git
+ -'target \'%s\' do\n' + +'platform :ios, \'%s\'\n' + +'use_frameworks!\n' + Review comment: It doesn't allow to add swift libraries in Podfile. ---- This is an automated

[GitHub] wf9a5m75 commented on issue #302: CB-11895: openURL: is deprecated on iOS 10

2017-08-11 Thread git
message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup

2017-08-11 Thread git
ropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With rega

[GitHub] shazron commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git
t \'%s\' do\n' + +'platform :ios, \'%s\'\n' + +'use_frameworks!\n' + Review comment: we can't use `use_frameworks!`. See: https://issues.apache.org/jira/browse/CB-11893 -------

[GitHub] shazron commented on issue #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

2017-08-11 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno?

2017-08-11 Thread git
shazron closed pull request #321: CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno? URL: https://github.com/apache/cordova-ios/pull/321 This is an automated message from the Apache Git Service

[GitHub] shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-11 Thread git
shazron closed pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] iget-master commented on issue #393: Fix for Jira issue CB-12981

2017-08-11 Thread git
issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, A

[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE

2017-08-11 Thread git
droid. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] macdonst closed pull request #399: CB-12730: Compat - INTEGRATE

2017-08-11 Thread git
macdonst closed pull request #399: CB-12730: Compat - INTEGRATE URL: https://github.com/apache/cordova-android/pull/399 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] codecov-io commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git
lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] igormartsekha commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-11 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] janpio commented on issue #244: CB-10140 Use application id instead of package name when running

2017-08-11 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] codecov-io commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2017-08-10 Thread git
cec6...24a0923](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---- This is an automated message from the Apache Git Service.

[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
@@ + Review comment: rebased + added This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
@@ + Review comment: _makes mental note as good use case for integration test_ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the

[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-10 Thread git
:) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] shazron commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
@@ + Review comment: Yes, see the linked commit description. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment

[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] filmaj commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
@@ + Review comment: really my locally generated project worked fine without that This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2017-08-10 Thread git
e thats it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Wi

[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2017-08-10 Thread git
se already. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards,

[GitHub] dpogue commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2017-08-10 Thread git
is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2017-08-10 Thread git
l request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Gi

[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-10 Thread git
l request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.

[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-10 Thread git
mit them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.ap

[GitHub] shazron commented on a change in pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
37860 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure a

[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] codecov-io commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For qu

[GitHub] filmaj commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Gi

[GitHub] shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-10 Thread git
shazron closed pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329 This is an automated message from the Apache G

[GitHub] shazron commented on issue #330: CB-13164: Integrated cordova-plugin-console

2017-08-10 Thread git
able to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.

[GitHub] shazron commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-10 Thread git
ne feature This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.

[GitHub] filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-09 Thread git
droid) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated mes

[GitHub] janpio commented on issue #389: WIP: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-09 Thread git
essage from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apac

[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-08 Thread git
's up. Wait for Travis to finish testing to see if its a common error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific co

[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

2017-08-08 Thread git
o see what's up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact I

[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2017-08-08 Thread git
shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321104510 eslint errors. This is an automated message from the Apache Git

[GitHub] shazron closed pull request #328: CB-13093: (iOS) Infinite looping when stressing navigation

2017-08-08 Thread git
shazron closed pull request #328: CB-13093: (iOS) Infinite looping when stressing navigation URL: https://github.com/apache/cordova-ios/pull/328 This is an automated message from the Apache Git Service. To respond to the

[GitHub] codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-08 Thread git
src=pr&el=footer). Last update [8edd13a...01fcaa4](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an autom

[GitHub] codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-08 Thread git
src=pr&el=footer). Last update [8edd13a...01fcaa4](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an autom

[GitHub] shazron opened a new pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

2017-08-08 Thread git
message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. -----

[GitHub] codecov-io commented on issue #401: CB-8976: Added the `cdvVersionCodeForceAbiDigit` property

2017-08-07 Thread git
pull/401?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] feichngr opened a new pull request #401: CB-8976: Added the `cdvVersionCodeForceAbiDigit` property

2017-08-07 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With

[GitHub] filmaj commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-04 Thread git
t.xml. One thing at a time, moving closer! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-04 Thread git
ybe a workaround could go here: https://github.com/apache/cordova-common/blob/master/src/ConfigChanges/ConfigKeeper.js#L40-L44 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-04 Thread git
essage from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apac

[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-04 Thread git
---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-04 Thread git
ta` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=footer). Last update [2b53c98...8fdb16c](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-04 Thread git
ce I don't use the CLI. Want to take a quick look again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For que

[GitHub] filmaj commented on issue #399: CB-12730: Compat - INTEGRATE

2017-08-03 Thread git
ssage from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Gi

[GitHub] filmaj commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-03 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] macdonst commented on issue #399: CB-12730: Compat - INTEGRATE

2017-08-03 Thread git
dialogs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-03 Thread git
ng else is copying over MainActivity. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-03 Thread git
add git://github.com/infil00p/cordova-android.git#StudioProjectCompat ``` In my platforms/android I ended up with both an app folder and a src folder, and I have a MainActivity.java in both. Is that expected? ``` android ??? app ??? ??? src ??? ??? main

[GitHub] shazron closed pull request #40: Test again, the sequel. No JIRA prefix.

2017-08-02 Thread git
shazron closed pull request #40: Test again, the sequel. No JIRA prefix. URL: https://github.com/apache/cordova-browser/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] shazron closed pull request #39: CB-123 - Test again

2017-08-02 Thread git
shazron closed pull request #39: CB-123 - Test again URL: https://github.com/apache/cordova-browser/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] shazron commented on issue #39: CB-123 - Test again

2017-08-02 Thread git
shazron commented on issue #39: CB-123 - Test again URL: https://github.com/apache/cordova-browser/pull/39#issuecomment-319768397 Test comment (with prefix) This is an automated message from the Apache Git Service. To

[GitHub] shazron commented on issue #40: Test again, the sequel. No JIRA prefix.

2017-08-02 Thread git
shazron commented on issue #40: Test again, the sequel. No JIRA prefix. URL: https://github.com/apache/cordova-browser/pull/40#issuecomment-319768329 Test comment (no prefix) This is an automated message from the Apache Git