[GitHub] cordova-docs issue #629: Update index.md according to CB-11705

2016-08-21 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-docs/pull/629 GitHub linked the wrong pull request. Here is the correct one (for the correct project): https://github.com/apache/cordova-ios/pull/241 --- If your project is set up for it, you can reply to

[GitHub] cordova-docs pull request #629: Update index.md according to CB-11705

2016-08-21 Thread hnilsen
GitHub user hnilsen opened a pull request: https://github.com/apache/cordova-docs/pull/629 Update index.md according to CB-11705 As per requested by PR #241 for CB-11705, I have made changes to the documentation to reflect the use of CordovaDefaultWebViewEngine. You can merge this

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-21 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 Sure thing - I'll edit the docs accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-17 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 Yes, the current situation is that I can supply a plugin for my own WKWebView, but not for the UIWebView, which is a private plugin. I'd like to be able to control them both. My PR

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-17 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 That doesn't swap out the private CDVUIWebViewEngine used by iOS8, does it? That's why I'm adding the option to extract and use my own version of CDVUIWebViewEngine. This is what

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-15 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 JIRA task: https://issues.apache.org/jira/browse/CB-11705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-ios issue #241: CB-11705 - Adding CordovaDefaultWebViewEngine config...

2016-08-15 Thread hnilsen
Github user hnilsen commented on the issue: https://github.com/apache/cordova-ios/pull/241 This is from a discussion in #cordova-ios on Slack. cc @shazron --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request #241: CB-11705 - Adding CordovaDefaultWebViewEngine...

2016-08-15 Thread hnilsen
GitHub user hnilsen opened a pull request: https://github.com/apache/cordova-ios/pull/241 CB-11705 - Adding CordovaDefaultWebViewEngine configuration Adding CordovaDefaultWebViewEngine configuration option to be able to use a different WebView as default and/or fallback

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-15 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52292210 Our QA-team has now run through Samsung S2, S3, S4, S4, Note, Note II, HTC One and Nexus devices, and also ZTE Blade and HTC Desire HD (both running 2.2 and 2.3

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-15 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52285259 The patch from you doesn't work. I've implemented my patch instead, and everything is peachy. I've sent this to our QA-team for testing. I'

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-15 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52284281 I've tested your patch now, and I can't see that it solves this issue. I'll test more, and I'll also try my own patch later. --- If your p

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-14 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52166091 I wasn't aware this wasn't in 3.5.1. This error is persistent, and should affect many users with Samsung devices (especially). I'll try to apply

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-13 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52066802 I was away on vacation, so couldn't answer to your comments. I'm back at work, and we've updated Cordova on Android to 3.5.1, in resp

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657992 True, success() doesn't keep the callback, but for us it's not important. I changed the success() function to always keep callback, but that changed n

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657793 I saw your comment, but reading from a mobile device, so I can't really test it out. My fix is exclusively for 3.3.x, there has been made lots if changes

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-09 Thread hnilsen
GitHub user hnilsen opened a pull request: https://github.com/apache/cordova-android/pull/105 [CB-7104] Fix for the missing plugin message Please have a look at this. This might not be the cleanest fix for [CB-7104], but it does the job. It will toggle only when messages are in the