[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949451 --- Diff: test/src/org/apache/cordova/test/SabotagedActivity.java --- @@ -33,10 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949465 --- Diff: test/src/org/apache/cordova/test/backgroundcolor.java --- @@ -33,5 +33,4 @@ public void onCreate(Bundle savedInstanceState

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949468 --- Diff: test/src/org/apache/cordova/test/errorurl.java --- @@ -22,12 +22,14 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949530 --- Diff: test/src/org/apache/cordova/test/splashscreen.java --- @@ -30,6 +32,8 @@ public void onCreate(Bundle savedInstanceState

[GitHub] cordova-android pull request: CB-6543: Fix cordova/run failure whe...

2014-04-28 Thread huningxin
GitHub user huningxin opened a pull request: https://github.com/apache/cordova-android/pull/99 CB-6543: Fix cordova/run failure when no custom_rules.xml available. You can merge this pull request into a Git repository by running: $ git pull https://github.com/huningxin

[GitHub] cordova-android pull request: CB-6543: Fix cordova/run failure whe...

2014-04-28 Thread huningxin
Github user huningxin commented on the pull request: https://github.com/apache/cordova-android/pull/99#issuecomment-41634753 @agrieve, PTAL. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does