Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-222021395
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836957
--- Diff: tests/tests.js ---
@@ -3441,6 +3441,27 @@ exports.defineAutoTests = function
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836116
--- Diff: tests/tests.js ---
@@ -3441,6 +3441,27 @@ exports.defineAutoTests = function
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64834967
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64688561
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/305#issuecomment-219825870
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/176#issuecomment-219552867
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/176#discussion_r63426276
--- Diff: bin/lib/create.js ---
@@ -46,15 +47,15 @@ module.exports.create = function (destinationDir,
config, options) {
var root
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-ios/pull/223#issuecomment-219494395
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/439#issuecomment-218885704
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/176#issuecomment-218882039
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/176#discussion_r63094515
--- Diff: template/cordova/lib/build.js ---
@@ -171,11 +171,11 @@ function parseAndValidateArgs(options) {
// Validate args
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/305#issuecomment-218880614
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/439#discussion_r63092520
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -286,7 +286,7 @@ module.exports = function plugin(command, targets,
opts
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-218324502
Oh, yeah I'll update those tests.
---
In reply to:
[218305527](https://github.com/apache/cordova-windows/pull/174#issuecomment-218305527
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-ios/pull/220#issuecomment-218005495
@shazron I know - a cordova-common 1.3 release is in progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217281613
As discussed, I tested this with symbolic links both at the root and in a
subdirectory. It works fine without any special symlink handling in the code
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r62252220
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,20 +22,20 @@ var fs = require('fs');
var path = require('path');
var _ = require
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217236642
@nikhilkh waiting on you. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-217040413
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r62068625
--- Diff: cordova-lib/cordova-lib.js ---
@@ -18,19 +18,35 @@
*/
// For now expose plugman and cordova just as they were in the old repos
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/303#issuecomment-216705549
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61976209
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -203,6 +203,11 @@ GradleBuilder.prototype.build = function(opts
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975714
--- Diff: bin/lib/check_reqs.js ---
@@ -238,13 +236,13 @@ module.exports.getAbsoluteAndroidCmd = function () {
return cmd.replace(/(\s)/g
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975678
--- Diff: bin/lib/check_reqs.js ---
@@ -254,18 +252,22 @@ module.exports.check_android_target =
function(valid_target
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-windows/pull/174
CB-7: Optimize prepare for windows platform, clean prepared files
This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip
copying files that didn't change. Some
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-ios/pull/220
CB-7: Optimize prepare for ios platform, clean prepared files
This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip
copying files that didn't change. Some refactoring
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-21788
Do the icons have title text? If so I can't find it in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-216665227
> The Apple logo is now used to indicate the OS X platform.
This is confusing to me, given that I never think about using Cordova to
develop apps for O
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216624907
If you're talking about a source file, then that would change the
last-modified timestamp of the source file, causing it to be newer than the
target file so
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216618237
BTW, I didn't mention above the reason I had to abandon the approach of
checking for exactly-equal modified times. The problem is the OS X filesystem
doesn't
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216617718
@purplecabbage If a hook fails because it expected a file would be
refreshed but it wasn't, then I'd expect the hook to print an error (or stack
trace), so
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216611405
All right, I think this is the best we can do. The latest logic copies the
file if the source's last-modified time is >= the target's last-modified t
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61915826
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61915398
--- Diff: cordova-lib/src/platforms/PlatformApiPoly.js ---
@@ -474,7 +473,12 @@ function getCreateArgs(destinationDir, projectConfig,
options
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61914375
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913509
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913318
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913141
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912923
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912394
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912274
--- Diff: cordova-common/cordova-common.js ---
@@ -3,7 +3,7 @@
or more contributor license agreements. See the NOTICE file
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216585668
Well, after further testing I found creation dates don't work reliably due
to some strange behavior on Windows:
http://serverfault.com/questions/92757/incorrect
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/295#issuecomment-216320625
I updated the PR based on feedback. As mentioned in the other comment I've
kept the clean functionality, but it is now skipped when not invoked via the
CLI
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216319068
I updated the PR to use target creation times instead of modified-times. It
works much better: it doesn't require the messy workaround on Windows and
doesn't have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61776793
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216309577
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61665577
--- Diff: template/www/cordova.js ---
@@ -1508,9 +1509,10 @@ module.exports = {
// OR cordova.require('cordova/platform
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61665566
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,10 @@ module.exports = {
// OR cordova.require('cordova/platform
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61665459
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215911697
@nikhilkh As we discussed, this workaround was the best I could find. The
command script approach has similar performance to just copying files via the
node fs
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/433#issuecomment-215898416
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/433#discussion_r61653369
--- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js ---
@@ -17,19 +17,25 @@
under the License.
*/
+var fs = require
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/171#issuecomment-215891369
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-ios/pull/219#issuecomment-215890484
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215780851
I need to add a workaround for the nodejs bug in setting file timestamps on
Windows: https://github.com/nodejs/node/issues/2069
---
If your project is set up
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61504885
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -84,29 +101,49 @@ function updateConfigFilesFrom(sourceConfig,
configMunger, locations
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61503079
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/301#issuecomment-215561101
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/301#issuecomment-215533601
Can I ignore all the changes under node_modules? I don't understand why
that is checked in to source control...
---
If your project is set up for it, you can
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61462710
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/295#discussion_r61461619
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest');
var xmlHelpers
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/295#issuecomment-215256784
@vladimir-kotikov @infil00p please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215255548
@vladimir-kotikov I think this is ready to go after the latest update.
Please let me know if you have any further comments.
---
If your project is set up
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/431#issuecomment-214811002
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/431#discussion_r61116509
--- Diff: cordova-common/src/CordovaLogger.js ---
@@ -209,7 +209,7 @@ function formatError(error, isVerbose) {
message = error
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214543607
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60482215
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481666
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460847
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460033
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459967
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459281
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60458884
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60452183
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60450430
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60449617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60448617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-android/pull/295
CB-7: Use FileUpdater to optimize prepare for android platform
This uses the FileUpdater module added in
https://github.com/apache/cordova-lib/pull/429 to optionally skip copying
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-212121255
I opened CB-7 to track this work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-212039256
@nikhilkh @vladimir-kotikov please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/429
Add FileUpdater module to cordova-common
The new FileUpdater module contains a few functions that enable optimized
file copies by comparing timestamps. These functions are primarily
Github user jasongin closed the pull request at:
https://github.com/apache/cordova-cli/pull/244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-ios/pull/218#issuecomment-210559586
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/427#issuecomment-210559039
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/167#issuecomment-210556467
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/167#discussion_r59909776
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -123,24 +123,27 @@ var handlers = {
throw new CordovaError(' tag without
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/244#discussion_r59906168
--- Diff: doc/readme.md ---
@@ -464,29 +464,31 @@ cordova build [ [...]]
### Synopsis
-Prepares, builds (unless `--nobuild
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209669073
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-209620711
Yes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209571650
@omefire Isn't that covered by the update to docs/readme.md in this change?
Or is it duplicated somewhere else?
---
If your project is set up for it, you can
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#discussion_r59583794
--- Diff: src/ios/CDVCamera.m ---
@@ -358,6 +358,7 @@ - (NSData*)processImage:(UIImage*)image
info:(NSDictionary*)info options:(CDVPic
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-cli/pull/244
CB-11042: Add cordova run option to skip prepare
Parse and document a --noprepare option for the cordova run command.
See https://github.com/apache/cordova-lib/pull/426
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/426
CB-11042: Add cordova run option to skip prepare
I'm also submitting a PR for the cordova-cli repo to parse and document the
--noprepare option.
You can merge this pull request into a Git
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-208603032
OK, I didn't realize config file transformations were also done already in
plugin add. And I think I have a better understanding of the code now.
My
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-207527874
This code is pretty hard to follow. I don't mean your changes, but plugin
installation overall is more complex than I expected.
How do these changes
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/573#issuecomment-207138716
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/573#discussion_r58962639
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -348,6 +349,7 @@ platform. See [Customize icons topic](images.html) for
more information
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207123605
Rob, what platform are you looking at?
The W3C FileSystems spec for web browsers is deprecated; what that
effectively means is no other browsers
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-207076949
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
1 - 100 of 199 matches
Mail list logo
