[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...

2014-12-05 Thread jbavari
Github user jbavari commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-65865043 Works great. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-3679 Move splashscreen logic into...

2014-12-05 Thread jbavari
Github user jbavari commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-65858347 Andrew, I looked through the code. Everything looks good from what I saw here. :+1: --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-registry-web pull request: Added the default route to redi...

2014-05-28 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/4 Added the default route to redirect to homepage incase someone links to the wrong page Better to just show the homepage then to just see nothing. Found this from someone linking to the

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-10 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-plugman/pull/73 CB-6414 - fixes the issue where two config.xml munges exists, it will st... As seen in this issue: https://issues.apache.org/jira/browse/CB-6414 Referencing this comment by

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread jbavari
Github user jbavari closed the pull request at: https://github.com/apache/cordova-plugman/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread jbavari
Github user jbavari commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-39987478 I will close it @agrieve I have started looking into how the config_keeper is being used. I will try to figure it out still, however, I might not be as fast

[GitHub] cordova-registry-web pull request: CB-6285

2014-04-08 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/3 CB-6285 Optimization - made pluggy.svg into pluggy.png - now referenced by stylesheets. Removed the livereload script - via grunt preprocess and copy. No longer should have

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-08 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-plugman/pull/72 CB-6414 - fixes the issue where two config.xml munges exists, it will st... https://issues.apache.org/jira/browse/CB-6414 You can merge this pull request into a Git repository by running

[GitHub] cordova-registry-web pull request: Refactor

2014-03-30 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/2 Refactor Fixes for these issues: https://issues.apache.org/jira/browse/CB-6279 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-registry-web pull request: Refactor

2014-03-25 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/1 Refactor Steve, Here are most of the changes as outlined from some of my notes in JIRA. Please note the new view on app.js. There is a lot in this commit. I am sorry