[GitHub] cordova-android pull request: CB-8717 Write cordova-android@4.0.0 ...

2015-03-27 Thread jpchase
Github user jpchase commented on the pull request: https://github.com/apache/cordova-android/pull/167#issuecomment-86982723 @jsoref I included some of the corrections from your changes. I believe the release notes read better with less formatting, so I excluded many of your changes

[GitHub] cordova-docs pull request: CB-8715 Update upgrade guide for Androi...

2015-03-26 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-docs/pull/274 CB-8715 Update upgrade guide for Android 4.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpchase/cordova-docs CB-8715-Upgrade

[GitHub] cordova-android pull request: CB-8717 Write cordova-android@4.0.0 ...

2015-03-25 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-android/pull/167 CB-8717 Write cordova-android@4.0.0 release notes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpchase/cordova-android CB-8717

[GitHub] cordova-docs pull request: CB-8715 Update docs for whitelist chang...

2015-03-24 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-docs/pull/272 CB-8715 Update docs for whitelist changes - Update Whitelist guide for changes in cordova-android 4.0.0 and cordova-ios 4.0.0 - Link guide to cordova-plugin-whitelist for detailed

[GitHub] cordova-plugin-inappbrowser pull request: CB-8444 Don't clobber `w...

2015-02-12 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/80 CB-8444 Don't clobber `window.open` There are scenarios where an app needs the built-in `window.open` functionality (i.e. to open an url in the system browser

[GitHub] cordova-plugin-test-framework pull request: CB-8295 Enable CSP for...

2015-01-14 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/8 CB-8295 Enable CSP for mobile spec - Uses a javascript include file (provided by mobile spec app) to document.write a CSP tag on page - If hosted outside of mobile spec

[GitHub] cordova-mobile-spec pull request: CB-8295 Enable CSP for mobile sp...

2015-01-13 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/115 CB-8295 Enable CSP for mobile spec - Uses a javascript include file to document.write a CSP meta tag on page - Minor changes to test pages where need to comply with CSP (e.g. remove

[GitHub] cordova-js pull request: CB-8210 Remove unused onDestroy channel

2015-01-09 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-js/pull/99 CB-8210 Remove unused onDestroy channel - Channel was defined as internal event and fired by javascript eval() - Rather than change firing of event, simpler to remove as was not used

[GitHub] cordova-android pull request: CB-8210 Remove unused onDestroy chan...

2015-01-09 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-android/pull/146 CB-8210 Remove unused onDestroy channel - Channel was defined as internal event and fired by javascript eval() - Rather than change firing of event, simpler to remove as was not used

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

2015-01-08 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-media/pull/41 CB-8252 Fire audio events from native via message channel - Add startup logic to initialize a message channel for native - Javascript - Applies only to android and amazon-fireos

[GitHub] cordova-js pull request: CB-8210 android: Fire events from native ...

2015-01-05 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-js/pull/97 CB-8210 android: Fire events from native via message channel - Events implemented via message channel: various buttons, pause/resume You can merge this pull request into a Git repository

[GitHub] cordova-android pull request: CB-8210 Use PluginResult for various...

2015-01-05 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-android/pull/144 CB-8210 Use PluginResult for various events from native - Change to send events via plugin message channel: various buttons, pause/resume Related to: apache/cordova-js#97 You can

[GitHub] cordova-android pull request: CB-8210 Setup message channel for na...

2014-12-30 Thread jpchase
Github user jpchase commented on the pull request: https://github.com/apache/cordova-android/pull/142#issuecomment-68395947 The two additional commits address the review comments to use the plugin instance. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-android pull request: CB-8210 Setup message channel for na...

2014-12-24 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-android/pull/142 CB-8210 Setup message channel for native - JS events - Initialize a message channel for native - Javascript in the core App plugin - Change keyboard detection to send events via plugin

[GitHub] cordova-js pull request: CB-8210 android: Add message channel for ...

2014-12-24 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-js/pull/96 CB-8210 android: Add message channel for events - Initialize a message channel for native - Javascript via the core App plugin - Use channel to receive events from native to be fired

[GitHub] cordova-lib pull request: CB-8154 - Fix errors adding platforms or...

2014-12-12 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-lib/pull/130 CB-8154 - Fix errors adding platforms or plugins - Added utility function to unpack a package.tgz file (gzip + tar) - Use the new utility function when fetching plugins from the registry

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...

2014-09-22 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/6 CB-7459 Add header to show number of enabled plugin tests It is not obvious if all/how many plugin tests are being run, given that: - Individual plugin tests can be enabled