[GitHub] cordova-plugin-file-transfer pull request: CRC downloaded files ov...

2014-11-04 Thread jpuerto
Github user jpuerto commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/47#issuecomment-61642252 If you want to add this headers, why can't you add this headers directly when you made the request? See: https://github.com/apache/cordova

[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...

2014-07-04 Thread jpuerto
Github user jpuerto commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/32#issuecomment-48033590 Could someone take care of this PR? TIA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...

2014-06-18 Thread jpuerto
GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/32 CB-6928: Implements NOT_MODIFIED check downloading resources. Introduce FileTransferError.NOT_MODIFIED_ERR, execute error callback for 304 status code. You can merge this pull

[GitHub] cordova-mobile-spec pull request: CB-6928: Add 304 response test

2014-06-18 Thread jpuerto
GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/71 CB-6928: Add 304 response test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpuerto/cordova-mobile-spec master Alternatively

[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...

2014-06-17 Thread jpuerto
Github user jpuerto closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...

2014-06-17 Thread jpuerto
Github user jpuerto commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/31#issuecomment-46279769 As commented in the dev mailing list, this patch is not valid. We need to return the caching status with the error callback so the developer can act

[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...

2014-06-12 Thread jpuerto
GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/31 CB-6928: Implements NOT_MODIFIED check downloading resources. As described in the issue https://issues.apache.org/jira/browse/CB-6928 A 304 status code will corrupt